Adding engagement metrics with the Incompatible Applications page.

Bug: 820539
Change-Id: I0856f63795bc9428eb83ca36cf3d8ff91c6629e3
Reviewed-on: https://chromium-review.googlesource.com/957465
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543128}

chrome/browser/ui/startup/startup_tab_provider.cc

@@ -339,6 +339,7 @@ GURL StartupTabProviderImpl::GetWin10WelcomePageUrl(
 #if defined(GOOGLE_CHROME_BUILD)
 // static
 GURL StartupTabProviderImpl::GetIncompatibleApplicationsUrl() {
+  UMA_HISTOGRAM_BOOLEAN("IncompatibleApplicationsPage.AddedPostCrash", true);
   GURL url(chrome::kChromeUISettingsURL);
   return url.Resolve("incompatibleApplications");
 }

chrome/browser/ui/webui/settings/incompatible_applications_handler_win.cc

@@ -10,6 +10,8 @@
 
 #include "base/bind.h"
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
+#include "base/metrics/user_metrics.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "base/win/registry.h"
@@ -95,7 +97,7 @@ void IncompatibleApplicationsHandler::HandleRequestIncompatibleApplicationsList(
           {program.info, std::move(registry_key_watcher)});
     }
 
-    // Also the application to the list that is passed to the javascript.
+    // Also add the application to the list that is passed to the javascript.
     base::Value dict(base::Value::Type::DICTIONARY);
     dict.SetKey("name", base::Value(program.info.name));
     dict.SetKey("type", base::Value(program.blacklist_action->message_type()));
@@ -103,6 +105,9 @@ void IncompatibleApplicationsHandler::HandleRequestIncompatibleApplicationsList(
     application_list.GetList().push_back(std::move(dict));
   }
 
+  UMA_HISTOGRAM_COUNTS_100("IncompatibleApplicationsPage.NumApplications",
+                           problematic_programs.size());
+
   const base::Value& callback_id = args->GetList().front();
   ResolveJavascriptCallback(callback_id, application_list);
 }
@@ -110,6 +115,8 @@ void IncompatibleApplicationsHandler::HandleRequestIncompatibleApplicationsList(
 void IncompatibleApplicationsHandler::HandleStartProgramUninstallation(
     const base::ListValue* args) {
   CHECK_EQ(1u, args->GetList().size());
+  base::RecordAction(base::UserMetricsAction(
+      "IncompatibleApplicationsPage.UninstallationStarted"));
 
   // Open the Apps & Settings page with the program name highlighted.
   uninstall_application::LaunchUninstallFlow(
@@ -150,6 +157,9 @@ void IncompatibleApplicationsHandler::GetPluralString(
 
 void IncompatibleApplicationsHandler::OnApplicationRemoved(
     const InstalledPrograms::ProgramInfo& program) {
+  base::RecordAction(base::UserMetricsAction(
+      "IncompatibleApplicationsPage.ApplicationRemoved"));
+
   registry_key_watchers_.erase(program);
   FireWebUIListener("incompatible-application-removed",
                     base::Value(program.name));

tools/metrics/actions/actions.xml

@@ -6845,6 +6845,23 @@ should be able to be added at any place in this file.
   </description>
 </action>
 
+<action name="IncompatibleApplicationsPage.ApplicationRemoved">
+  <owner>pmonette@chromium.org</owner>
+  <description>
+    A user uninstalled one of the listed incompatible applications while the
+    chrome://settings/incompatibleApplications page was open.
+  </description>
+</action>
+
+<action name="IncompatibleApplicationsPage.UninstallationStarted">
+  <owner>pmonette@chromium.org</owner>
+  <description>
+    A user clicked the &quot;Uninstall&quot; button for one of the listed
+    incompatible applications while the
+    chrome://settings/incompatibleApplications was open.
+  </description>
+</action>
+
 <action name="Indent">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>

tools/metrics/histograms/histograms.xml

@@ -30444,6 +30444,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="IncompatibleApplicationsPage.AddedPostCrash"
+    enum="BooleanShown">
+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    Records whether the user was automatically shown the
+    chrome://settings/incompatibleApplications page following a Chrome crash.
+  </summary>
+</histogram>
+
+<histogram name="IncompatibleApplicationsPage.NumApplications"
+    units="applications">
+  <owner>pmonette@chromium.org</owner>
+  <summary>
+    The number of incompatible applications detected by Chrome at the time the
+    chrome://settings/incompatibleApplications page was opened.
+  </summary>
+</histogram>
+
 <histogram name="InertialSensor.AccelerometerAndroidAvailable"
     enum="BooleanAvailable">
   <owner>timvolodine@chromium.org</owner>