Commit 3938e6ad authored by Christopher Grant's avatar Christopher Grant Committed by Commit Bot

Android: Remove 64-bit targets from 32-bit build config

The targets adjusted here should never have existed on 32-bit build
configurations.

Additionally, be more explicit about the various configurations in
64-bit targets.  Currently, the extra arguments may not be used, but in
follow-on changes, they will be.

Bug: 1027573
Change-Id: I42efc07618a7bfa64a04dd8d1b6c5ccc79076ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934837Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarChangwan Ryu <changwan@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719251}
parent 1c8ae5cc
...@@ -822,19 +822,21 @@ if (public_android_sdk) { ...@@ -822,19 +822,21 @@ if (public_android_sdk) {
} }
} }
system_webview_apk_tmpl("trichrome_webview_64_32_apk") { if (android_64bit_target_cpu) {
android_manifest = trichrome_webview_64_32_android_manifest system_webview_apk_tmpl("trichrome_webview_64_32_apk") {
android_manifest_dep = android_manifest = trichrome_webview_64_32_android_manifest
"//android_webview/nonembedded:trichrome_webview_64_32_manifest" android_manifest_dep =
is_64_bit_browser = true "//android_webview/nonembedded:trichrome_webview_64_32_manifest"
min_sdk_version = 29 is_64_bit_browser = true
min_sdk_version = 29
deps = upstream_only_webview_deps
apk_name = "TrichromeWebView6432" deps = upstream_only_webview_deps
use_trichrome_library = true apk_name = "TrichromeWebView6432"
uncompress_dex = true use_trichrome_library = true
if (trichrome_synchronized_proguard) { uncompress_dex = true
static_library_provider = "//chrome/android:trichrome_library_apk" if (trichrome_synchronized_proguard) {
static_library_provider = "//chrome/android:trichrome_library_apk"
}
} }
} }
} }
...@@ -1806,25 +1806,28 @@ if (public_android_sdk) { ...@@ -1806,25 +1806,28 @@ if (public_android_sdk) {
} }
} }
trichrome_library_apk_tmpl("trichrome_library_64_32_apk") { if (android_64bit_target_cpu) {
apk_name = "TrichromeLibrary6432" trichrome_library_apk_tmpl("trichrome_library_64_32_apk") {
android_manifest = trichrome_library_64_32_android_manifest apk_name = "TrichromeLibrary6432"
android_manifest_dep = ":trichrome_library_64_32_android_manifest" android_manifest = trichrome_library_64_32_android_manifest
is_64_bit_browser = true android_manifest_dep = ":trichrome_library_64_32_android_manifest"
is_64_bit_browser = true
if (trichrome_synchronized_proguard) { if (trichrome_synchronized_proguard) {
shared_resources_whitelist_target = "//android_webview:system_webview_apk" shared_resources_whitelist_target =
shared_resources_whitelist_locales = locales "//android_webview:system_webview_apk"
static_library_dependent_targets = [ shared_resources_whitelist_locales = locales
{ static_library_dependent_targets = [
name = "//android_webview:trichrome_webview_64_32_apk" {
is_resource_ids_provider = true name = "//android_webview:trichrome_webview_64_32_apk"
}, is_resource_ids_provider = true
{ },
name = ":trichrome_chrome_64_32_bundle" {
is_resource_ids_provider = false name = ":trichrome_chrome_64_32_bundle"
}, is_resource_ids_provider = false
] },
]
}
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment