Commit 3956f726 authored by satorux@chromium.org's avatar satorux@chromium.org

gdata: Remove a DCHECK that does not make sense.

This was introduced in crrev.com/134770

- DCHECK(entry || error != base::PLATFORM_FILE_OK);
+ DCHECK(error != base::PLATFORM_FILE_OK);

The latter does not make sense, as we are mostly expecting
error to be base::PLATFORM_FILE_OK. Besides, the read directory
operation can fail for various reasons.

BUG=chromium-os:30251
TEST=the DCHECK failure is gone with --enable-dcheck

Review URL: https://chromiumcodereview.appspot.com/10279002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134784 0039d316-1c4b-4281-b951-d872f2087c98
parent bd143b64
...@@ -248,8 +248,6 @@ void GDataFileSystemProxy::OnReadDirectory( ...@@ -248,8 +248,6 @@ void GDataFileSystemProxy::OnReadDirectory(
callback, callback,
base::PlatformFileError error, base::PlatformFileError error,
scoped_ptr<gdata::GDataDirectoryProto> directory_proto) { scoped_ptr<gdata::GDataDirectoryProto> directory_proto) {
DCHECK(error != base::PLATFORM_FILE_OK);
if (error != base::PLATFORM_FILE_OK) { if (error != base::PLATFORM_FILE_OK) {
callback.Run(error, std::vector<base::FileUtilProxy::Entry>(), false); callback.Run(error, std::vector<base::FileUtilProxy::Entry>(), false);
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment