Fixed remaining CL comments from review of http://codereview.chromium.org/9561009/

BUG=chromium-os:26961
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9580016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124742 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/chromeos/gdata/gdata_file_system.cc

@@ -472,6 +472,10 @@ void GDataFileSystem::CreateDirectoryInternal(
       // this function.
       break;
     }
+    default: {
+      NOTREACHED();
+      break;
+    }
   }
 
   // Do we have a parent directory here as well? We can't then create target
@@ -588,10 +592,11 @@ void GDataFileSystem::OnCreateDirectoryCompleted(
   // Not done yet with recursive directory creation?
   if (params.target_directory_path != params.created_directory_path &&
       params.is_recursive) {
-    CreateDirectory(params.target_directory_path,
-                    params.is_exclusive,
-                    params.is_recursive,
-                    params.callback);
+    CreateDirectoryInternal(params.target_directory_path,
+                            params.is_exclusive,
+                            params.is_recursive,
+                            params.callback,
+                            params.proxy);
     return;
   }
 
@@ -755,7 +760,6 @@ base::PlatformFileError GDataFileSystem::UpdateDirectoryWithDocumentFeed(
   return base::PLATFORM_FILE_OK;
 }
 
-
 base::PlatformFileError GDataFileSystem::AddNewDirectory(
     const FilePath& directory_path, base::Value* entry_value) {
   if (!entry_value)
@@ -779,6 +783,9 @@ base::PlatformFileError GDataFileSystem::AddNewDirectory(
   if (!file)
     return base::PLATFORM_FILE_ERROR_FAILED;
 
+  // Check if parent is a directory since in theory since this is a callback
+  // something could in the meantime have nuked the parent dir and created a
+  // file with the exact same name.
   GDataDirectory* parent_dir = file->AsGDataDirectory();
   if (!parent_dir)
     return base::PLATFORM_FILE_ERROR_FAILED;

chrome/browser/chromeos/gdata/gdata_file_system.h

@@ -305,7 +305,7 @@ class GDataFileSystem : public ProfileKeyedService {
     FOUND_INVALID,
     // Found missing directory segment while searching for given directory.
     FOUND_MISSING,
-    // Found target directory, it's already exists.
+    // Found target directory, it already exists.
     DIRECTORY_ALREADY_PRESENT,
   };
 

chrome/browser/chromeos/gdata/gdata_file_system_proxy.cc

@@ -50,10 +50,7 @@ class FindFileDelegateReplyBase : public FindFileDelegate {
       : file_system_(file_system),
         search_file_path_(search_file_path),
         require_content_(require_content) {
-    BrowserThread::ID thread_id;
-    CHECK(BrowserThread::GetCurrentThreadIdentifier(&thread_id));
-    replay_message_proxy_ =
-        BrowserThread::GetMessageLoopProxyForThread(thread_id);
+    reply_message_proxy_ = MessageLoopProxy::current();
   }
 
   virtual ~FindFileDelegateReplyBase() {}
@@ -98,7 +95,7 @@ class FindFileDelegateReplyBase : public FindFileDelegate {
   FilePath search_file_path_;
   // True if the final directory content is required.
   bool require_content_;
-  scoped_refptr<MessageLoopProxy> replay_message_proxy_;
+  scoped_refptr<MessageLoopProxy> reply_message_proxy_;
 };
 
 // GetFileInfoDelegate is used to handle results of proxy's content search
@@ -138,7 +135,7 @@ class GetFileInfoDelegate : public FindFileDelegateReplyBase {
              const base::PlatformFileInfo& file_info,
              const FilePath& platform_path) {
     if (!callback_.is_null()) {
-      replay_message_proxy_->PostTask(FROM_HERE,
+      reply_message_proxy_->PostTask(FROM_HERE,
           Bind(&GetFileInfoDelegate::ReplyOnCallingThread,
                this,
                result,
@@ -218,7 +215,7 @@ class ReadDirectoryDelegate : public FindFileDelegateReplyBase {
              const std::vector<base::FileUtilProxy::Entry>& file_list,
              bool has_more) {
     if (!callback_.is_null()) {
-      replay_message_proxy_->PostTask(FROM_HERE,
+      reply_message_proxy_->PostTask(FROM_HERE,
           Bind(&ReadDirectoryDelegate::ReplyOnCallingThread,
                this,
                result,