Commit 39970759 authored by Rakina Zata Amni's avatar Rakina Zata Amni Committed by Commit Bot

Disable bfcache on ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation

ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation
expects us to re-load a page after a back navigation (and reuse the network
isolation key while doing so), which doesn't happen when the page is
restored from bfcache. We will disable bfcache for this test, because
the reload is an essential part of the test.

Bug: 1017597
Change-Id: I92a42ab8811750c54400119f276d2a9ec3dec13e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886531Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711459}
parent 57468121
...@@ -15,6 +15,7 @@ ...@@ -15,6 +15,7 @@
#include "chrome/common/url_constants.h" #include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h" #include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/back_forward_cache.h"
#include "content/public/browser/navigation_entry.h" #include "content/public/browser/navigation_entry.h"
#include "content/public/browser/notification_service.h" #include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h" #include "content/public/browser/notification_types.h"
...@@ -563,6 +564,13 @@ IN_PROC_BROWSER_TEST_P(ViewSourceWithSplitCacheEnabledTest, ...@@ -563,6 +564,13 @@ IN_PROC_BROWSER_TEST_P(ViewSourceWithSplitCacheEnabledTest,
content::WebContents* view_source_contents = content::WebContents* view_source_contents =
view_source_contents_observer.GetWebContents(); view_source_contents_observer.GetWebContents();
EXPECT_TRUE(WaitForLoadStop(view_source_contents)); EXPECT_TRUE(WaitForLoadStop(view_source_contents));
// This test expects us to re-load a page after a back navigation (and reuse
// the network isolation key while doing so), which won't happen when the
// page is restored from the back forward cache. We are disabling caching for
// |view_source_contents| to make sure it will not be put into the back
// forward cache.
view_source_contents->GetController().GetBackForwardCache().DisableForTesting(
content::BackForwardCache::TEST_ASSUMES_NO_CACHING);
// 4. Navigate the view-source page to a c.com/title1.html // 4. Navigate the view-source page to a c.com/title1.html
ui_test_utils::NavigateToURL( ui_test_utils::NavigateToURL(
......
...@@ -21,6 +21,3 @@ ...@@ -21,6 +21,3 @@
# https://crbug.com/1017594 # https://crbug.com/1017594
-IsolatedAppTest.CrossProcessClientRedirect -IsolatedAppTest.CrossProcessClientRedirect
# https://crbug.com/1017597
-ViewSourceWithSplitCacheEnabledTest.NetworkIsolationKeyReusedForBackNavigation/0
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment