Commit 39b6931a authored by robertocn's avatar robertocn Committed by Commit bot

Simplifying repro instructions from bisect output for non telemetry cases.

- Removed redundant output of the test command.
- Reduced the number of steps to three and wrote them as succintly as
  possible.
- Added the clarifying notes separately at the end.
BUG=404088

Review URL: https://codereview.chromium.org/596963002

Cr-Commit-Position: refs/heads/master@{#296483}
parent fe87d97a
...@@ -212,25 +212,24 @@ Date : %(cl_date)s""" ...@@ -212,25 +212,24 @@ Date : %(cl_date)s"""
REPRO_STEPS_LOCAL = """ REPRO_STEPS_LOCAL = """
==== INSTRUCTIONS TO REPRODUCE ==== ==== INSTRUCTIONS TO REPRODUCE ====
To run locally: To run locally:
$%(command)s""" - Use the test command given under 'BISECT JOB RESULTS' above.
- Consider using a profiler. Pass --profiler=list to list available profilers.
"""
REPRO_STEPS_TRYJOB = """ REPRO_STEPS_TRYJOB = """
To reproduce on a performance try bot: To reproduce on a performance try bot:
1. Create new git branch or check out existing branch. 1. Edit run-perf-test.cfg
2. Edit tools/run-perf-test.cfg (instructions in file) or \ 2. Upload your patch with: $ git cl upload --bypass-hooks
third_party/WebKit/Tools/run-perf-test.cfg. 3. Send to the try server: $ git cl try -m tryserver.chromium.perf -b <bot>
a) Take care to strip any src/ directories from the head of \
relative path names. Notes:
b) On desktop, only --browser=release is supported, on android \ a) Follow the in-file instructions in run-perf-test.cfg.
--browser=android-chromium-testshell. b) run-perf-test.cfg is under tools/ or under third_party/WebKit/Tools.
c) Test command to use: %(command)s c) Do your edits preferably under a new git branch.
3. Upload your patch. --bypass-hooks is necessary to upload the changes you \ d) --browser=release and --browser=android-chromium-testshell are supported
committed locally to run-perf-test.cfg. depending on the platform (desktop|android).
Note: *DO NOT* commit run-perf-test.cfg changes to the project repository. e) Strip any src/ directories from the head of relative path names.
$ git cl upload --bypass-hooks f) Make sure to use the appropriate bot on step 3.
4. Send your try job to the try server. \
[Please make sure to use appropriate bot to reproduce]
$ git cl try -m tryserver.chromium.perf -b <bot>
For more details please visit For more details please visit
https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots""" https://sites.google.com/a/chromium.org/dev/developers/performance-try-bots"""
...@@ -250,16 +249,16 @@ Visit http://www.chromium.org/developers/core-principles for Chrome's policy ...@@ -250,16 +249,16 @@ Visit http://www.chromium.org/developers/core-principles for Chrome's policy
on perf regressions. on perf regressions.
Contact chrome-perf-dashboard-team with any questions or suggestions about Contact chrome-perf-dashboard-team with any questions or suggestions about
bisecting. bisecting.
. .------. . .-----.
. .---. \ \==) . .---. \ \==)
. |PERF\ \ \\ . |PERF\ \ \\
. | ---------'-------'-----------. . | ---------'-------'-----------.
. . 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 `-. . . 0 0 0 0 0 0 0 0 0 0 0 0 0 0 |_`-.
. \______________.-------._______________) . \_____________.-------._______________)
. / / . / /
. / / . / /
. / /==) . / /==)
. ._______.""" . ._____."""
def _AddAdditionalDepotInfo(depot_info): def _AddAdditionalDepotInfo(depot_info):
...@@ -2210,7 +2209,7 @@ class BisectPerformanceMetrics(object): ...@@ -2210,7 +2209,7 @@ class BisectPerformanceMetrics(object):
if self.source_control.IsGit() and self.opts.target_platform == 'chromium': if self.source_control.IsGit() and self.opts.target_platform == 'chromium':
changes_to_deps = self.source_control.QueryFileRevisionHistory( changes_to_deps = self.source_control.QueryFileRevisionHistory(
FILE_DEPS, good_revision, bad_revision) bisect_utils.FILE_DEPS, good_revision, bad_revision)
if changes_to_deps: if changes_to_deps:
# DEPS file was changed, search from the oldest change to DEPS file to # DEPS file was changed, search from the oldest change to DEPS file to
...@@ -2754,14 +2753,14 @@ class BisectPerformanceMetrics(object): ...@@ -2754,14 +2753,14 @@ class BisectPerformanceMetrics(object):
if bisect_utils.IsTelemetryCommand(self.opts.command): if bisect_utils.IsTelemetryCommand(self.opts.command):
command += ('\nAlso consider passing --profiler=list to see available ' command += ('\nAlso consider passing --profiler=list to see available '
'profilers.') 'profilers.')
print REPRO_STEPS_LOCAL % {'command': command} print REPRO_STEPS_LOCAL
if bisect_utils.IsTelemetryCommand(self.opts.command): if bisect_utils.IsTelemetryCommand(self.opts.command):
telemetry_command = re.sub(r'--browser=[^\s]+', telemetry_command = re.sub(r'--browser=[^\s]+',
'--browser=<bot-name>', '--browser=<bot-name>',
command) command)
print REPRO_STEPS_TRYJOB_TELEMETRY % {'command': telemetry_command} print REPRO_STEPS_TRYJOB_TELEMETRY % {'command': telemetry_command}
else: else:
print REPRO_STEPS_TRYJOB % {'command': command} print REPRO_STEPS_TRYJOB
def _PrintOtherRegressions(self, other_regressions, revision_data): def _PrintOtherRegressions(self, other_regressions, revision_data):
"""Prints a section of the results about other potential regressions.""" """Prints a section of the results about other potential regressions."""
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment