[Passwords] No result view fix in password check

This CL changes the way visibility of 'No result view' is calculated.
The label will be shown only if:
- user had successful check with 0 compromised passwords found
- user is signed in
- breach detection is turned on in settings

Bug: 1061496
Change-Id: I9f1e4b5f7aef51749b970964c2b701ee2193ba53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108501
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751674}

chrome/browser/resources/settings/autofill_page/BUILD.gn

@@ -99,6 +99,7 @@ js_library("password_check") {
   deps = [
     ":password_manager_proxy",
     "..:plural_string_proxy",
+    "../prefs:prefs_behavior",
     "//ui/webui/resources/js:i18n_behavior",
   ]
 }
@@ -291,6 +292,7 @@ js_library("password_check.m") {
   deps = [
     ":password_manager_proxy.m",
     "..:plural_string_proxy.m",
+    "../prefs:prefs_behavior.m",
     "//third_party/polymer/v3_0/components-chromium/polymer:polymer_bundled",
     "//ui/webui/resources/js:i18n_behavior.m",
   ]
@@ -523,12 +525,12 @@ polymer_modulizer("password_check") {
   js_file = "password_check.js"
   html_file = "password_check.html"
   html_type = "dom-module"
-  auto_imports = [
-    "chrome/browser/resources/settings/autofill_page/password_manager_proxy.html|PasswordManagerImpl,PasswordManagerProxy",
-    "chrome/browser/resources/settings/people_page/sync_browser_proxy.html|SyncBrowserProxyImpl,SyncPrefs,SyncStatus",
-    "chrome/browser/resources/settings/plural_string_proxy.html|PluralStringProxyImpl",
-    "ui/webui/resources/html/assert.html|assert",
-  ]
+  auto_imports = settings_auto_imports + [
+                   "chrome/browser/resources/settings/autofill_page/password_manager_proxy.html|PasswordManagerImpl,PasswordManagerProxy",
+                   "chrome/browser/resources/settings/people_page/sync_browser_proxy.html|SyncBrowserProxyImpl,SyncPrefs,SyncStatus",
+                   "chrome/browser/resources/settings/plural_string_proxy.html|PluralStringProxyImpl",
+                   "ui/webui/resources/html/assert.html|assert",
+                 ]
   namespace_rewrites = settings_namespace_rewrites
 }
 

chrome/browser/resources/settings/autofill_page/autofill_page.html

@@ -56,7 +56,7 @@
             associated-control="[[$$('#passwordManagerButton')]]"
             page-title="$i18n{checkPasswords}"
             learn-more-url="$i18n{passwordCheckLearnMoreURL}">
-          <settings-password-check></settings-password-check>
+          <settings-password-check prefs="{{prefs}}"></settings-password-check>
         </settings-subpage>
       </template>
       <template is="dom-if" route-path="/payments">

chrome/browser/resources/settings/autofill_page/password_check.html

@@ -14,6 +14,8 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spinner-lite.html">
 <link rel="import" href="chrome://resources/html/cr/ui/focus_without_ink.html">
+<link rel="import" href="../prefs/prefs.html">
+<link rel="import" href="../prefs/prefs_behavior.html">
 <link rel="import" href="password_check_edit_dialog.html">
 <link rel="import" href="password_check_list_item.html">
 <link rel="import" href="password_manager_proxy.html">
@@ -106,7 +108,7 @@
       </cr-button>
     </div>
     <div id="noCompromisedCredentials"
-        hidden$="[[hasLeakedCredentials_(leakedPasswords)]]">
+        hidden$="[[!showNoCompromisedPasswordsLabel_]]">
       <div class="settings-box secondary">
         $i18n{noCompromisedCredentials}
       </div>

chrome/browser/resources/settings/autofill_page/password_check.js

@@ -11,6 +11,7 @@ Polymer({
 
   behaviors: [
     I18nBehavior,
+    PrefsBehavior,
     WebUIListenerBehavior,
   ],
 
@@ -79,6 +80,13 @@ Polymer({
      * @private {?PasswordManagerProxy.CompromisedCredential}
      */
     activePassword_: Object,
+
+    /** @private */
+    showNoCompromisedPasswordsLabel_: {
+      type: Boolean,
+      computed:
+          'computeShowNoCompromisedPasswordsLabel(syncStatus_, prefs.*, status_, leakedPasswords)',
+    }
   },
 
   /**
@@ -524,5 +532,26 @@ Polymer({
     this.leakedPasswords = resultList.concat(addedResults);
   },
 
+  /**
+   * @return {boolean}
+   * @private
+   */
+  computeShowNoCompromisedPasswordsLabel() {
+    // Check if user isn't signed in.
+    if (!this.syncStatus_ || !this.syncStatus_.signedIn) {
+      return false;
+    }
+
+    // Check if breach detection is turned off in settings.
+    if (!this.prefs ||
+        !this.getPref('profile.password_manager_leak_detection').value) {
+      return false;
+    }
+
+    // Return true if there was a successful check and no compromised passwords
+    // were found.
+    return !this.hasLeakedCredentials_(this.leakedPasswords) &&
+        this.showsTimestamp_(this.status_);
+  },
 });
 })();

chrome/test/data/webui/settings/password_check_test.js

@@ -310,13 +310,33 @@ cr.define('settings_passwords_check', function() {
     });
 
     // Test verifies that if no compromised credentials found than list is not
-    // shown TODO(https://crbug.com/1047726): add additional checks after
-    // UI is implemented
+    // shown
     test('testNoCompromisedCredentials', function() {
-      const checkPasswordSection = createCheckPasswordSection();
-      assertTrue(checkPasswordSection.$.passwordCheckBody.hidden);
-      assertFalse(checkPasswordSection.$.noCompromisedCredentials.hidden);
-      validateLeakedPasswordsList(checkPasswordSection, []);
+      const data = passwordManager.data;
+      data.checkStatus = autofill_test_util.makePasswordCheckStatus(
+          /*state=*/ PasswordCheckState.IDLE,
+          /*checked=*/ 4,
+          /*remaining=*/ 0,
+          /*lastCheck=*/ 'Just now');
+      data.leakedCredentials = [];
+
+      const section = createCheckPasswordSection();
+      assertFalse(isElementVisible(section.$.noCompromisedCredentials));
+      cr.webUIListenerCallback(
+          'sync-prefs-changed', sync_test_util.getSyncAllPrefs());
+      sync_test_util.simulateSyncStatus({signedIn: true});
+
+      // Initialize with dummy data breach detection settings
+      section.prefs = {
+        profile: {password_manager_leak_detection: {value: true}}
+      };
+
+      return passwordManager.whenCalled('getCompromisedCredentials')
+          .then(() => {
+            Polymer.dom.flush();
+            assertFalse(isElementVisible(section.$.passwordCheckBody));
+            assertTrue(isElementVisible(section.$.noCompromisedCredentials));
+          });
     });
 
     // Test verifies that compromised credentials are displayed in a proper way