Mark MockRead and MockWrite SocketData args const

StaticSocketDataProvider and SequencedSocketData do not modify the
MockRead and MockWrite arrays that they are passed. Mark them const.

Change-Id: I0eea9dce572e2fd1c9c8cf8e2f08cdfb14b4fc1c
Reviewed-on: https://chromium-review.googlesource.com/917886Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537591}

net/socket/socket_test_util.cc

@@ -174,17 +174,16 @@ SocketDataProvider::~SocketDataProvider() {
     socket_->OnDataProviderDestroyed();
 }
 
-StaticSocketDataHelper::StaticSocketDataHelper(MockRead* reads,
+StaticSocketDataHelper::StaticSocketDataHelper(const MockRead* reads,
                                                size_t reads_count,
-                                               MockWrite* writes,
+                                               const MockWrite* writes,
                                                size_t writes_count)
     : reads_(reads),
       read_index_(0),
       read_count_(reads_count),
       writes_(writes),
       write_index_(0),
-      write_count_(writes_count) {
-}
+      write_count_(writes_count) {}
 
 StaticSocketDataHelper::~StaticSocketDataHelper() = default;
 
@@ -250,12 +249,11 @@ StaticSocketDataProvider::StaticSocketDataProvider()
     : StaticSocketDataProvider(nullptr, 0, nullptr, 0) {
 }
 
-StaticSocketDataProvider::StaticSocketDataProvider(MockRead* reads,
+StaticSocketDataProvider::StaticSocketDataProvider(const MockRead* reads,
                                                    size_t reads_count,
-                                                   MockWrite* writes,
+                                                   const MockWrite* writes,
                                                    size_t writes_count)
-    : helper_(reads, reads_count, writes, writes_count) {
-}
+    : helper_(reads, reads_count, writes, writes_count) {}
 
 StaticSocketDataProvider::~StaticSocketDataProvider() = default;
 
@@ -317,9 +315,9 @@ SSLSocketDataProvider::SSLSocketDataProvider(
 
 SSLSocketDataProvider::~SSLSocketDataProvider() = default;
 
-SequencedSocketData::SequencedSocketData(MockRead* reads,
+SequencedSocketData::SequencedSocketData(const MockRead* reads,
                                          size_t reads_count,
-                                         MockWrite* writes,
+                                         const MockWrite* writes,
                                          size_t writes_count)
     : helper_(reads, reads_count, writes, writes_count),
       sequence_number_(0),
@@ -395,9 +393,9 @@ SequencedSocketData::SequencedSocketData(MockRead* reads,
 }
 
 SequencedSocketData::SequencedSocketData(const MockConnect& connect,
-                                         MockRead* reads,
+                                         const MockRead* reads,
                                          size_t reads_count,
-                                         MockWrite* writes,
+                                         const MockWrite* writes,
                                          size_t writes_count)
     : SequencedSocketData(reads, reads_count, writes, writes_count) {
   set_connect_data(connect);

net/socket/socket_test_util.h

@@ -276,9 +276,9 @@ class AsyncSocket {
 // StaticSocketDataHelper manages a list of reads and writes.
 class StaticSocketDataHelper {
  public:
-  StaticSocketDataHelper(MockRead* reads,
+  StaticSocketDataHelper(const MockRead* reads,
                          size_t reads_count,
-                         MockWrite* writes,
+                         const MockWrite* writes,
                          size_t writes_count);
   ~StaticSocketDataHelper();
 
@@ -312,12 +312,12 @@ class StaticSocketDataHelper {
   // fails if no data is available.
   const MockWrite& PeekRealWrite() const;
 
-  MockRead* reads_;
+  const MockRead* const reads_;
   size_t read_index_;
-  size_t read_count_;
-  MockWrite* writes_;
+  const size_t read_count_;
+  const MockWrite* const writes_;
   size_t write_index_;
-  size_t write_count_;
+  const size_t write_count_;
 
   DISALLOW_COPY_AND_ASSIGN(StaticSocketDataHelper);
 };
@@ -327,9 +327,9 @@ class StaticSocketDataHelper {
 class StaticSocketDataProvider : public SocketDataProvider {
  public:
   StaticSocketDataProvider();
-  StaticSocketDataProvider(MockRead* reads,
+  StaticSocketDataProvider(const MockRead* reads,
                            size_t reads_count,
-                           MockWrite* writes,
+                           const MockWrite* writes,
                            size_t writes_count);
   ~StaticSocketDataProvider() override;
 
@@ -382,18 +382,18 @@ class SequencedSocketData : public SocketDataProvider {
  public:
   // |reads| is the list of MockRead completions.
   // |writes| is the list of MockWrite completions.
-  SequencedSocketData(MockRead* reads,
+  SequencedSocketData(const MockRead* reads,
                       size_t reads_count,
-                      MockWrite* writes,
+                      const MockWrite* writes,
                       size_t writes_count);
 
   // |connect| is the result for the connect phase.
   // |reads| is the list of MockRead completions.
   // |writes| is the list of MockWrite completions.
   SequencedSocketData(const MockConnect& connect,
-                      MockRead* reads,
+                      const MockRead* reads,
                       size_t reads_count,
-                      MockWrite* writes,
+                      const MockWrite* writes,
                       size_t writes_count);
 
   ~SequencedSocketData() override;