Revert "Only CHECK for RenderProcessHosts that outlive an incognito profile in release"

The original patch moved a CHECK behind an #ifdef NDEBUG in an attempt
to ease debugging. According to crbug.com/496653#c73, it was supposed to
be reverted, but that never happened. We shouldn't keep shipping a CHECK
to users that's disabled in Debug builds, so this revert drops the ifdef
again to turn on the CHECK everywhere.

Original review: https://codereview.chromium.org/1591543002

Bug: chromium:496653, chromium:1040839
Change-Id: I71a743b6355a0072ed5ae5281f79a2d948da9adb
R: mfoltz@chromium.org, avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022791
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735455}

chrome/browser/profiles/profile_destroyer.cc

@@ -161,13 +161,11 @@ ProfileDestroyer::ProfileDestroyer(Profile* const profile, HostSet* hosts)
 }
 
 ProfileDestroyer::~ProfileDestroyer() {
-#ifdef NDEBUG
   // Don't wait for pending registrations, if any, these hosts are buggy.
   // Note: this can happen, but if so, it's better to crash here than wait
   // for the host to dereference a deleted Profile. http://crbug.com/248625
   CHECK_EQ(0U, num_hosts_) << "Some render process hosts were not "
                            << "destroyed early enough!";
-#endif  // NDEBUG
   DCHECK(pending_destroyers_ != NULL);
   auto iter = pending_destroyers_->find(this);
   DCHECK(iter != pending_destroyers_->end());