Commit 39f23aea authored by benwells's avatar benwells Committed by Commit bot

Centralize command line checks for kEnableStreamlinedHostedApps.

This moves all checks in the browser process into a common function.

BUG=368372

Review URL: https://codereview.chromium.org/489313002

Cr-Commit-Position: refs/heads/master@{#292118}
parent a2c9ec97
......@@ -22,6 +22,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_ui_util.h"
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/extensions/window_controller.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
......@@ -32,7 +33,6 @@
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/api/management.h"
#include "chrome/common/extensions/chrome_utility_extensions_messages.h"
#include "chrome/common/extensions/extension_constants.h"
......@@ -106,8 +106,7 @@ std::vector<management::LaunchType> GetAvailableLaunchTypes(
launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_WINDOW);
#endif
if (!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (!util::IsStreamlinedHostedAppsEnabled()) {
launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_AS_PINNED_TAB);
launch_type_list.push_back(management::LAUNCH_TYPE_OPEN_FULL_SCREEN);
}
......
......@@ -323,5 +323,10 @@ const gfx::ImageSkia& GetDefaultExtensionIcon() {
IDR_EXTENSION_DEFAULT_ICON);
}
bool IsStreamlinedHostedAppsEnabled() {
return CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps);
}
} // namespace util
} // namespace extensions
......@@ -123,6 +123,9 @@ bool SiteHasIsolatedStorage(const GURL& extension_site_url,
const gfx::ImageSkia& GetDefaultExtensionIcon();
const gfx::ImageSkia& GetDefaultAppIcon();
// Returns true if the experimental streamlined hosted apps feature is enabled.
bool IsStreamlinedHostedAppsEnabled();
} // namespace util
} // namespace extensions
......
......@@ -4,13 +4,12 @@
#include "chrome/browser/extensions/launch_util.h"
#include "base/command_line.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_sync_service.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
#include "components/pref_registry/pref_registry_syncable.h"
......@@ -48,8 +47,7 @@ LaunchType GetLaunchType(const ExtensionPrefs* prefs,
LaunchType result = LAUNCH_TYPE_DEFAULT;
// Launch hosted apps as windows by default for streamlined hosted apps.
if (CommandLine::ForCurrentProcess()->
HasSwitch(switches::kEnableStreamlinedHostedApps) &&
if (util::IsStreamlinedHostedAppsEnabled() &&
extension->id() != extension_misc::kChromeAppId) {
result = LAUNCH_TYPE_WINDOW;
}
......
......@@ -4,7 +4,6 @@
#include "chrome/browser/extensions/tab_helper.h"
#include "base/command_line.h"
#include "base/logging.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
......@@ -18,6 +17,7 @@
#include "chrome/browser/extensions/bookmark_app_helper.h"
#include "chrome/browser/extensions/error_console/error_console.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/location_bar_controller.h"
#include "chrome/browser/extensions/webstore_inline_installer.h"
#include "chrome/browser/extensions/webstore_inline_installer_factory.h"
......@@ -30,7 +30,6 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/chrome_extension_messages.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
......@@ -228,8 +227,7 @@ void TabHelper::DidNavigateMainFrame(
ExtensionRegistry* registry = ExtensionRegistry::Get(context);
const ExtensionSet& enabled_extensions = registry->enabled_extensions();
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (util::IsStreamlinedHostedAppsEnabled()) {
Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
if (browser && browser->is_app()) {
SetExtensionApp(registry->GetExtensionById(
......
......@@ -5,14 +5,13 @@
#include "chrome/browser/ui/app_list/app_context_menu.h"
#include "base/bind.h"
#include "base/command_line.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/app_list/app_context_menu_delegate.h"
#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
......@@ -118,8 +117,7 @@ ui::MenuModel* AppContextMenu::GetMenuModel() {
if (!is_platform_app_) {
// Streamlined hosted apps can only toggle between USE_LAUNCH_TYPE_WINDOW
// and USE_LAUNCH_TYPE_REGULAR.
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
menu_model_->AddCheckItemWithStringId(
USE_LAUNCH_TYPE_REGULAR,
IDS_APP_CONTEXT_MENU_OPEN_TAB);
......@@ -264,8 +262,7 @@ void AppContextMenu::ExecuteCommand(int command_id, int event_flags) {
command_id - USE_LAUNCH_TYPE_COMMAND_START);
// Streamlined hosted apps can only toggle between LAUNCH_TYPE_WINDOW and
// LAUNCH_TYPE_REGULAR.
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
launch_type = (controller_->GetExtensionLaunchType(profile_, app_id_) ==
extensions::LAUNCH_TYPE_REGULAR) ?
extensions::LAUNCH_TYPE_WINDOW :
......
......@@ -4,7 +4,6 @@
#include "chrome/browser/ui/app_list/extension_app_item.h"
#include "base/command_line.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
......@@ -16,7 +15,6 @@
#include "chrome/browser/ui/extensions/extension_enable_flow.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "content/public/browser/user_metrics.h"
......@@ -148,8 +146,8 @@ ExtensionAppItem::~ExtensionAppItem() {
bool ExtensionAppItem::NeedsOverlay() const {
// The overlay icon is disabled for hosted apps in windowed mode with
// streamlined hosted apps.
bool streamlined_hosted_apps = CommandLine::ForCurrentProcess()->
HasSwitch(switches::kEnableStreamlinedHostedApps);
bool streamlined_hosted_apps =
extensions::util::IsStreamlinedHostedAppsEnabled();
#if defined(OS_CHROMEOS)
if (!streamlined_hosted_apps)
return false;
......
......@@ -9,8 +9,8 @@
#include "base/auto_reset.h"
#include "base/bind.h"
#include "base/callback.h"
#include "base/command_line.h"
#include "chrome/browser/extensions/extension_ui_util.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/install_tracker.h"
#include "chrome/browser/extensions/install_tracker_factory.h"
#include "chrome/browser/profiles/profile.h"
......@@ -18,7 +18,6 @@
#include "chrome/browser/ui/app_list/app_list_syncable_service.h"
#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
#include "chrome/browser/ui/app_list/extension_app_item.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
......@@ -81,8 +80,7 @@ void ExtensionAppModelBuilder::InitializePrefChangeRegistrars() {
base::Bind(&ExtensionAppModelBuilder::OnProfilePreferenceChanged,
base::Unretained(this)));
if (!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps))
if (!extensions::util::IsStreamlinedHostedAppsEnabled())
return;
// TODO(calamity): analyze the performance impact of doing this every
......
......@@ -6,14 +6,13 @@
#include <vector>
#include "base/command_line.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
......@@ -54,8 +53,7 @@ const extensions::Extension* GetExtensionForTab(Profile* profile,
// Bookmark app windows should match their launch url extension despite
// their web extents.
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
for (extensions::ExtensionSet::const_iterator it = extensions.begin();
it != extensions.end(); ++it) {
if (it->get()->from_bookmark() &&
......
......@@ -13,15 +13,14 @@
#include "ash/shelf/shelf_widget.h"
#include "ash/shell.h"
#include "base/bind.h"
#include "base/command_line.h"
#include "base/prefs/pref_service.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/fullscreen.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/ash/chrome_shell_delegate.h"
#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/grit/generated_resources.h"
#include "content/public/common/context_menu_params.h"
......@@ -106,8 +105,7 @@ void LauncherContextMenu::Init() {
if (!controller_->IsPlatformApp(item_.id) &&
item_.type != ash::TYPE_WINDOWED_APP) {
AddSeparator(ui::NORMAL_SEPARATOR);
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
// Streamlined hosted apps launch in a window by default. This menu
// item is re-interpreted as a single, toggle-able option to launch
// the hosted app as a tab.
......@@ -313,8 +311,7 @@ void LauncherContextMenu::ExecuteCommand(int command_id, int event_flags) {
extensions::LAUNCH_TYPE_REGULAR;
// Streamlined hosted apps can only toggle between LAUNCH_WINDOW and
// LAUNCH_REGULAR.
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
launch_type = controller_->GetLaunchType(item_.id) ==
extensions::LAUNCH_TYPE_REGULAR
? extensions::LAUNCH_TYPE_WINDOW
......
......@@ -54,6 +54,7 @@
#include "chrome/browser/extensions/api/tabs/tabs_windows_api.h"
#include "chrome/browser/extensions/browser_extension_window_controller.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/file_select_helper.h"
......@@ -577,10 +578,8 @@ base::string16 Browser::GetWindowTitleForCurrentTab() const {
// window during the window's creation (before tabs have been added).
if (contents) {
// Streamlined hosted apps use the host instead of the title.
if (is_app() && CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (is_app() && extensions::util::IsStreamlinedHostedAppsEnabled())
return base::UTF8ToUTF16(contents->GetURL().host());
}
title = contents->GetTitle();
FormatTitleForDisplay(&title);
......@@ -2305,10 +2304,9 @@ bool Browser::ShouldShowLocationBar() const {
return true;
if (is_app()) {
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps) &&
if (extensions::util::IsStreamlinedHostedAppsEnabled() &&
host_desktop_type() != chrome::HOST_DESKTOP_TYPE_ASH) {
// If kEnableStreamlinedHostedApps is true, show the location bar for
// If streamlined hosted apps are enabled, show the location bar for
// bookmark apps, except on ash which has the toolbar merged into the
// frame.
ExtensionService* service =
......
......@@ -11,6 +11,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/lifetime/application_lifetime.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile.h"
......@@ -979,8 +980,7 @@ void BrowserCommandController::InitCommandState() {
// Navigation commands
command_updater_.UpdateCommandEnabled(
IDC_HOME,
normal_window || (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps) &&
normal_window || (extensions::util::IsStreamlinedHostedAppsEnabled() &&
browser_->is_app()));
// Window management commands
......
......@@ -33,6 +33,7 @@
#include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/extensions/extension_creator.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/extensions/pack_extension_job.h"
#include "chrome/browser/first_run/first_run.h"
......@@ -201,8 +202,7 @@ bool GetAppLaunchContainer(
extensions::LaunchContainer launch_container = extensions::GetLaunchContainer(
extensions::ExtensionPrefs::Get(profile), extension);
if (!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps) &&
if (!extensions::util::IsStreamlinedHostedAppsEnabled() &&
!extensions::HasPreferredLaunchContainer(
extensions::ExtensionPrefs::Get(profile), extension)) {
launch_container = extensions::LAUNCH_CONTAINER_WINDOW;
......
......@@ -16,6 +16,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/extensions/extension_toolbar_model.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/search/search.h"
......@@ -241,8 +242,7 @@ void ToolsMenuModel::Build(Browser* browser) {
show_create_shortcuts = false;
#endif
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
AddItemWithStringId(IDC_CREATE_HOSTED_APP, IDS_CREATE_HOSTED_APP);
AddSeparator(ui::NORMAL_SEPARATOR);
} else if (show_create_shortcuts) {
......
......@@ -7,16 +7,15 @@
#include <vector>
#include "base/callback_forward.h"
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/i18n/time_formatting.h"
#include "base/logging.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task_runner_util.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/grit/generated_resources.h"
#include "content/public/browser/browser_thread.h"
......@@ -58,8 +57,7 @@ class LaunchOptionsComboboxModel : public ui::ComboboxModel {
};
LaunchOptionsComboboxModel::LaunchOptionsComboboxModel() {
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)) {
if (extensions::util::IsStreamlinedHostedAppsEnabled()) {
// Streamlined hosted apps can only toggle between LAUNCH_TYPE_WINDOW and
// LAUNCH_TYPE_REGULAR.
// TODO(sashab): Use a checkbox for this choice instead of combobox.
......
......@@ -6,15 +6,14 @@
#include <algorithm>
#include "ash/ash_switches.h"
#include "ash/frame/caption_buttons/frame_caption_button.h"
#include "ash/frame/caption_buttons/frame_caption_button_container_view.h"
#include "ash/frame/default_header_painter.h"
#include "ash/frame/frame_border_hit_test_controller.h"
#include "ash/frame/header_painter_util.h"
#include "ash/shell.h"
#include "base/command_line.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/themes/theme_properties.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
......@@ -26,7 +25,6 @@
#include "chrome/browser/ui/views/profiles/avatar_menu_button.h"
#include "chrome/browser/ui/views/tab_icon_view.h"
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/common/chrome_switches.h"
#include "content/public/browser/web_contents.h"
#include "grit/ash_resources.h"
#include "grit/theme_resources.h"
......@@ -498,8 +496,7 @@ bool BrowserNonClientFrameViewAsh::UseWebAppHeaderStyle() const {
// Use of the experimental WebApp header style is guarded with the
// streamlined hosted app style.
return browser_view()->browser()->is_app() &&
CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps);
extensions::util::IsStreamlinedHostedAppsEnabled();
}
void BrowserNonClientFrameViewAsh::LayoutAvatar() {
......
......@@ -19,6 +19,7 @@
#include "chrome/browser/bookmarks/bookmark_stats.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/native_window_notification_source.h"
......@@ -1545,8 +1546,7 @@ bool BrowserView::ShouldShowWindowTitle() const {
if (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH &&
browser_->is_trusted_source() &&
!(browser_->is_app() &&
CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)))
extensions::util::IsStreamlinedHostedAppsEnabled()))
return false;
return browser_->SupportsWindowFeature(Browser::FEATURE_TITLEBAR);
......@@ -1577,8 +1577,7 @@ bool BrowserView::ShouldShowWindowIcon() const {
if (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH &&
browser_->is_trusted_source() &&
!(browser_->is_app() &&
CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps)))
extensions::util::IsStreamlinedHostedAppsEnabled()))
return false;
return browser_->SupportsWindowFeature(Browser::FEATURE_TITLEBAR);
......
......@@ -7,7 +7,6 @@
#include <algorithm>
#include <map>
#include "base/command_line.h"
#include "base/i18n/rtl.h"
#include "base/prefs/pref_service.h"
#include "base/stl_util.h"
......@@ -18,6 +17,7 @@
#include "chrome/browser/defaults.h"
#include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/location_bar_controller.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
......@@ -59,7 +59,6 @@
#include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
#include "chrome/browser/ui/views/translate/translate_bubble_view.h"
#include "chrome/browser/ui/zoom/zoom_controller.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
#include "components/search_engines/template_url.h"
......@@ -302,8 +301,8 @@ void LocationBarView::Init() {
omnibox_view_ = new OmniboxViewViews(
this, profile(), command_updater(),
is_popup_mode_ ||
(browser_->is_app() && CommandLine::ForCurrentProcess()->
HasSwitch(switches::kEnableStreamlinedHostedApps)),
(browser_->is_app() &&
extensions::util::IsStreamlinedHostedAppsEnabled()),
this, font_list);
omnibox_view_->Init();
omnibox_view_->SetFocusable(true);
......
......@@ -16,6 +16,7 @@
#include "chrome/browser/command_updater.h"
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_action_manager.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/ui/browser.h"
......@@ -103,11 +104,6 @@ const int kContentShadowHeightAsh = 2;
// Non-ash uses a rounded content area with no shadow in the assets.
const int kContentShadowHeight = 0;
bool IsStreamlinedHostedAppsEnabled() {
return CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps);
}
#if !defined(OS_CHROMEOS)
bool HasAshShell() {
#if defined(USE_ASH)
......@@ -152,7 +148,7 @@ ToolbarView::ToolbarView(Browser* browser)
display_mode_ = DISPLAYMODE_LOCATION;
if (browser->SupportsWindowFeature(Browser::FEATURE_TABSTRIP) ||
(browser->is_app() && IsStreamlinedHostedAppsEnabled()))
(browser->is_app() && extensions::util::IsStreamlinedHostedAppsEnabled()))
display_mode_ = DISPLAYMODE_NORMAL;
if (OutdatedUpgradeBubbleView::IsAvailable()) {
......@@ -575,7 +571,8 @@ void ToolbarView::Layout() {
next_element_x = reload_->bounds().right();
if (show_home_button_.GetValue() ||
(browser_->is_app() && IsStreamlinedHostedAppsEnabled())) {
(browser_->is_app() &&
extensions::util::IsStreamlinedHostedAppsEnabled())) {
home_->SetVisible(true);
home_->SetBounds(next_element_x, child_y,
home_->GetPreferredSize().width(), child_height);
......
......@@ -17,6 +17,7 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search/search.h"
......@@ -490,8 +491,8 @@ void NTPResourceCache::CreateNewTabHTML() {
load_time_data.SetBoolean("showWebStoreIcon",
!prefs->GetBoolean(prefs::kHideWebStoreIcon));
bool streamlined_hosted_apps = CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableStreamlinedHostedApps);
bool streamlined_hosted_apps =
extensions::util::IsStreamlinedHostedAppsEnabled();
load_time_data.SetBoolean("enableStreamlinedHostedApps",
streamlined_hosted_apps);
// Use a different string for launching as a regular tab for streamlined
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment