Commit 39f98e85 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Re-enable Webview GPU pixel tests on N5X

Re-enables the Android Webview GPU pixel tests on Nexus 5X devices since
the issue that was causing them to fail has been fixed.

TBR=ynovikov@chromium.org

Bug: 987623
Change-Id: Iae0a13488e023ac9969e462970441aa382bbd0c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728042Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#682930}
parent 529aea13
...@@ -4607,6 +4607,52 @@ ...@@ -4607,6 +4607,52 @@
} }
], ],
"isolated_scripts": [ "isolated_scripts": [
{
"args": [
"pixel",
"--show-stdout",
"--browser=android-webview-instrumentation",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc",
"--dont-restore-color-profile-after-test",
"--os-type",
"android",
"--build-revision",
"${got_revision}",
"--test-machine-name",
"${buildername}"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
"args": [],
"script": "//testing/merge_scripts/standard_isolated_script_merge.py"
},
"name": "android_webview_pixel_skia_gold_test",
"precommit_args": [
"--review-patch-issue",
"${patch_issue}",
"--review-patch-set",
"${patch_set}",
"--buildbucket-build-id",
"${buildbucket_build_id}"
],
"should_retry_with_patch": false,
"swarming": {
"can_use_on_swarming_builders": true,
"containment_type": "AUTO",
"dimension_sets": [
{
"device_os": "MMB29Q",
"device_os_type": "userdebug",
"device_type": "bullhead",
"os": "Android"
}
],
"idempotent": false,
"service_account": "chrome-gpu-gold@chops-service-accounts.iam.gserviceaccount.com"
}
},
{ {
"args": [ "args": [
"--gtest-benchmark-name=angle_perftests", "--gtest-benchmark-name=angle_perftests",
...@@ -154,37 +154,35 @@ ...@@ -154,37 +154,35 @@
}, },
}, },
# Temporarily disabled due to timeouts causing invalid test results. 'android_webview_gpu_telemetry_tests': {
# TODO(jmadill): Re-enable once timeout is resolved. http://crbug.com/987623 'pixel_skia': {
# 'android_webview_gpu_telemetry_tests': { 'name': 'android_webview_pixel_skia_gold_test',
# 'pixel_skia': { 'args': [
# 'name': 'android_webview_pixel_skia_gold_test', '--dont-restore-color-profile-after-test',
# 'args': [ '--os-type',
# '--dont-restore-color-profile-after-test', '${os_type}',
# '--os-type', '--build-revision',
# '${os_type}', '${got_revision}',
# '--build-revision', '--test-machine-name',
# '${got_revision}', '${buildername}',
# '--test-machine-name', ],
# '${buildername}', 'precommit_args': [
# ], # Gerrit issue ID
# 'precommit_args': [ '--review-patch-issue',
# # Gerrit issue ID '${patch_issue}',
# '--review-patch-issue', # Patch set number
# '${patch_issue}', '--review-patch-set',
# # Patch set number '${patch_set}',
# '--review-patch-set', # Buildbucket ID
# '${patch_set}', '--buildbucket-build-id',
# # Buildbucket ID '${buildbucket_build_id}',
# '--buildbucket-build-id', ],
# '${buildbucket_build_id}', 'swarming': {
# ], 'service_account': 'chrome-gpu-gold@chops-service-accounts.iam.gserviceaccount.com'
# 'swarming': { },
# 'service_account': 'chrome-gpu-gold@chops-service-accounts.iam.gserviceaccount.com' 'telemetry_test_name': 'pixel',
# }, },
# 'telemetry_test_name': 'pixel', },
# },
# },
'aura_gtests': { 'aura_gtests': {
'aura_unittests': {}, 'aura_unittests': {},
......
...@@ -2434,9 +2434,7 @@ ...@@ -2434,9 +2434,7 @@
'gtest_tests': 'gpu_fyi_android_and_mac_gtests', 'gtest_tests': 'gpu_fyi_android_and_mac_gtests',
'isolated_scripts': 'gpu_angle_and_mobile_representative_perf_fyi_isolated_scripts', 'isolated_scripts': 'gpu_angle_and_mobile_representative_perf_fyi_isolated_scripts',
'gpu_telemetry_tests': 'gpu_nexus5x_telemetry_tests', 'gpu_telemetry_tests': 'gpu_nexus5x_telemetry_tests',
# Temporarily disabled due to timeouts causing invalid test results. 'android_webview_gpu_telemetry_tests': 'android_webview_gpu_telemetry_tests',
# TODO(jmadill): Re-enable once timeout is resolved. http://crbug.com/987623
# 'android_webview_gpu_telemetry_tests': 'android_webview_gpu_telemetry_tests',
}, },
}, },
'Android FYI Release (Nexus 6)': { 'Android FYI Release (Nexus 6)': {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment