Commit 3a1c6d6a authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot

WebUI: updating to iron-list v2.0.19, removing patch

Bug: 870270
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I17c9c1494d2622dbf61398065c0b556a1183075f
Reviewed-on: https://chromium-review.googlesource.com/1171203Reviewed-by: default avatarScott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582274}
parent 52ce86ed
...@@ -44,9 +44,6 @@ the Crisper tool (https://github.com/PolymerLabs/crisper). ...@@ -44,9 +44,6 @@ the Crisper tool (https://github.com/PolymerLabs/crisper).
handler code which was hiding ripples for pointer interactions. handler code which was hiding ripples for pointer interactions.
- Bundled and minified Polymer 2 with minify_polymer.py, since Polymer 2 repo - Bundled and minified Polymer 2 with minify_polymer.py, since Polymer 2 repo
does not distribute minified files (unlike Polymer 1). does not distribute minified files (unlike Polymer 1).
- For iron-list, call event.preventDefault() when up/down arrow is pressed and
the focused item changes. This is to prevent outer vertical scroll from
scrolling when the iron-list vertical scroll has reached the top or bottom.
To restore a content of the 'components-chromium' directory from scratch, run To restore a content of the 'components-chromium' directory from scratch, run
./v1_0/reproduce.sh on a Linux machine. ./v1_0/reproduce.sh on a Linux machine.
......
...@@ -17,7 +17,7 @@ ...@@ -17,7 +17,7 @@
"iron-icon": "PolymerElements/iron-icon#2.0.1", "iron-icon": "PolymerElements/iron-icon#2.0.1",
"iron-iconset-svg": "PolymerElements/iron-iconset-svg#2.1.1", "iron-iconset-svg": "PolymerElements/iron-iconset-svg#2.1.1",
"iron-input": "PolymerElements/iron-input#2.1.3", "iron-input": "PolymerElements/iron-input#2.1.3",
"iron-list": "PolymerElements/iron-list#2.0.18", "iron-list": "PolymerElements/iron-list#2.0.19",
"iron-location": "PolymerElements/iron-location#2.0.3", "iron-location": "PolymerElements/iron-location#2.0.3",
"iron-media-query": "PolymerElements/iron-media-query#2.0.0", "iron-media-query": "PolymerElements/iron-media-query#2.0.0",
"iron-menu-behavior": "PolymerElements/iron-menu-behavior#2.0.1", "iron-menu-behavior": "PolymerElements/iron-menu-behavior#2.0.1",
......
...@@ -180,29 +180,3 @@ index 2e63d3731be1..217c7ff1414c 100644 ...@@ -180,29 +180,3 @@ index 2e63d3731be1..217c7ff1414c 100644
}); });
/** /**
diff --git a/components-chromium/iron-list/iron-list-extracted.js b/components-chromium/iron-list/iron-list-extracted.js
index 4fdfbdead5ae..dbfbc9ca3907 100644
--- a/components-chromium/iron-list/iron-list-extracted.js
+++ b/components-chromium/iron-list/iron-list-extracted.js
@@ -1611,13 +1611,20 @@
_keydownHandler: function(e) {
switch (e.keyCode) {
case /* ARROW_DOWN */ 40:
- e.preventDefault();
+ // TODO (aee): remove when iron-list issue is fixed.
+ // https://github.com/PolymerElements/iron-list/issues/542
+ if (this._focusedVirtualIndex < this._virtualCount - 1)
+ e.preventDefault();
this._focusPhysicalItem(this._focusedVirtualIndex + (this.grid ? this._itemsPerRow : 1));
break;
case /* ARROW_RIGHT */ 39:
if (this.grid) this._focusPhysicalItem(this._focusedVirtualIndex + (this._isRTL ? -1 : 1));
break;
case /* ARROW_UP */ 38:
+ // TODO (aee): remove when iron-list issue is fixed.
+ // https://github.com/PolymerElements/iron-list/issues/542
+ if (this._focusedVirtualIndex > 0)
+ e.preventDefault();
this._focusPhysicalItem(this._focusedVirtualIndex - (this.grid ? this._itemsPerRow : 1));
break;
case /* ARROW_LEFT */ 37:
...@@ -7,7 +7,7 @@ ...@@ -7,7 +7,7 @@
"list", "list",
"virtual-list" "virtual-list"
], ],
"version": "2.0.18", "version": "2.0.19",
"homepage": "https://github.com/PolymerElements/iron-list", "homepage": "https://github.com/PolymerElements/iron-list",
"authors": [ "authors": [
"The Polymer Authors" "The Polymer Authors"
......
...@@ -1611,8 +1611,6 @@ ...@@ -1611,8 +1611,6 @@
_keydownHandler: function(e) { _keydownHandler: function(e) {
switch (e.keyCode) { switch (e.keyCode) {
case /* ARROW_DOWN */ 40: case /* ARROW_DOWN */ 40:
// TODO (aee): remove when iron-list issue is fixed.
// https://github.com/PolymerElements/iron-list/issues/542
if (this._focusedVirtualIndex < this._virtualCount - 1) if (this._focusedVirtualIndex < this._virtualCount - 1)
e.preventDefault(); e.preventDefault();
this._focusPhysicalItem(this._focusedVirtualIndex + (this.grid ? this._itemsPerRow : 1)); this._focusPhysicalItem(this._focusedVirtualIndex + (this.grid ? this._itemsPerRow : 1));
...@@ -1621,8 +1619,6 @@ ...@@ -1621,8 +1619,6 @@
if (this.grid) this._focusPhysicalItem(this._focusedVirtualIndex + (this._isRTL ? -1 : 1)); if (this.grid) this._focusPhysicalItem(this._focusedVirtualIndex + (this._isRTL ? -1 : 1));
break; break;
case /* ARROW_UP */ 38: case /* ARROW_UP */ 38:
// TODO (aee): remove when iron-list issue is fixed.
// https://github.com/PolymerElements/iron-list/issues/542
if (this._focusedVirtualIndex > 0) if (this._focusedVirtualIndex > 0)
e.preventDefault(); e.preventDefault();
this._focusPhysicalItem(this._focusedVirtualIndex - (this.grid ? this._itemsPerRow : 1)); this._focusPhysicalItem(this._focusedVirtualIndex - (this.grid ? this._itemsPerRow : 1));
......
...@@ -90,9 +90,9 @@ Tree link: https://github.com/PolymerElements/iron-input/tree/v2.1.3 ...@@ -90,9 +90,9 @@ Tree link: https://github.com/PolymerElements/iron-input/tree/v2.1.3
Name: iron-list Name: iron-list
Repository: https://github.com/PolymerElements/iron-list.git Repository: https://github.com/PolymerElements/iron-list.git
Tree: v2.0.18 Tree: v2.0.19
Revision: b3daa7050e80c9c94d245f338c084421bb6e89f8 Revision: 613dca4aa54ddf6ecf827e2e92ea6dfc4cd58280
Tree link: https://github.com/PolymerElements/iron-list/tree/v2.0.18 Tree link: https://github.com/PolymerElements/iron-list/tree/v2.0.19
Name: iron-location Name: iron-location
Repository: https://github.com/PolymerElements/iron-location.git Repository: https://github.com/PolymerElements/iron-location.git
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment