Commit 3a20cfc4 authored by Bruce Dawson's avatar Bruce Dawson Committed by Commit Bot

Reenable Win 7 DevToolsReattachAfterCrashTest

DevToolsReattachAfterCrashTest was disabled on Windows 7 because loading
of debug information was too slow and caused timeouts. This was caused
by symbol_level=1 becoming more verbose (including line numbers and
source files) and dbghelp.dll on Windows 7 seems to be particularly
inefficient. This was fixed a while ago by getting the bots to default
to symbol_level=1. This is the first of a few changes to reenable the
tests that were disabled.

Bug: 985255
Change-Id: I0007cc98e7b9b8ce71f10d32a1de74b7daa2ad39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500315Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821253}
parent 4051d1d8
...@@ -1883,16 +1883,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsAutoOpenerTest, TestAutoOpenForTabs) { ...@@ -1883,16 +1883,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsAutoOpenerTest, TestAutoOpenForTabs) {
observer_->CloseAllSync(); observer_->CloseAllSync();
} }
// Flaky timeouts on Win7 Tests (dbg)(1); see https://crbug.com/985255. class DevToolsReattachAfterCrashTest : public DevToolsSanityTest {
// Flaky timeouts and failures on Win7 (32) Tests; see
// https://crbug.com/1025411.
#if defined(OS_WIN)
#define MAYBE_DevToolsReattachAfterCrashTest \
DISABLED_DevToolsReattachAfterCrashTest
#else
#define MAYBE_DevToolsReattachAfterCrashTest DevToolsReattachAfterCrashTest
#endif
class MAYBE_DevToolsReattachAfterCrashTest : public DevToolsSanityTest {
protected: protected:
void RunTestWithPanel(const char* panel_name) { void RunTestWithPanel(const char* panel_name) {
OpenDevToolsWindow("about:blank", false); OpenDevToolsWindow("about:blank", false);
...@@ -1910,12 +1901,12 @@ class MAYBE_DevToolsReattachAfterCrashTest : public DevToolsSanityTest { ...@@ -1910,12 +1901,12 @@ class MAYBE_DevToolsReattachAfterCrashTest : public DevToolsSanityTest {
} }
}; };
IN_PROC_BROWSER_TEST_F(MAYBE_DevToolsReattachAfterCrashTest, IN_PROC_BROWSER_TEST_F(DevToolsReattachAfterCrashTest,
TestReattachAfterCrashOnTimeline) { TestReattachAfterCrashOnTimeline) {
RunTestWithPanel("timeline"); RunTestWithPanel("timeline");
} }
IN_PROC_BROWSER_TEST_F(MAYBE_DevToolsReattachAfterCrashTest, IN_PROC_BROWSER_TEST_F(DevToolsReattachAfterCrashTest,
TestReattachAfterCrashOnNetwork) { TestReattachAfterCrashOnNetwork) {
RunTestWithPanel("network"); RunTestWithPanel("network");
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment