Commit 3a3081b0 authored by sczs@chromium.org's avatar sczs@chromium.org Committed by Commit Bot

[ios] Hides native navigationBar on legacyBookmarks Editors.

- self.navigationController.navigationBarHidden = YES; wasn't being set or propagated to these VC's
anymore. This causes both the native navBar and MDCAppBar to be added to the view hierarchy.

On top of making tests fail, there was a large top inset on legacy Editors added by the native
navBar.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3b5196516c7b9c242cfef4ef89a01299c2ae0087
Reviewed-on: https://chromium-review.googlesource.com/1103295
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567822}
parent a3810c5e
...@@ -218,6 +218,7 @@ typedef NS_ENUM(NSInteger, ItemType) { ...@@ -218,6 +218,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
setSeparatorInset:UIEdgeInsetsMake( setSeparatorInset:UIEdgeInsetsMake(
0, kBookmarkCellHorizontalLeadingInset, 0, 0)]; 0, kBookmarkCellHorizontalLeadingInset, 0, 0)];
} else { } else {
self.navigationController.navigationBarHidden = YES;
[self.tableView setSeparatorStyle:UITableViewCellSeparatorStyleNone]; [self.tableView setSeparatorStyle:UITableViewCellSeparatorStyleNone];
} }
......
...@@ -179,6 +179,7 @@ folderEditorWithBookmarkModel:(bookmarks::BookmarkModel*)bookmarkModel ...@@ -179,6 +179,7 @@ folderEditorWithBookmarkModel:(bookmarks::BookmarkModel*)bookmarkModel
setSeparatorInset:UIEdgeInsetsMake( setSeparatorInset:UIEdgeInsetsMake(
0, kBookmarkCellHorizontalLeadingInset, 0, 0)]; 0, kBookmarkCellHorizontalLeadingInset, 0, 0)];
} else { } else {
self.navigationController.navigationBarHidden = YES;
[self.tableView setSeparatorStyle:UITableViewCellSeparatorStyleNone]; [self.tableView setSeparatorStyle:UITableViewCellSeparatorStyleNone];
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment