Commit 3a381605 authored by Shakti Sahu's avatar Shakti Sahu Committed by Commit Bot

Video Tutorials : Fixed last missing pieces for fetching server data

Change-Id: I1eeac7ede3aca6c71856ce541a086b5f302936ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473360
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818028}
parent c95c2b44
......@@ -11,13 +11,14 @@
namespace video_tutorials {
// Default base URL string for the server.
constexpr char kDefaultBaseURL[] = "https://chromeupboarding-pa.googleapis.com";
constexpr char kDefaultBaseURL[] =
"https://staging-gsaprototype-pa.sandbox.googleapis.com";
// Default URL string for GetTutorials RPC.
constexpr char kDefaultGetTutorialsPath[] = "/v1/videotutorials";
// Hindi is the default locale.
constexpr char kDefaultPreferredLocale[] = "hi";
constexpr char kDefaultPreferredLocale[] = "en";
// Finch parameter key for base server URL to retrieve the tutorials.
constexpr char kBaseURLKey[] = "base_url";
......
......@@ -29,8 +29,9 @@ TEST(VideoTutorialsConfigTest, ConfigDefaultParams) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(features::kVideoTutorials);
EXPECT_EQ(Config::GetTutorialsServerURL().spec(),
"https://chromeupboarding-pa.googleapis.com/v1/videotutorials");
EXPECT_EQ(Config::GetDefaultPreferredLocale(), "hi");
"https://staging-gsaprototype-pa.sandbox.googleapis.com/v1/"
"videotutorials");
EXPECT_EQ(Config::GetDefaultPreferredLocale(), "en");
}
} // namespace video_tutorials
......@@ -161,6 +161,7 @@ TEST_F(TutorialManagerTest, InitAndGetTutorials) {
auto languages = manager()->GetSupportedLanguages();
EXPECT_EQ(languages.size(), 2u);
manager()->SetPreferredLocale("hi");
GetTutorials();
EXPECT_EQ(last_results().size(), 2u);
}
......@@ -171,6 +172,7 @@ TEST_F(TutorialManagerTest, SaveNewData) {
tutorial_store->InitStoreData("hi", groups);
CreateTutorialManager(std::move(tutorial_store));
manager()->SetPreferredLocale("hi");
auto languages = manager()->GetSupportedLanguages();
EXPECT_EQ(languages.size(), 2u);
GetTutorials();
......
......@@ -20,7 +20,9 @@ TutorialServiceImpl::TutorialServiceImpl(
PrefService* pref_service)
: tutorial_manager_(std::move(tutorial_manager)),
tutorial_fetcher_(std::move(tutorial_fetcher)),
pref_service_(pref_service) {}
pref_service_(pref_service) {
StartFetchIfNecessary();
}
TutorialServiceImpl::~TutorialServiceImpl() = default;
......@@ -61,7 +63,8 @@ void TutorialServiceImpl::StartFetchIfNecessary() {
void TutorialServiceImpl::OnFetchFinished(
bool success,
std::unique_ptr<std::string> response_body) {
// TODO(shaktisahu): Save tutorials to the database.
pref_service_->SetTime(kLastUpdatedTimeKey, base::Time::Now());
if (!success || !response_body)
return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment