Commit 3a399fc7 authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

Android: Fix ErrorProne warnings about unused nested classes

TBR=agrieve  # ErrorProne fixes.

Bug: 1027541
Change-Id: I34f255431159cc9e99899ccf24f6126b490b8c4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933809
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: default avatarPeter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718661}
parent 5b6b516a
......@@ -4,8 +4,6 @@
package org.chromium.base.test.util;
import junit.framework.TestCase;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.RunWith;
......@@ -50,13 +48,6 @@ public class SkipCheckTest {
public void anotherUnannotatedMethod() {}
}
private class ExtendsTestCaseClass extends TestCase {
public ExtendsTestCaseClass(String name) {
super(name);
}
public void testMethodA() {}
}
private class UnannotatedBaseClass {
public void unannotatedMethod() {}
@TestAnnotation public void annotatedMethod() {}
......
......@@ -64,19 +64,6 @@ public class AccessibilityTabModelWrapper extends LinearLayout {
// to run against API version 19.
private boolean mIsAttachedToWindow;
private class ButtonOnClickListener implements View.OnClickListener {
private final boolean mIncognito;
public ButtonOnClickListener(boolean incognito) {
mIncognito = incognito;
}
@Override
public void onClick(View v) {
setSelectedModel(mIncognito);
}
}
public AccessibilityTabModelWrapper(Context context) {
super(context);
}
......
......@@ -278,15 +278,6 @@ public class ContextualSearchUma {
int NUM_ENTRIES = 2;
}
// Constants used to log UMA "enum" histograms for triggering the Translate Onebox.
@IntDef({ForceTranslate.DID_FORCE, ForceTranslate.WOULD_FORCE})
@Retention(RetentionPolicy.SOURCE)
private @interface ForceTranslate {
int DID_FORCE = 0;
int WOULD_FORCE = 1;
int NUM_ENTRIES = 2;
}
// Constants used to log UMA "enum" histograms for Quick Answers.
@IntDef({QuickAnswerSeen.ACTIVATED_WAS_AN_ANSWER_SEEN,
QuickAnswerSeen.ACTIVATED_WAS_AN_ANSWER_NOT_SEEN,
......
......@@ -169,20 +169,6 @@ public class OmahaBaseTest {
int TIMES_OUT = 1;
}
@IntDef({InstallEvent.SEND, InstallEvent.DONT_SEND})
@Retention(RetentionPolicy.SOURCE)
private @interface InstallEvent {
int SEND = 0;
int DONT_SEND = 1;
}
@IntDef({PostStatus.DUE, PostStatus.NOT_DUE})
@Retention(RetentionPolicy.SOURCE)
private @interface PostStatus {
int DUE = 0;
int NOT_DUE = 1;
}
private AdvancedMockContext mContext;
private MockOmahaDelegate mDelegate;
private MockOmahaBase mOmahaBase;
......
......@@ -43,20 +43,6 @@ public class WebappDataStorageTest {
private SharedPreferences mSharedPreferences;
private boolean mCallbackCalled;
private class FetchCallback<T> implements WebappDataStorage.FetchCallback<T> {
T mExpected;
FetchCallback(T expected) {
mExpected = expected;
}
@Override
public void onDataRetrieved(T readObject) {
mCallbackCalled = true;
assertEquals(mExpected, readObject);
}
}
@Before
public void setUp() {
mSharedPreferences = ContextUtils.getApplicationContext().getSharedPreferences(
......
......@@ -6,7 +6,6 @@ package org.chromium.components.background_task_scheduler;
import android.annotation.TargetApi;
import android.app.job.JobInfo;
import android.content.Context;
import android.os.Build;
import android.os.Bundle;
import android.os.PersistableBundle;
......@@ -30,22 +29,6 @@ import java.util.concurrent.TimeUnit;
@TargetApi(Build.VERSION_CODES.LOLLIPOP_MR1)
@MinAndroidSdkLevel(Build.VERSION_CODES.LOLLIPOP_MR1)
public class BackgroundTaskSchedulerJobServiceTest {
private static class TestBackgroundTask implements BackgroundTask {
@Override
public boolean onStartTask(
Context context, TaskParameters taskParameters, TaskFinishedCallback callback) {
return false;
}
@Override
public boolean onStopTask(Context context, TaskParameters taskParameters) {
return false;
}
@Override
public void reschedule(Context context) {}
}
private static final long CLOCK_TIME_MS = 1415926535000L;
private static final long TIME_50_MIN_TO_MS = TimeUnit.MINUTES.toMillis(50);
private static final long TIME_100_MIN_TO_MS = TimeUnit.MINUTES.toMillis(100);
......
......@@ -27,26 +27,12 @@ import org.robolectric.shadows.ShadowApplication;
import org.chromium.base.ContextUtils;
import org.chromium.base.test.BaseRobolectricTestRunner;
import java.util.concurrent.Executor;
/**
* Robolectric test for AbstractAppRestrictionsProvider.
*/
@RunWith(BaseRobolectricTestRunner.class)
@Config(manifest = Config.NONE)
public class AbstractAppRestrictionsProviderTest {
/*
* Robolectric's AsyncTasks don't do anything to override the underlying executor,
* which means that the don't reliably run within {@link Robolectric.RunBackgroundTasks()}.
* Create a special task executor that is guarenteed to run when expected.
*/
private class TestExecutor implements Executor {
@Override
public void execute(Runnable command) {
Robolectric.getBackgroundThreadScheduler().post(command);
}
}
/**
* Minimal concrete class implementing AbstractAppRestrictionsProvider.
*/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment