Commit 3a3e8f6e authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Remove / clarify references to iOS in chrome/.

Change-Id: I45224f299e5ac7fcff88241c7a5e0689603717cf
Reviewed-on: https://chromium-review.googlesource.com/1189545Reviewed-by: default avatarRamin Halavati <rhalavati@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586380}
parent 72782fca
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "chrome/browser/prefs/pref_service_syncable_util.h" #include "chrome/browser/prefs/pref_service_syncable_util.h"
#include <vector> #include <utility>
#include "chrome/browser/prefs/pref_service_incognito_whitelist.h" #include "chrome/browser/prefs/pref_service_incognito_whitelist.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
...@@ -28,9 +28,9 @@ CreateIncognitoPrefServiceSyncable( ...@@ -28,9 +28,9 @@ CreateIncognitoPrefServiceSyncable(
sync_preferences::PrefServiceSyncable* pref_service, sync_preferences::PrefServiceSyncable* pref_service,
PrefStore* incognito_extension_pref_store, PrefStore* incognito_extension_pref_store,
std::unique_ptr<PrefValueStore::Delegate> delegate) { std::unique_ptr<PrefValueStore::Delegate> delegate) {
// TODO(https://crbug.com/861722): Current implementation does not cover // TODO(https://crbug.com/861722): Current implementation does not cover
// preferences from iOS. The code should be refactored to cover it. // preferences from iOS. The code should be refactored to cover it. e.g. Moved
// to components/ so it can be used on iOS.
return pref_service->CreateIncognitoPrefService( return pref_service->CreateIncognitoPrefService(
incognito_extension_pref_store, incognito_extension_pref_store,
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
#ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_UTIL_H_ #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_UTIL_H_
#define CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_UTIL_H_ #define CHROME_BROWSER_PREFS_PREF_SERVICE_SYNCABLE_UTIL_H_
#include <set> #include <memory>
#include "components/prefs/pref_value_store.h" #include "components/prefs/pref_value_store.h"
...@@ -34,9 +34,6 @@ sync_preferences::PrefServiceSyncable* PrefServiceSyncableIncognitoFromProfile( ...@@ -34,9 +34,6 @@ sync_preferences::PrefServiceSyncable* PrefServiceSyncableIncognitoFromProfile(
// a fresh non-persistent overlay for the user pref store and an individual // a fresh non-persistent overlay for the user pref store and an individual
// extension pref store (to cache the effective extension prefs for incognito // extension pref store (to cache the effective extension prefs for incognito
// windows). // windows).
//
// If the Mojo pref service is in use |incognito_connector| and |user_connector|
// must be non-null.
std::unique_ptr<sync_preferences::PrefServiceSyncable> std::unique_ptr<sync_preferences::PrefServiceSyncable>
CreateIncognitoPrefServiceSyncable( CreateIncognitoPrefServiceSyncable(
sync_preferences::PrefServiceSyncable* pref_service, sync_preferences::PrefServiceSyncable* pref_service,
......
specific_include_rules = {
# OmniboxEditModel can't use WebContents, since it is used by iOS.
# If WebContents functionality is needed, add it to
# OmniboxCurrentPageDelegateImpl.
'omnibox_edit_model\.': [
"-content/public/browser/web_contents.h",
],
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment