[Code health] Convert CreateSnapshotFileSuccessCallback to RepeatingCallback

It seems that this needs to be a RepeatingCallback instead of
a OnceCallback. Because at the:
chrome/browser/media_galleries/win/snapshot_file_details.h,
this callback is used by SnapshotRequestInfo which is then owned
by SnapshotFileDetails. The SnapshotFileDetails need to have
const access to the SnapshotRequestInfo and hence the callback
cannot be a OnceCallback.

This is a code health CL, no behaviour change is expected.

Bug: 1152278
Change-Id: Ia5eb65521cf100c38b47ae288daa41e2e432e897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595928
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838185}

chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc

@@ -1338,8 +1338,9 @@ void MTPDeviceDelegateImplLinux::WriteDataIntoSnapshotFile(
   SnapshotRequestInfo request_info(
       current_snapshot_request_info_->file_id,
       current_snapshot_request_info_->snapshot_file_path,
-      base::Bind(&MTPDeviceDelegateImplLinux::OnDidWriteDataIntoSnapshotFile,
-                 weak_ptr_factory_.GetWeakPtr()),
+      base::BindRepeating(
+          &MTPDeviceDelegateImplLinux::OnDidWriteDataIntoSnapshotFile,
+          weak_ptr_factory_.GetWeakPtr()),
       base::BindRepeating(
           &MTPDeviceDelegateImplLinux::OnWriteDataIntoSnapshotFileError,
           weak_ptr_factory_.GetWeakPtr()));
@@ -1677,7 +1678,7 @@ void MTPDeviceDelegateImplLinux::OnDidCreateTemporaryFileToCopyFileLocal(
 
   CreateSnapshotFile(
       source_file_path, temporary_file_path,
-      base::Bind(
+      base::BindRepeating(
           &MTPDeviceDelegateImplLinux::OnDidCreateSnapshotFileOfCopyFileLocal,
           weak_ptr_factory_.GetWeakPtr(), device_file_path, progress_callback,
           success_callback, error_callback),

chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc

@@ -222,9 +222,9 @@ void OnSnapshotFileCreatedRunTask(
   delegate->CreateSnapshotFile(
       url.path(),  // device file path
       snapshot_file_path,
-      base::Bind(&OnDidCreateSnapshotFile, copyable_callback,
-                 base::RetainedRef(context->task_runner()),
-                 validate_media_files),
+      base::BindRepeating(&OnDidCreateSnapshotFile, copyable_callback,
+                          base::RetainedRef(context->task_runner()),
+                          validate_media_files),
       base::BindRepeating(&OnCreateSnapshotFileError, copyable_callback));
 }
 

chrome/browser/media_galleries/fileapi/mtp_device_async_delegate.h

@@ -46,9 +46,12 @@ class MTPDeviceAsyncDelegate {
   typedef base::RepeatingCallback<void(base::File::Error error)> ErrorCallback;
 
   // A callback to be called when CreateSnapshotFile method call succeeds.
-  typedef base::Callback<
-      void(const base::File::Info& file_info,
-           const base::FilePath& local_path)> CreateSnapshotFileSuccessCallback;
+  // TODO: consider make this a OnceCallback. Right now it is repeating because
+  // it is used in SnapshotRequestInfo, which is owned by SnapshotFileDetails,
+  // and SnapshotFileDetails needs const access to SnapshotRequestInfo.
+  typedef base::RepeatingCallback<void(const base::File::Info& file_info,
+                                       const base::FilePath& local_path)>
+      CreateSnapshotFileSuccessCallback;
 
   // A callback to be called when ReadBytes method call succeeds.
   typedef base::Callback<