Commit 3a5a57b1 authored by Basia Zimirska's avatar Basia Zimirska Committed by Chromium LUCI CQ

Set position of the toast to be 24dp above the tab layout.

Bug: 929990
Change-Id: If053038c7f97412f792ec98ef2613f9965536552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581005Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Reviewed-by: default avatarMegan Jablonski <megjablon@chromium.org>
Commit-Queue: Basia Zimirska <basiaz@google.com>
Cr-Commit-Position: refs/heads/master@{#836848}
parent cd18243c
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.infobar; package org.chromium.chrome.browser.infobar;
import android.view.Gravity;
import android.view.LayoutInflater; import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.View.OnClickListener; import android.view.View.OnClickListener;
...@@ -306,8 +307,15 @@ public class TranslateCompactInfoBar extends InfoBar ...@@ -306,8 +307,15 @@ public class TranslateCompactInfoBar extends InfoBar
if (mTabLayout != null) { if (mTabLayout != null) {
mTabLayout.hideProgressBar(); mTabLayout.hideProgressBar();
if (errorType != 0) { if (errorType != 0) {
Toast.makeText(getContext(), R.string.translate_infobar_error, Toast.LENGTH_SHORT) Toast toast = Toast.makeText(
.show(); getContext(), R.string.translate_infobar_error, Toast.LENGTH_SHORT);
int[] location = new int[2];
mTabLayout.getLocationOnScreen(location);
int yOffset = location[1] - mTabLayout.getHeight()
- getContext().getResources().getDimensionPixelSize(
R.dimen.translate_toast_y_offset);
toast.setGravity(Gravity.TOP | Gravity.CENTER_HORIZONTAL, 0, yOffset);
toast.show();
errorUIShown = true; errorUIShown = true;
silentlySelectTabAt(SOURCE_TAB_INDEX); silentlySelectTabAt(SOURCE_TAB_INDEX);
} }
......
...@@ -5,4 +5,5 @@ ...@@ -5,4 +5,5 @@
<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="UnusedResources"> <resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="UnusedResources">
<dimen name="infobar_translate_menu_width">260dp</dimen> <dimen name="infobar_translate_menu_width">260dp</dimen>
<dimen name="translate_toast_y_offset">24dp</dimen>
</resources> </resources>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment