Roll src/net/third_party/quiche/src/ 639a4bf5f..5efb965c1 (16 commits)

https://quiche.googlesource.com/quiche.git/+log/639a4bf5ff46..5efb965c1b4d

$ git log 639a4bf5f..5efb965c1 --date=short --no-merges --format='%ad %ae %s'
2020-03-17 dschinazi Do not use iterators in ParsedQuicVersionIsValid
2020-03-17 dschinazi Improve QUIC TLS error logging
2020-03-17 bnc Add test for default return value of QuicSpdySession::server_push_enabled().
2020-03-16 bnc gfe-relnote: Switch from closing the connection to QUIC_BUG in two ShouldCreateIncomingStream() overrides when called with locally initiated stream ID.  Protected by gfe2_reloadable_flag_quic_create_incoming_stream_bug.
2020-03-16 wub gfe-relnote: In QuicBandwidth::FromBytesAndTimeDelta,do multiplication before division to make rounding error less likely.  Not protected.
2020-03-16 dschinazi Have ParsedQuicVersionIsValid also validate transport versions
2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_batch_writer_flush_after_mtu_probe.
2020-03-16 dschinazi Prevent crash when trying to serialize packet with missing encryption key
2020-03-16 bnc gfe-relnote: Disable server push.  Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27.
2020-03-16 quiche-dev gfe-relnote: reset has_non_app_limited_sample in QuicConnectionStats to false once handshake is complete. Logging only change, not protected.
2020-03-16 dschinazi Fix QuicVersion MSVC compilation for Envoy
2020-03-16 wub gfe-relnote: (n/a) Add 2 connection options for BBRv2 to disable 1) adding ack height in queueing threshold, and 2) avoiding unnecessary PROBE_RTTs. Not protected, just more switches for already existing behaviors.
2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_check_handshake_timeout_before_idle_timeout.
2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_send_algorithm_noop_if_cc_type_unchanged.
2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_no_window_update_if_disconnected.
2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_neuter_unencrypted_control_frames.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

add/delete flags

R=zhongyi@chromium.org

Change-Id: I990459757848577d6f839306a8fec48d389fb6b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106555Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Dan Zhang <danzh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751141}

DEPS

@@ -306,7 +306,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling feed
   # and whatever else without interference from each other.
-  'quiche_revision': '639a4bf5ff46e4b49a6ccc3677fd0f8122419503',
+  'quiche_revision': '5efb965c1b4d8e7fda64d7b41ce2ca3c601fc3fb',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling ios_webkit
   # and whatever else without interference from each other.

net/quic/quic_flags_list.h

@@ -273,34 +273,15 @@ QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_ack_delay_alarm_granularity,
           false)
 
-// If true, QuicSentPacketManager::SetSendAlgorithm(CongestionControlType) will
-// become a no-op if the current and the requested cc_type are the same.
-QUIC_FLAG(
-    bool,
-    FLAGS_quic_reloadable_flag_quic_set_send_algorithm_noop_if_cc_type_unchanged,
-    true)
-
 // If true, use predictable grease settings identifiers and values.
 QUIC_FLAG(bool, FLAGS_quic_enable_http3_grease_randomness, true)
 
-// If true, QuicConnection will check handshake timeout before idle timeout.
-QUIC_FLAG(
-    bool,
-    FLAGS_quic_reloadable_flag_quic_check_handshake_timeout_before_idle_timeout,
-    true)
-
 // If true and batch writer is used, QuicConnection will flush after a mtu probe
 // is sent.
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_batch_writer_flush_after_mtu_probe,
           true)
 
-// If true, neuter unencrypted control frames in
-// QuicUnackedPacketMap::NeuterUnencryptedPackets.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_neuter_unencrypted_control_frames,
-          true)
-
 // When the EACK connection option is sent by the client, an ack-eliciting frame
 // is bundled with ACKs sent after the PTO fires.
 QUIC_FLAG(bool,
@@ -342,11 +323,6 @@ QUIC_FLAG(
     FLAGS_quic_reloadable_flag_quic_minimum_validation_of_coalesced_packets,
     true)
 
-// If true, do not send WINDOW_UPDATE if connection has been disconnected.
-QUIC_FLAG(bool,
-          FLAGS_quic_reloadable_flag_quic_no_window_update_if_disconnected,
-          true)
-
 // If true, arm the 1st PTO with earliest in flight sent time.
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_arm_pto_with_earliest_sent_time,
@@ -399,3 +375,9 @@ QUIC_FLAG(bool, FLAGS_quic_reloadable_flag_quic_write_with_transmission, false)
 QUIC_FLAG(bool,
           FLAGS_quic_reloadable_flag_quic_bbr_fix_zero_bw_on_loss_only_event,
           false)
+
+// If true, trigger QUIC_BUG in two ShouldCreateIncomingStream() overrides when
+// called with locally initiated stream ID.
+QUIC_FLAG(bool,
+          FLAGS_quic_reloadable_flag_quic_create_incoming_stream_bug,
+          false)