Commit 3a71d24d authored by Tina Quach's avatar Tina Quach Committed by Commit Bot

[MD Settings] Fixed accessibility issues in password section.

Specify labels that are referenced using the aria-labelledby attribute to passwords section's searchInputs and passwords. Remove the for attribute, not needed since we are using aria-labelledby instead.

Bug: 737739
Change-Id: Ibdc7d0752d2e1972c8692ca743e39ababc24f868
Reviewed-on: https://chromium-review.googlesource.com/568240Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tina Quach <quacht@google.com>
Cr-Commit-Position: refs/heads/master@{#487530}
parent 9594b160
......@@ -33,9 +33,9 @@
<div class="password-column">
<template is="dom-if" if="[[!item.federationText]]">
<!-- Password type and disabled in order to match mock. -->
<input id="password" type="password" class="password-field text-elide"
disabled value=
"[[getEmptyPassword_(item.numCharactersInPassword)]]">
<input id="password" aria-label=$i18n{editPasswordPasswordLabel}
type="password" class="password-field text-elide" disabled
value="[[getEmptyPassword_(item.numCharactersInPassword)]]">
</input>
</template>
<template is="dom-if" if="[[item.federationText]]">
......
......@@ -72,7 +72,7 @@
<iron-icon id="searchIcon" icon="cr:search"></iron-icon>
<paper-input-container no-label-float>
<input id="searchInput" type="search" on-search="onSearchTermSearch"
on-input="onSearchTermInput" aria-labelledby="prompt" incremental
on-input="onSearchTermInput" aria-label$="[[label]]" incremental
autofocus$="[[autofocus]]" placeholder="[[label]]">
<button suffix is="paper-icon-button-light" id="clearSearch"
class="icon-cancel" on-tap="onTapClear_" title="[[clearLabel]]"
......
......@@ -142,6 +142,7 @@
<div id="searchTerm">
<label id="prompt" for="searchInput" aria-hidden="true">[[label]]</label>
<input id="searchInput"
aria-labelledby="prompt"
type="search"
on-input="onSearchTermInput"
on-search="onSearchTermSearch"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment