Settings: Add help center link to cookies and security pages

Bug: 1032584
Change-Id: I89fa54cd86fbe13eade7e85efc86b15ec99474fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126932
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755328}

chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -181,7 +181,8 @@
           no-search="[[!privacySettingsRedesignEnabled_]]">
         <settings-subpage id="security" page-title="$i18n{securityPageTitle}"
             no-search$="[[!privacySettingsRedesignEnabled_]]"
-            associated-control="[[$$('#securityLinkRow')]]">
+            associated-control="[[$$('#securityLinkRow')]]"
+            learn-more-url="$i18n{safeBrowsingHelpCenterURL}">
           <settings-security-page prefs="{{prefs}}"
               focus-config="[[focusConfig_]]"
               sync-status="[[syncStatus]]">
@@ -250,6 +251,7 @@
       <template is="dom-if" route-path="/cookies"
           no-search="[[!privacySettingsRedesignEnabled_]]">
         <settings-subpage id="cookies" page-title="$i18n{cookiePageTitle}"
+            learn-more-url="$i18n{cookiesSettingsHelpCenterURL}"
             no-search$="[[!privacySettingsRedesignEnabled_]]"
             search-label="$i18n{siteSettingsAllSitesSearch}"
             search-term="{{searchFilter_}}"

chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc

@@ -1240,8 +1240,15 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source,
   };
   AddLocalizedStringsBulk(html_source, kLocalizedStrings);
 
+  html_source->AddString("cookiesSettingsHelpCenterURL",
+                         chrome::kCookiesSettingsHelpCenterURL);
+
+  html_source->AddString("safeBrowsingHelpCenterURL",
+                         chrome::kSafeBrowsingHelpCenterURL);
+
   html_source->AddString("syncAndGoogleServicesLearnMoreURL",
                          chrome::kSyncAndGoogleServicesLearnMoreURL);
+
   html_source->AddString(
       "doNotTrackDialogMessage",
       l10n_util::GetStringFUTF16(

chrome/common/url_constants.cc

@@ -121,6 +121,9 @@ const char kCloudPrintCertificateErrorLearnMoreURL[] =
 const char kContentSettingsExceptionsLearnMoreURL[] =
     "https://support.google.com/chrome/?p=settings_manage_exceptions";
 
+const char kCookiesSettingsHelpCenterURL[] =
+    "https://support.google.com/chrome?p=cpn_cookies";
+
 const char kCrashReasonURL[] =
 #if defined(OS_CHROMEOS)
     "https://support.google.com/chromebook/?p=e_awsnap";
@@ -242,6 +245,9 @@ const char kRemoveNonCWSExtensionURL[] =
 const char kResetProfileSettingsLearnMoreURL[] =
     "https://support.google.com/chrome/?p=ui_reset_settings";
 
+const char kSafeBrowsingHelpCenterURL[] =
+    "https://support.google.com/chrome?p=cpn_safe_browsing";
+
 const char kSafetyTipHelpCenterURL[] =
     "https://support.google.com/chrome/?p=safety_tip";
 

chrome/common/url_constants.h

@@ -124,6 +124,9 @@ extern const char kCloudPrintCertificateErrorLearnMoreURL[];
 
 extern const char kContentSettingsExceptionsLearnMoreURL[];
 
+// "Learn more" URL for cookies.
+extern const char kCookiesSettingsHelpCenterURL[];
+
 // "Learn more" URL for "Aw snap" page when showing "Reload" button.
 extern const char kCrashReasonURL[];
 
@@ -203,6 +206,9 @@ extern const char kRemoveNonCWSExtensionURL[];
 // "Learn more" URL for resetting profile preferences.
 extern const char kResetProfileSettingsLearnMoreURL[];
 
+// "Learn more" URL for Safebrowsing
+extern const char kSafeBrowsingHelpCenterURL[];
+
 // "Learn more" URL for safety tip bubble.
 extern const char kSafetyTipHelpCenterURL[];