Commit 3aa44cb5 authored by Leo Zhang's avatar Leo Zhang Committed by Commit Bot

Keyboard flags cleanup.

Remove unused keyboard flag kEnableExperimentalInputViewFeatures which
is faulty now.

Bug: 880659
Change-Id: Ia4bb8ec3cfd4f38393fe9e6f270563fc7c313245
Reviewed-on: https://chromium-review.googlesource.com/1212427Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589854}
parent 31a1f5b2
......@@ -1948,11 +1948,6 @@ const FeatureEntry kFeatureEntries[] = {
{"disable-voice-input", flag_descriptions::kVoiceInputName,
flag_descriptions::kVoiceInputDescription, kOsCrOS,
SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableVoiceInput)},
{"experimental-input-view-features",
flag_descriptions::kExperimentalInputViewFeaturesName,
flag_descriptions::kExperimentalInputViewFeaturesDescription, kOsCrOS,
SINGLE_VALUE_TYPE(
keyboard::switches::kEnableExperimentalInputViewFeatures)},
{"gesture-typing", flag_descriptions::kGestureTypingName,
flag_descriptions::kGestureTypingDescription, kOsCrOS,
SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableGestureTyping)},
......
......@@ -274,8 +274,6 @@ void ChromeVirtualKeyboardDelegate::OnHasInputDevices(
GenerateFeatureFlag("gesturetyping", keyboard::IsGestureTypingEnabled()));
features->AppendString(GenerateFeatureFlag(
"gestureediting", keyboard::IsGestureEditingEnabled()));
features->AppendString(GenerateFeatureFlag(
"experimental", keyboard::IsExperimentalInputViewEnabled()));
features->AppendString(GenerateFeatureFlag(
"fullscreenhandwriting",
keyboard::IsFullscreenHandwritingVirtualKeyboardEnabled()));
......
......@@ -3327,11 +3327,6 @@ const char kExperimentalAccessibilityFeaturesName[] =
const char kExperimentalAccessibilityFeaturesDescription[] =
"Enable additional accessibility features in the Settings page.";
const char kExperimentalInputViewFeaturesName[] =
"Experimental input view features";
const char kExperimentalInputViewFeaturesDescription[] =
"Enable experimental features for IME input views.";
const char kFileManagerTouchModeName[] = "Files App. touch mode";
const char kFileManagerTouchModeDescription[] =
"Touchscreen-specific interactions of the Files app.";
......
......@@ -2031,9 +2031,6 @@ extern const char kEolNotificationDescription[];
extern const char kExperimentalAccessibilityFeaturesName[];
extern const char kExperimentalAccessibilityFeaturesDescription[];
extern const char kExperimentalInputViewFeaturesName[];
extern const char kExperimentalInputViewFeaturesDescription[];
extern const char kFileManagerTouchModeName[];
extern const char kFileManagerTouchModeDescription[];
......
......@@ -8,8 +8,6 @@ namespace keyboard {
namespace switches {
const char kDisableInputView[] = "disable-input-view";
const char kEnableExperimentalInputViewFeatures[] =
"enable-experimental-input-view-features";
const char kDisableVoiceInput[] = "disable-voice-input";
const char kDisableGestureTyping[] = "disable-gesture-typing";
const char kDisableGestureEditing[] = "disable-gesture-editing";
......
......@@ -17,9 +17,6 @@ KEYBOARD_EXPORT extern const char kDisableInputView[];
// Disables voice input.
KEYBOARD_EXPORT extern const char kDisableVoiceInput[];
// Enables experimental features for IME extensions.
KEYBOARD_EXPORT extern const char kEnableExperimentalInputViewFeatures[];
// Flag which disables gesture typing for the virtual keyboard.
KEYBOARD_EXPORT extern const char kDisableGestureTyping[];
......
......@@ -199,11 +199,6 @@ bool IsInputViewEnabled() {
switches::kDisableInputView);
}
bool IsExperimentalInputViewEnabled() {
return base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableExperimentalInputViewFeatures);
}
bool IsFloatingVirtualKeyboardEnabled() {
return base::FeatureList::IsEnabled(features::kEnableFloatingVirtualKeyboard);
}
......
......@@ -136,9 +136,6 @@ KEYBOARD_EXPORT void SetKeyboardRestricted(bool restricted);
// Returns whether the keyboard is in restricted state.
KEYBOARD_EXPORT bool GetKeyboardRestricted();
// Returns true if experimental features are enabled for IME input-views.
KEYBOARD_EXPORT bool IsExperimentalInputViewEnabled();
// Returns true if floating virtual keyboard feature is enabled.
KEYBOARD_EXPORT bool IsFloatingVirtualKeyboardEnabled();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment