Skip to content

GitLab

T
tangled
Commit 3abd33df authored by Matt Mueller's avatar Matt Mueller Committed by Commit Bot
Browse files
Options

Fix SSLClientCertificateSelectorCocoaTest.HideShow use-after-free. 

Bug: 735484
Change-Id: I4790d366d69636bdb2d4da54fbe4ab775e921c98
Reviewed-on: https://chromium-review.googlesource.com/543582Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481954}
parent 194f67a5
Hide whitespace changes
Inline Side-by-side
Showing with 5 additions and 0 deletions
chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm
View file @ 3abd33df
...@@ -269,6 +269,11 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) { ...@@ -269,6 +269,11 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) {
EXPECT_FALSE(results.destroyed); EXPECT_FALSE(results.destroyed);
EXPECT_FALSE(results.continue_with_certificate_called); EXPECT_FALSE(results.continue_with_certificate_called);
// Close the tab. Delegate should be destroyed without continuing.
chrome::CloseTab(browser());
EXPECT_TRUE(results.destroyed);
EXPECT_FALSE(results.continue_with_certificate_called);
} }
@interface DeallocTrackingSSLClientCertificateSelectorCocoa @interface DeallocTrackingSSLClientCertificateSelectorCocoa
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment