Commit 3ac8827a authored by Dominick Ng's avatar Dominick Ng Committed by Commit Bot

Deduplicate WebApkUpdateManager and GeolocationHeader test file names.

This CL also runs git cl format on the test files.

BUG=778442

Change-Id: If823c7f0dc2c26485102c74223d1c1c6a946f0bb
Reviewed-on: https://chromium-review.googlesource.com/743162
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512699}
parent eb412d96
...@@ -1900,7 +1900,7 @@ chrome_junit_test_java_sources = [ ...@@ -1900,7 +1900,7 @@ chrome_junit_test_java_sources = [
"junit/src/org/chromium/chrome/browser/omnibox/KeyboardHideHelperUnitTest.java", "junit/src/org/chromium/chrome/browser/omnibox/KeyboardHideHelperUnitTest.java",
"junit/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java", "junit/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java",
"junit/src/org/chromium/chrome/browser/omnibox/SpannableAutocompleteEditTextModelUnitTest.java", "junit/src/org/chromium/chrome/browser/omnibox/SpannableAutocompleteEditTextModelUnitTest.java",
"junit/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java", "junit/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderUnitTest.java",
"junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTest.java", "junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTest.java",
"junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java", "junit/src/org/chromium/chrome/browser/omnibox/geo/VisibleNetworksTrackerTest.java",
"junit/src/org/chromium/chrome/browser/omnibox/geo/PlatformNetworksManagerTest.java", "junit/src/org/chromium/chrome/browser/omnibox/geo/PlatformNetworksManagerTest.java",
...@@ -1926,7 +1926,7 @@ chrome_junit_test_java_sources = [ ...@@ -1926,7 +1926,7 @@ chrome_junit_test_java_sources = [
"junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java", "junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java",
"junit/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java", "junit/src/org/chromium/chrome/browser/webapps/WebappInfoTest.java",
"junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java", "junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java",
"junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java", "junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerUnitTest.java",
"junit/src/org/chromium/chrome/browser/widget/selection/SelectionDelegateTest.java", "junit/src/org/chromium/chrome/browser/widget/selection/SelectionDelegateTest.java",
] ]
......
...@@ -25,9 +25,9 @@ import org.robolectric.annotation.Implements; ...@@ -25,9 +25,9 @@ import org.robolectric.annotation.Implements;
import org.chromium.base.library_loader.ProcessInitException; import org.chromium.base.library_loader.ProcessInitException;
import org.chromium.base.metrics.RecordHistogram; import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.browser.omnibox.geo.GeolocationHeaderTest.ShadowRecordHistogram; import org.chromium.chrome.browser.omnibox.geo.GeolocationHeaderUnitTest.ShadowRecordHistogram;
import org.chromium.chrome.browser.omnibox.geo.GeolocationHeaderTest.ShadowUrlUtilities; import org.chromium.chrome.browser.omnibox.geo.GeolocationHeaderUnitTest.ShadowUrlUtilities;
import org.chromium.chrome.browser.omnibox.geo.GeolocationHeaderTest.ShadowWebsitePreferenceBridge; import org.chromium.chrome.browser.omnibox.geo.GeolocationHeaderUnitTest.ShadowWebsitePreferenceBridge;
import org.chromium.chrome.browser.omnibox.geo.VisibleNetworks.VisibleCell; import org.chromium.chrome.browser.omnibox.geo.VisibleNetworks.VisibleCell;
import org.chromium.chrome.browser.omnibox.geo.VisibleNetworks.VisibleWifi; import org.chromium.chrome.browser.omnibox.geo.VisibleNetworks.VisibleWifi;
import org.chromium.chrome.browser.preferences.website.WebsitePreferenceBridge; import org.chromium.chrome.browser.preferences.website.WebsitePreferenceBridge;
...@@ -46,7 +46,7 @@ import java.util.HashSet; ...@@ -46,7 +46,7 @@ import java.util.HashSet;
@Config(manifest = Config.NONE, @Config(manifest = Config.NONE,
shadows = {ShadowUrlUtilities.class, ShadowRecordHistogram.class, shadows = {ShadowUrlUtilities.class, ShadowRecordHistogram.class,
ShadowWebsitePreferenceBridge.class}) ShadowWebsitePreferenceBridge.class})
public class GeolocationHeaderTest { public class GeolocationHeaderUnitTest {
private static final String SEARCH_URL = "https://www.google.com/search?q=potatoes"; private static final String SEARCH_URL = "https://www.google.com/search?q=potatoes";
private static final double LOCATION_LAT = 20.3; private static final double LOCATION_LAT = 20.3;
...@@ -136,9 +136,9 @@ public class GeolocationHeaderTest { ...@@ -136,9 +136,9 @@ public class GeolocationHeaderTest {
@Test @Test
public void testTrimVisibleNetworksEmptyOrNull() throws ProcessInitException { public void testTrimVisibleNetworksEmptyOrNull() throws ProcessInitException {
VisibleNetworks visibleNetworks = VisibleNetworks.create( VisibleNetworks visibleNetworks =
VisibleWifi.create("whatever", null, null, null), VisibleNetworks.create(VisibleWifi.create("whatever", null, null, null), null,
null, new HashSet(), new HashSet()); new HashSet(), new HashSet());
assertNull(GeolocationHeader.trimVisibleNetworks(visibleNetworks)); assertNull(GeolocationHeader.trimVisibleNetworks(visibleNetworks));
assertNull(GeolocationHeader.trimVisibleNetworks(null)); assertNull(GeolocationHeader.trimVisibleNetworks(null));
} }
......
...@@ -53,7 +53,7 @@ import java.util.Map; ...@@ -53,7 +53,7 @@ import java.util.Map;
*/ */
@RunWith(LocalRobolectricTestRunner.class) @RunWith(LocalRobolectricTestRunner.class)
@Config(manifest = Config.NONE, shadows = {CustomShadowAsyncTask.class}) @Config(manifest = Config.NONE, shadows = {CustomShadowAsyncTask.class})
public class WebApkUpdateManagerTest { public class WebApkUpdateManagerUnitTest {
@Rule @Rule
public DisableHistogramsRule mDisableHistogramsRule = new DisableHistogramsRule(); public DisableHistogramsRule mDisableHistogramsRule = new DisableHistogramsRule();
...@@ -222,8 +222,7 @@ public class WebApkUpdateManagerTest { ...@@ -222,8 +222,7 @@ public class WebApkUpdateManagerTest {
private void registerWebApk( private void registerWebApk(
String packageName, ManifestData manifestData, int shellApkVersionCode) { String packageName, ManifestData manifestData, int shellApkVersionCode) {
Bundle metaData = new Bundle(); Bundle metaData = new Bundle();
metaData.putInt( metaData.putInt(WebApkMetaDataKeys.SHELL_APK_VERSION, shellApkVersionCode);
WebApkMetaDataKeys.SHELL_APK_VERSION, shellApkVersionCode);
metaData.putString(WebApkMetaDataKeys.START_URL, manifestData.startUrl); metaData.putString(WebApkMetaDataKeys.START_URL, manifestData.startUrl);
metaData.putString(WebApkMetaDataKeys.SCOPE, manifestData.scopeUrl); metaData.putString(WebApkMetaDataKeys.SCOPE, manifestData.scopeUrl);
metaData.putString(WebApkMetaDataKeys.NAME, manifestData.name); metaData.putString(WebApkMetaDataKeys.NAME, manifestData.name);
...@@ -241,8 +240,8 @@ public class WebApkUpdateManagerTest { ...@@ -241,8 +240,8 @@ public class WebApkUpdateManagerTest {
iconUrlsAndIconMurmur2Hashes += " " + mapEntry.getKey() + " " + murmur2Hash; iconUrlsAndIconMurmur2Hashes += " " + mapEntry.getKey() + " " + murmur2Hash;
} }
iconUrlsAndIconMurmur2Hashes = iconUrlsAndIconMurmur2Hashes.trim(); iconUrlsAndIconMurmur2Hashes = iconUrlsAndIconMurmur2Hashes.trim();
metaData.putString(WebApkMetaDataKeys.ICON_URLS_AND_ICON_MURMUR2_HASHES, metaData.putString(
iconUrlsAndIconMurmur2Hashes); WebApkMetaDataKeys.ICON_URLS_AND_ICON_MURMUR2_HASHES, iconUrlsAndIconMurmur2Hashes);
WebApkTestHelper.registerWebApkWithMetaData(packageName, metaData); WebApkTestHelper.registerWebApkWithMetaData(packageName, metaData);
} }
...@@ -287,7 +286,7 @@ public class WebApkUpdateManagerTest { ...@@ -287,7 +286,7 @@ public class WebApkUpdateManagerTest {
* @param color The bitmap color. * @param color The bitmap color.
*/ */
private static Bitmap createBitmap(int color) { private static Bitmap createBitmap(int color) {
int colors[] = { color }; int colors[] = {color};
return ShadowBitmap.createBitmap(colors, 1, 1, Bitmap.Config.ALPHA_8); return ShadowBitmap.createBitmap(colors, 1, 1, Bitmap.Config.ALPHA_8);
} }
...@@ -316,8 +315,8 @@ public class WebApkUpdateManagerTest { ...@@ -316,8 +315,8 @@ public class WebApkUpdateManagerTest {
onGotManifestData(updateManager, manifestData); onGotManifestData(updateManager, manifestData);
} }
private static void onGotManifestData(WebApkUpdateManager updateManager, private static void onGotManifestData(
ManifestData fetchedManifestData) { WebApkUpdateManager updateManager, ManifestData fetchedManifestData) {
String primaryIconUrl = randomIconUrl(fetchedManifestData); String primaryIconUrl = randomIconUrl(fetchedManifestData);
String badgeIconUrl = randomIconUrl(fetchedManifestData); String badgeIconUrl = randomIconUrl(fetchedManifestData);
updateManager.onGotManifestData( updateManager.onGotManifestData(
...@@ -718,8 +717,7 @@ public class WebApkUpdateManagerTest { ...@@ -718,8 +717,7 @@ public class WebApkUpdateManagerTest {
ManifestData oldData = defaultManifestData(); ManifestData oldData = defaultManifestData();
oldData.startUrl = "/fancy/scope/special/snowflake.html"; oldData.startUrl = "/fancy/scope/special/snowflake.html";
oldData.scopeUrl = "/fancy/scope/"; oldData.scopeUrl = "/fancy/scope/";
assertTrue( assertTrue(!oldData.scopeUrl.equals(ShortcutHelper.getScopeFromUrl(oldData.startUrl)));
!oldData.scopeUrl.equals(ShortcutHelper.getScopeFromUrl(oldData.startUrl)));
ManifestData fetchedData = defaultManifestData(); ManifestData fetchedData = defaultManifestData();
fetchedData.startUrl = "/fancy/scope/special/snowflake.html"; fetchedData.startUrl = "/fancy/scope/special/snowflake.html";
fetchedData.scopeUrl = ""; fetchedData.scopeUrl = "";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment