Skip to content

GitLab

T
tangled
Commit 3ad7d07c authored by Jeffrey Chen's avatar Jeffrey Chen Committed by Commit Bot
Browse files
Options

Revert "Use opacity of 0.54 for placeholder text in input fields" 

This reverts commit 30d3999b.

Reason for revert: crbug.com/1009285

Original change's description:
> Use opacity of 0.54 for placeholder text in input fields
>
> Prior to this change, placeholder text in input fields was set to grey
> (#757575), but this did not apply to emojis. Now, we use an opacity
> value to control the placeholder appearance. 0.54 is used because in a
> white input field, regular placeholder text still appears as #757575.
>
> Bug: 932026
> Change-Id: Iba02fe3eb31484255332f2f34a67f97b97f50cb8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754086
> Commit-Queue: Jeffrey C <jeffreyca16@gmail.com>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#691770}

TBR=aboxhall@chromium.org,eae@chromium.org,tkent@chromium.org,jeffreyca16@gmail.com

Bug: 932026, 1009285
Change-Id: I97b7114ceb670e09bfbd6461d761a6404fa5c5be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839434
Commit-Queue: Jeffrey Chen <jeffreyca16@gmail.com>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702988}
parent 69304271
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 32 deletions
third_party/blink/renderer/core/html/resources/html.css
View file @ 3ad7d07c
......@@ -511,7 +511,7 @@ textarea {
::-webkit-input-placeholder {
-webkit-text-security: none;
color: -internal-light-dark-color(rgba(0, 0, 0, 0.54), rgba(255, 255, 255, 0.54));
color: #757575;
pointer-events: none !important;
}
......
third_party/blink/web_tests/fast/forms/password-placeholder-text-security-expected.html
View file @ 3ad7d07c
......@@ -2,7 +2,7 @@
<head>
<style>
#pass1, #pass3 {
color: rgba(0, 0, 0, 0.54);
color: #757575;
}
</style>
</head>
......
third_party/blink/web_tests/fast/forms/text/input-placeholder-text-indent-expected.html
View file @ 3ad7d07c
<style>
input { color: rgba(0, 0, 0, 0.54); font-size: 30px; width: 500px; }
input { color: #757575; font-size: 30px; width: 500px; }
input.a { text-indent: 0px; }
input.b { text-indent: 10px; }
input.c { text-indent: 200px; }
......
third_party/blink/web_tests/fast/forms/text/placeholder-containing-emoji-expected.html deleted 100644 → 0
View file @ 69304271
<!DOCTYPE html>
<style>
input {
color: rgba(0, 0, 0, 0.54);
line-height: 15px;
}
</style>
This tests that emojis in placeholders appear faded along with the text.
<div>
<input value="default 😊">
<input disabled value="default disabled 😊">
</div>
third_party/blink/web_tests/fast/forms/text/placeholder-containing-emoji.html deleted 100644 → 0
View file @ 69304271
<!DOCTYPE html>
<style>
input {
line-height: 15px;
}
</style>
This tests that emojis in placeholders appear faded along with the text.
<div>
<input placeholder="default 😊">
<input disabled placeholder="default disabled 😊">
</div>
third_party/blink/web_tests/fast/forms/text/placeholder-pseudo-style-expected.html
View file @ 3ad7d07c
<!DOCTYPE html>
<style>
input {
color: rgba(0, 0, 0, 0.54);
color: #757575;
}
input.red {
......@@ -31,7 +31,7 @@ This tests that you can set the placeholder text color.
<div>
Default style:
<input value="default">
<input disabled value="default disabled">
<input value="default disabled">
</div>
<div>
......
third_party/blink/web_tests/fast/forms/text/placeholder-pseudo-style.html
View file @ 3ad7d07c
......@@ -27,7 +27,7 @@ This tests that you can set the placeholder text color.
<div>
Default style:
<input placeholder="default">
<input disabled placeholder="default disabled">
<input placeholder="default disabled">
</div>
<div>
......
third_party/blink/web_tests/fast/forms/text/placeholder-with-positioned-element-expected.html
View file @ 3ad7d07c
......@@ -2,4 +2,4 @@
<div>aaa</div>
<div>bbb</div>
</div>
<input style="color: rgba(0, 0, 0, 0.54);" value="placeholder">
<input style="color: #757575;" value="placeholder">
third_party/blink/web_tests/fast/forms/textarea/textarea-placeholder-pseudo-style-expected.html
View file @ 3ad7d07c
<!DOCTYPE html>
<style>
textarea {
color: rgba(0, 0, 0, 0.54);
color: #757575;
}
.red {
......
third_party/blink/web_tests/fast/forms/textarea/textarea-placeholder-wrapping-expected.html
View file @ 3ad7d07c
<textarea rows=8>
A quick brown fox jumps over the lazy dog. A quick brown fox jumps over the lazy dog.
</textarea>
<textarea rows=8 style="color: rgba(0, 0, 0, 0.54);">
<textarea rows=8 style="color: #757575;">
A quick brown fox jumps over the lazy dog. A quick brown fox jumps over the lazy dog.
</textarea>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment