Commit 3af94721 authored by Tommy Martino's avatar Tommy Martino Committed by Commit Bot

Fix Disappearing Logo on Android NTP

This addresses the linked bug where the search provider logo would
sometimes disappear on the Android NTP under certain conditions
(device rotated while the logo is scrolled off-screen). A lot more
context on the bug is in this thread (googlers only, sorry):
https://groups.google.com/a/google.com/g/clank-dev/c/IWxWjz6qc90

One of the posts in that thread suggested changing the width of the logo
in the XML, and since doing so I have not been able to repro the bug, so
I believe this should fix the blocking issue.

Bug: 1122928
Change-Id: Id4503fa5a1131a83a43b7dbb083e7253f7e8138d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392751Reviewed-by: default avatarTommy Martino <tmartino@chromium.org>
Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804389}
parent fb839cf4
...@@ -28,10 +28,9 @@ ...@@ -28,10 +28,9 @@
android:layout_height="@dimen/cryptid_height_in_logo_wrapper" android:layout_height="@dimen/cryptid_height_in_logo_wrapper"
android:layout_gravity="bottom|start" /> android:layout_gravity="bottom|start" />
<org.chromium.chrome.browser.ntp.LogoView <org.chromium.chrome.browser.ntp.LogoView
android:id="@+id/search_provider_logo" android:id="@+id/search_provider_logo"
android:layout_width="wrap_content" android:layout_width="match_parent"
android:layout_height="@dimen/ntp_logo_height" android:layout_height="@dimen/ntp_logo_height"
android:layout_gravity="center_horizontal" android:layout_gravity="center_horizontal"
android:layout_marginStart="16dp" android:layout_marginStart="16dp"
...@@ -40,7 +39,7 @@ ...@@ -40,7 +39,7 @@
android:layout_marginBottom="23dp" /> android:layout_marginBottom="23dp" />
</FrameLayout> </FrameLayout>
<!-- Search box --> <!-- Search box -->
<include layout="@layout/fake_search_box_layout"/> <include layout="@layout/fake_search_box_layout"/>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment