Commit 3afb12a4 authored by joi@chromium.org's avatar joi@chromium.org

Add rules to exclude files with paths containing /test/, /tool/ and /tools/.

BUG=none
TEST=manually tested by developer

Review URL: http://codereview.chromium.org/7637015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96768 0039d316-1c4b-4281-b951-d872f2087c98
parent 9320a303
...@@ -51,6 +51,7 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): ...@@ -51,6 +51,7 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
file_inclusion_pattern = r'.+%s' % source_extensions file_inclusion_pattern = r'.+%s' % source_extensions
file_exclusion_pattern = (r'.+(_test_support|_(unit|browser|ui|perf)test)%s' % file_exclusion_pattern = (r'.+(_test_support|_(unit|browser|ui|perf)test)%s' %
source_extensions) source_extensions)
path_exclusion_pattern = r'.*[/\\](test|tool(s)?)[/\\].*'
base_function_pattern = r'ForTest(ing)?|for_test(ing)?' base_function_pattern = r'ForTest(ing)?|for_test(ing)?'
inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern) inclusion_pattern = input_api.re.compile(r'(%s)\s*\(' % base_function_pattern)
...@@ -59,8 +60,8 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api): ...@@ -59,8 +60,8 @@ def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api):
base_function_pattern, base_function_pattern)) base_function_pattern, base_function_pattern))
def FilterFile(affected_file): def FilterFile(affected_file):
black_list = ((file_exclusion_pattern, ) + _EXCLUDED_PATHS + black_list = ((file_exclusion_pattern, path_exclusion_pattern, ) +
input_api.DEFAULT_BLACK_LIST) _EXCLUDED_PATHS + input_api.DEFAULT_BLACK_LIST)
return input_api.FilterSourceFile( return input_api.FilterSourceFile(
affected_file, affected_file,
white_list=(file_inclusion_pattern, ), white_list=(file_inclusion_pattern, ),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment