Commit 3b09d5a1 authored by James Wallace-Lee's avatar James Wallace-Lee Committed by Commit Bot

WebView: suppress deprecation warnings

supress deprecation warnings on ZoomButtonsController and
WebIconDatabase

BUG=755922

Change-Id: I7b0f6769127b45245652afcd53615d2f2fcde985
Reviewed-on: https://chromium-review.googlesource.com/682997Reviewed-by: default avatarPaul Miller <paulmiller@chromium.org>
Reviewed-by: default avatarBo <boliu@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504192}
parent b02c0a23
...@@ -5,8 +5,6 @@ ...@@ -5,8 +5,6 @@
package com.android.webview.chromium; package com.android.webview.chromium;
import android.content.ContentResolver; import android.content.ContentResolver;
import android.webkit.WebIconDatabase;
import android.webkit.WebIconDatabase.IconListener;
import org.chromium.android_webview.AwContents; import org.chromium.android_webview.AwContents;
...@@ -14,7 +12,7 @@ import org.chromium.android_webview.AwContents; ...@@ -14,7 +12,7 @@ import org.chromium.android_webview.AwContents;
* Chromium implementation of WebIconDatabase -- big old no-op (base class is deprecated). * Chromium implementation of WebIconDatabase -- big old no-op (base class is deprecated).
*/ */
@SuppressWarnings("deprecation") @SuppressWarnings("deprecation")
final class WebIconDatabaseAdapter extends WebIconDatabase { final class WebIconDatabaseAdapter extends android.webkit.WebIconDatabase {
@Override @Override
public void open(String path) { public void open(String path) {
AwContents.setShouldDownloadFavicons(); AwContents.setShouldDownloadFavicons();
......
...@@ -9,34 +9,37 @@ import android.view.Gravity; ...@@ -9,34 +9,37 @@ import android.view.Gravity;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import android.widget.FrameLayout; import android.widget.FrameLayout;
import android.widget.ZoomButtonsController;
class AwZoomControls { class AwZoomControls {
private AwContents mAwContents; private AwContents mAwContents;
// It is advised to use getZoomController() where possible. // It is advised to use getZoomController() where possible.
private ZoomButtonsController mZoomButtonsController; @SuppressWarnings("deprecation")
private android.widget.ZoomButtonsController mZoomButtonsController;
AwZoomControls(AwContents awContents) { AwZoomControls(AwContents awContents) {
mAwContents = awContents; mAwContents = awContents;
} }
@SuppressWarnings("deprecation")
public void invokeZoomPicker() { public void invokeZoomPicker() {
ZoomButtonsController zoomController = getZoomController(); android.widget.ZoomButtonsController zoomController = getZoomController();
if (zoomController != null) { if (zoomController != null) {
zoomController.setVisible(true); zoomController.setVisible(true);
} }
} }
@SuppressWarnings("deprecation")
public void dismissZoomPicker() { public void dismissZoomPicker() {
ZoomButtonsController zoomController = getZoomController(); android.widget.ZoomButtonsController zoomController = getZoomController();
if (zoomController != null) { if (zoomController != null) {
zoomController.setVisible(false); zoomController.setVisible(false);
} }
} }
@SuppressWarnings("deprecation")
public void updateZoomControls() { public void updateZoomControls() {
ZoomButtonsController zoomController = getZoomController(); android.widget.ZoomButtonsController zoomController = getZoomController();
if (zoomController == null) { if (zoomController == null) {
return; return;
} }
...@@ -58,10 +61,11 @@ class AwZoomControls { ...@@ -58,10 +61,11 @@ class AwZoomControls {
} }
@SuppressLint("RtlHardcoded") @SuppressLint("RtlHardcoded")
private ZoomButtonsController getZoomController() { @SuppressWarnings("deprecation")
private android.widget.ZoomButtonsController getZoomController() {
if (mZoomButtonsController == null if (mZoomButtonsController == null
&& mAwContents.getSettings().shouldDisplayZoomControls()) { && mAwContents.getSettings().shouldDisplayZoomControls()) {
mZoomButtonsController = new ZoomButtonsController( mZoomButtonsController = new android.widget.ZoomButtonsController(
mAwContents.getContentViewCore().getContainerView()); mAwContents.getContentViewCore().getContainerView());
mZoomButtonsController.setOnZoomListener(new ZoomListener()); mZoomButtonsController.setOnZoomListener(new ZoomListener());
// ZoomButtonsController positions the buttons at the bottom, but in // ZoomButtonsController positions the buttons at the bottom, but in
...@@ -76,7 +80,8 @@ class AwZoomControls { ...@@ -76,7 +80,8 @@ class AwZoomControls {
return mZoomButtonsController; return mZoomButtonsController;
} }
private class ZoomListener implements ZoomButtonsController.OnZoomListener { @SuppressWarnings("deprecation")
private class ZoomListener implements android.widget.ZoomButtonsController.OnZoomListener {
@Override @Override
public void onVisibilityChanged(boolean visible) { public void onVisibilityChanged(boolean visible) {
if (visible) { if (visible) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment