Commit 3b2612ed authored by Eric Stevenson's avatar Eric Stevenson Committed by Commit Bot

JNI refactor: @NativeMethods conversion (//remoting).

This CL was generated by
//base/android/jni_generator/jni_refactorer.py.

Bug: 929661
Change-Id: Ib26cd65ad27cb8f339a701654e5b65d20559e5f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809497Reviewed-by: default avatarLambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697610}
parent 3900bde0
...@@ -11,6 +11,7 @@ import android.view.SurfaceHolder; ...@@ -11,6 +11,7 @@ import android.view.SurfaceHolder;
import org.chromium.base.annotations.CalledByNative; import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace; import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
import org.chromium.chromoting.DesktopView; import org.chromium.chromoting.DesktopView;
import org.chromium.chromoting.Event; import org.chromium.chromoting.Event;
import org.chromium.chromoting.InputFeedbackRadiusMapper; import org.chromium.chromoting.InputFeedbackRadiusMapper;
...@@ -55,7 +56,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -55,7 +56,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
@Override @Override
public void surfaceCreated(SurfaceHolder holder) { public void surfaceCreated(SurfaceHolder holder) {
if (mNativeJniGlDisplay != 0) { if (mNativeJniGlDisplay != 0) {
nativeOnSurfaceCreated(mNativeJniGlDisplay, holder.getSurface()); GlDisplayJni.get().onSurfaceCreated(
mNativeJniGlDisplay, GlDisplay.this, holder.getSurface());
} }
} }
...@@ -69,7 +71,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -69,7 +71,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) { public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) {
mOnClientSizeChanged.raise(new SizeChangedEventParameter(width, height)); mOnClientSizeChanged.raise(new SizeChangedEventParameter(width, height));
if (mNativeJniGlDisplay != 0) { if (mNativeJniGlDisplay != 0) {
nativeOnSurfaceChanged(mNativeJniGlDisplay, width, height); GlDisplayJni.get().onSurfaceChanged(mNativeJniGlDisplay, GlDisplay.this, width, height);
} }
} }
...@@ -79,7 +81,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -79,7 +81,7 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
@Override @Override
public void surfaceDestroyed(SurfaceHolder holder) { public void surfaceDestroyed(SurfaceHolder holder) {
if (mNativeJniGlDisplay != 0) { if (mNativeJniGlDisplay != 0) {
nativeOnSurfaceDestroyed(mNativeJniGlDisplay); GlDisplayJni.get().onSurfaceDestroyed(mNativeJniGlDisplay, GlDisplay.this);
} }
} }
...@@ -98,7 +100,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -98,7 +100,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
if (mNativeJniGlDisplay != 0) { if (mNativeJniGlDisplay != 0) {
float[] matrixArray = new float[9]; float[] matrixArray = new float[9];
matrix.getValues(matrixArray); matrix.getValues(matrixArray);
nativeOnPixelTransformationChanged(mNativeJniGlDisplay, matrixArray); GlDisplayJni.get().onPixelTransformationChanged(
mNativeJniGlDisplay, GlDisplay.this, matrixArray);
mScaleFactor = matrix.mapRadius(1); mScaleFactor = matrix.mapRadius(1);
} }
} }
...@@ -107,7 +110,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -107,7 +110,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
@Override @Override
public void moveCursor(PointF position) { public void moveCursor(PointF position) {
if (mNativeJniGlDisplay != 0) { if (mNativeJniGlDisplay != 0) {
nativeOnCursorPixelPositionChanged(mNativeJniGlDisplay, position.x, position.y); GlDisplayJni.get().onCursorPixelPositionChanged(
mNativeJniGlDisplay, GlDisplay.this, position.x, position.y);
} }
} }
...@@ -117,7 +121,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -117,7 +121,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
@Override @Override
public void setCursorVisibility(boolean visible) { public void setCursorVisibility(boolean visible) {
if (mNativeJniGlDisplay != 0) { if (mNativeJniGlDisplay != 0) {
nativeOnCursorVisibilityChanged(mNativeJniGlDisplay, visible); GlDisplayJni.get().onCursorVisibilityChanged(
mNativeJniGlDisplay, GlDisplay.this, visible);
} }
} }
...@@ -135,7 +140,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -135,7 +140,8 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
if (diameter <= 0.0f) { if (diameter <= 0.0f) {
return; return;
} }
nativeOnCursorInputFeedback(mNativeJniGlDisplay, pos.x, pos.y, diameter); GlDisplayJni.get().onCursorInputFeedback(
mNativeJniGlDisplay, GlDisplay.this, pos.x, pos.y, diameter);
} }
@Override @Override
...@@ -183,16 +189,19 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub { ...@@ -183,16 +189,19 @@ public class GlDisplay implements SurfaceHolder.Callback, RenderStub {
return new GlDisplay(nativeDisplayHandler); return new GlDisplay(nativeDisplayHandler);
} }
private native void nativeOnSurfaceCreated(long nativeJniGlDisplayHandler, Surface surface); @NativeMethods
private native void nativeOnSurfaceChanged(long nativeJniGlDisplayHandler, interface Natives {
int width, int height); void onSurfaceCreated(long nativeJniGlDisplayHandler, GlDisplay caller, Surface surface);
private native void nativeOnSurfaceDestroyed(long nativeJniGlDisplayHandler); void onSurfaceChanged(
private native void nativeOnPixelTransformationChanged(long nativeJniGlDisplayHandler, long nativeJniGlDisplayHandler, GlDisplay caller, int width, int height);
float[] matrix); void onSurfaceDestroyed(long nativeJniGlDisplayHandler, GlDisplay caller);
private native void nativeOnCursorPixelPositionChanged(long nativeJniGlDisplayHandler, void onPixelTransformationChanged(
float x, float y); long nativeJniGlDisplayHandler, GlDisplay caller, float[] matrix);
private native void nativeOnCursorInputFeedback(long nativeJniGlDisplayHandler, void onCursorPixelPositionChanged(
float x, float y, float diameter); long nativeJniGlDisplayHandler, GlDisplay caller, float x, float y);
private native void nativeOnCursorVisibilityChanged(long nativeJniGlDisplayHandler, void onCursorInputFeedback(
boolean visible); long nativeJniGlDisplayHandler, GlDisplay caller, float x, float y, float diameter);
void onCursorVisibilityChanged(
long nativeJniGlDisplayHandler, GlDisplay caller, boolean visible);
}
} }
...@@ -9,6 +9,7 @@ import android.content.Context; ...@@ -9,6 +9,7 @@ import android.content.Context;
import org.chromium.base.ContextUtils; import org.chromium.base.ContextUtils;
import org.chromium.base.Log; import org.chromium.base.Log;
import org.chromium.base.annotations.JNINamespace; import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
/** /**
* Initializes the Chromium remoting library, and provides JNI calls into it. * Initializes the Chromium remoting library, and provides JNI calls into it.
...@@ -33,9 +34,12 @@ public class JniInterface { ...@@ -33,9 +34,12 @@ public class JniInterface {
Log.w(TAG, "Couldn't load " + LIBRARY_NAME + ", trying " + LIBRARY_NAME + ".cr"); Log.w(TAG, "Couldn't load " + LIBRARY_NAME + ", trying " + LIBRARY_NAME + ".cr");
System.loadLibrary(LIBRARY_NAME + ".cr"); System.loadLibrary(LIBRARY_NAME + ".cr");
} }
nativeLoadNative(); JniInterfaceJni.get().loadNative();
} }
/** Performs the native portion of the initialization. */ @NativeMethods
private static native void nativeLoadNative(); interface Natives {
/** Performs the native portion of the initialization. */
void loadNative();
}
} }
...@@ -8,6 +8,7 @@ import org.chromium.base.ContextUtils; ...@@ -8,6 +8,7 @@ import org.chromium.base.ContextUtils;
import org.chromium.base.Log; import org.chromium.base.Log;
import org.chromium.base.annotations.CalledByNative; import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace; import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
import org.chromium.chromoting.Preconditions; import org.chromium.chromoting.Preconditions;
import org.chromium.chromoting.base.OAuthTokenFetcher; import org.chromium.chromoting.base.OAuthTokenFetcher;
import org.chromium.chromoting.base.OAuthTokenFetcher.Callback; import org.chromium.chromoting.base.OAuthTokenFetcher.Callback;
...@@ -46,7 +47,7 @@ public class JniOAuthTokenGetter { ...@@ -46,7 +47,7 @@ public class JniOAuthTokenGetter {
@Override @Override
public void onTokenFetched(String token) { public void onTokenFetched(String token) {
sLatestToken = token; sLatestToken = token;
nativeResolveOAuthTokenCallback( JniOAuthTokenGetterJni.get().resolveOAuthTokenCallback(
callbackPtr, OAuthTokenStatus.SUCCESS, sAccount, token); callbackPtr, OAuthTokenStatus.SUCCESS, sAccount, token);
} }
...@@ -67,7 +68,8 @@ public class JniOAuthTokenGetter { ...@@ -67,7 +68,8 @@ public class JniOAuthTokenGetter {
assert false : "Unreached"; assert false : "Unreached";
status = -1; status = -1;
} }
nativeResolveOAuthTokenCallback(callbackPtr, status, null, null); JniOAuthTokenGetterJni.get().resolveOAuthTokenCallback(
callbackPtr, status, null, null);
} }
}) })
.fetch(); .fetch();
...@@ -95,6 +97,9 @@ public class JniOAuthTokenGetter { ...@@ -95,6 +97,9 @@ public class JniOAuthTokenGetter {
.clearAndFetch(sLatestToken); .clearAndFetch(sLatestToken);
} }
private static native void nativeResolveOAuthTokenCallback( @NativeMethods
long callbackPtr, int status, String userEmail, String accessToken); interface Natives {
void resolveOAuthTokenCallback(
long callbackPtr, int status, String userEmail, String accessToken);
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment