Commit 3b29be96 authored by Rakib M. Hasan's avatar Rakib M. Hasan Committed by Chromium LUCI CQ

weblayer, skew tests: Add two separate gn argument sets to skew tests

mb_config.pyl

This Cl allows people to set the webview package name to
com.android.webview when compiling skew tests. This package name is
necessary on Android M and 10 x86 emulator builders.

Test: Compiled binaries locally using mb_config.pyl

Bug: 1163652
Change-Id: I968ab22359283caa9a5855f4b073df6ab5147b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628651Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#843669}
parent c26660de
...@@ -12,16 +12,20 @@ ...@@ -12,16 +12,20 @@
# builder to be used with mb.py for creating a zip archive of the WebLayer # builder to be used with mb.py for creating a zip archive of the WebLayer
# instrumentation tests. # instrumentation tests.
{ {
'masters': { 'builder_groups': {
'dummy.master': { 'dummy.group': {
'dummy.builder': 'android_release_bot_minimal_symbols_x86_webview_google', 'dummy.builder.google_webview_pkg_name': 'android_weblayer_with_google_webview_pkg_name',
}, 'dummy.builder.aosp_webview_pkg_name': 'android_weblayer_with_aosp_webview_pkg_name',
}
}, },
'configs': { 'configs': {
'android_release_bot_minimal_symbols_x86_webview_google': [ 'android_weblayer_with_aosp_webview_pkg_name': [
'android', 'release_bot', 'minimal_symbols', 'x86', 'android_release_bot_minimal_symbols_x86'
'strip_debug_info', 'webview_google', 'improved_debugging', ],
'android_weblayer_with_google_webview_pkg_name': [
'android_release_bot_minimal_symbols_x86_webview_google'
], ],
}, },
...@@ -36,6 +40,18 @@ ...@@ -36,6 +40,18 @@
'mixins': ['android_without_codecs', 'chrome_with_codecs'], 'mixins': ['android_without_codecs', 'chrome_with_codecs'],
}, },
# Default webview package name is com.android.webview which
# is necessary for skew tests to work on Android M and Anroid 10
# x86 builders.
'android_release_bot_minimal_symbols_x86': {
'mixins': ['android', 'release_bot', 'minimal_symbols', 'x86',
'strip_debug_info', 'improved_debugging'],
},
'android_release_bot_minimal_symbols_x86_webview_google': {
'mixins': ['android_release_bot_minimal_symbols_x86', 'webview_google'],
},
'android_without_codecs': { 'android_without_codecs': {
'gn_args': 'target_os="android"', 'gn_args': 'target_os="android"',
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment