Commit 3b3f3641 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

Migrate off BrowserThread::DeleteSoon in /chrome/browser/chromeos/extensions/file_manager

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=fukino@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I58d10f42096525ceb432d30ab59e74cdfa11d290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894889
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avatarNaoki Fukino <fukino@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712472}
parent 51f9ee37
......@@ -47,6 +47,7 @@
#include "components/drive/chromeos/search_metadata.h"
#include "components/drive/event_logger.h"
#include "components/signin/public/identity_manager/identity_manager.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/network_service_instance.h"
#include "content/public/browser/storage_partition.h"
......@@ -235,7 +236,7 @@ class SingleEntryPropertiesGetterForFileSystemProvider {
DCHECK(!callback_.is_null());
std::move(callback_).Run(std::move(properties_), result);
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);
base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, this);
}
// Given parameters.
......@@ -411,7 +412,7 @@ class SingleEntryPropertiesGetterForDriveFs {
std::move(callback_).Run(std::move(properties_),
drive::FileErrorToBaseFileError(error));
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);
base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, this);
}
// Given parameters.
......@@ -500,7 +501,7 @@ class SingleEntryPropertiesGetterForDocumentsProvider {
DCHECK(callback_);
std::move(callback_).Run(std::move(properties_), error);
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this);
base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, this);
}
// Given parameters.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment