Convert Callbacks to OnceCallbacks for //content/app/

Use OnceCallback where possible, and BindRepeating where it is
meant to be called more than once.

The Closure here was explicitly a RepeatingClosure in one place,
but it really should be a OnceClosure. The closure is used to
exit the RunLoop, which can't occur more than once. It is
currently not used at all.

R=jam@chromium.org

Bug: 953861
Change-Id: I8a6b2a36b10c8fe523d163cf26fccaa8b155a319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934785Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719186}

PRESUBMIT.py

@@ -389,7 +389,6 @@ _NOT_CONVERTED_TO_MODERN_BIND_AND_CALLBACK = '|'.join((
   '^components/webdata_services/',
   '^components/wifi/',
   '^components/zoom/',
-  '^content/app/',
   '^content/browser/',
   '^content/child/',
   '^content/public/',

content/app/content_service_manager_main_delegate.cc

@@ -111,10 +111,10 @@ void ContentServiceManagerMainDelegate::AdjustServiceProcessCommandLine(
 }
 
 void ContentServiceManagerMainDelegate::OnServiceManagerInitialized(
-    const base::Closure& quit_closure,
+    base::OnceClosure quit_closure,
     service_manager::BackgroundServiceManager* service_manager) {
   return content_main_params_.delegate->OnServiceManagerInitialized(
-      quit_closure, service_manager);
+      std::move(quit_closure), service_manager);
 }
 
 std::unique_ptr<service_manager::Service>

content/app/content_service_manager_main_delegate.h

@@ -37,7 +37,7 @@ class ContentServiceManagerMainDelegate : public service_manager::MainDelegate {
       const service_manager::Identity& identity,
       base::CommandLine* command_line) override;
   void OnServiceManagerInitialized(
-      const base::Closure& quit_closure,
+      base::OnceClosure quit_closure,
       service_manager::BackgroundServiceManager* service_manager) override;
   std::unique_ptr<service_manager::Service> CreateEmbeddedService(
       const std::string& service_name) override;

content/public/app/content_main_delegate.cc

@@ -64,7 +64,7 @@ void ContentMainDelegate::AdjustServiceProcessCommandLine(
     base::CommandLine* command_line) {}
 
 void ContentMainDelegate::OnServiceManagerInitialized(
-    const base::Closure& quit_closure,
+    base::OnceClosure quit_closure,
     service_manager::BackgroundServiceManager* service_manager) {}
 
 bool ContentMainDelegate::ShouldCreateFeatureList() {

content/public/app/content_main_delegate.h

@@ -118,7 +118,7 @@ class CONTENT_EXPORT ContentMainDelegate {
   // |quit_closure| is a callback the embedder may retain and invoke at any time
   // to cleanly terminate Service Manager execution.
   virtual void OnServiceManagerInitialized(
-      const base::Closure& quit_closure,
+      base::OnceClosure quit_closure,
       service_manager::BackgroundServiceManager* service_manager);
 
   // Allows the embedder to perform platform-specific initialization before

services/service_manager/embedder/main_delegate.cc

@@ -40,7 +40,7 @@ void MainDelegate::AdjustServiceProcessCommandLine(
     base::CommandLine* command_line) {}
 
 void MainDelegate::OnServiceManagerInitialized(
-    const base::RepeatingClosure& quit_closure,
+    base::OnceClosure quit_closure,
     BackgroundServiceManager* service_manager) {}
 
 std::unique_ptr<Service> MainDelegate::CreateEmbeddedService(

services/service_manager/embedder/main_delegate.h

@@ -96,7 +96,7 @@ class COMPONENT_EXPORT(SERVICE_MANAGER_EMBEDDER) MainDelegate {
   // |quit_closure| is a callback the embedder may retain and invoke at any time
   // to cleanly terminate Service Manager execution.
   virtual void OnServiceManagerInitialized(
-      const base::RepeatingClosure& quit_closure,
+      base::OnceClosure quit_closure,
       BackgroundServiceManager* service_manager);
 
   // Runs an embedded service by name. If the embedder does not know how to