Commit 3b58d069 authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Add trace metadata to detect albatross build

Albatross builds are official builds with DCHECK_ON.
Traces collected from these build are subject to performance
issues and should be tagger to ease filtering.

Change-Id: Idde7cde4a54ea867fce49b6f03d1557e7bec2030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323142
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: default avataroysteine <oysteine@chromium.org>
Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792592}
parent 55b149ad
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include "base/bind_helpers.h" #include "base/bind_helpers.h"
#include "base/command_line.h" #include "base/command_line.h"
#include "base/cpu.h" #include "base/cpu.h"
#include "base/dcheck_is_on.h"
#include "base/files/file_tracing.h" #include "base/files/file_tracing.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/run_loop.h" #include "base/run_loop.h"
...@@ -257,6 +258,10 @@ TracingControllerImpl::GenerateMetadataDict() { ...@@ -257,6 +258,10 @@ TracingControllerImpl::GenerateMetadataDict() {
#endif // defined(OS_ANDROID) #endif // defined(OS_ANDROID)
metadata_dict->SetInteger("chrome-bitness", 8 * sizeof(uintptr_t)); metadata_dict->SetInteger("chrome-bitness", 8 * sizeof(uintptr_t));
#if DCHECK_IS_ON()
metadata_dict->SetInteger("chrome-dcheck-on", 1);
#endif
// OS // OS
#if defined(OS_CHROMEOS) #if defined(OS_CHROMEOS)
metadata_dict->SetString("os-name", "CrOS"); metadata_dict->SetString("os-name", "CrOS");
......
...@@ -108,6 +108,7 @@ const AllowlistEntry kEventArgsAllowlist[] = { ...@@ -108,6 +108,7 @@ const AllowlistEntry kEventArgsAllowlist[] = {
{nullptr, nullptr, nullptr}}; {nullptr, nullptr, nullptr}};
const char* kMetadataAllowlist[] = {"chrome-bitness", const char* kMetadataAllowlist[] = {"chrome-bitness",
"chrome-dcheck-on",
"chrome-library-name", "chrome-library-name",
"clock-domain", "clock-domain",
"config", "config",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment