Commit 3b5a2867 authored by Ben Kelly's avatar Ben Kelly Committed by Commit Bot

Revert "CacheStorage: Enable the sequence feature by default."

This reverts commit 0dbcea96.

Reason for revert: Looking at additional histograms this feature
currently regressions response body read times due to extra thread
hops.  We should wait to launch until we can remove those thread
hops.

Original change's description:
> CacheStorage: Enable the sequence feature by default.
> 
> Bug: 960012
> Change-Id: Ia1c56eedf82376542b2d143692e133a173bd0653
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845856
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703738}

TBR=falken@chromium.org,rkaplow@chromium.org,wanderview@chromium.org

Change-Id: I0d3fb9c1ed8eea2e07b18082d5f8e92482d9b89c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 960012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849214Reviewed-by: default avatarBen Kelly <wanderview@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704160}
parent 9fd60e10
...@@ -28,7 +28,7 @@ namespace content { ...@@ -28,7 +28,7 @@ namespace content {
namespace { namespace {
const base::Feature kCacheStorageSequenceFeature{ const base::Feature kCacheStorageSequenceFeature{
"CacheStorageSequence", base::FEATURE_ENABLED_BY_DEFAULT}; "CacheStorageSequence", base::FEATURE_DISABLED_BY_DEFAULT};
scoped_refptr<base::SequencedTaskRunner> CreateSchedulerTaskRunner() { scoped_refptr<base::SequencedTaskRunner> CreateSchedulerTaskRunner() {
if (!base::FeatureList::IsEnabled(kCacheStorageSequenceFeature)) if (!base::FeatureList::IsEnabled(kCacheStorageSequenceFeature))
......
...@@ -1460,6 +1460,25 @@ ...@@ -1460,6 +1460,25 @@
] ]
} }
], ],
"CacheStorageSequence": [
{
"platforms": [
"windows",
"mac",
"chromeos",
"linux",
"android"
],
"experiments": [
{
"name": "Enabled1",
"enable_features": [
"CacheStorageSequence"
]
}
]
}
],
"CertDualVerificationTrial": [ "CertDualVerificationTrial": [
{ {
"platforms": [ "platforms": [
......
...@@ -158,6 +158,7 @@ crbug.com/856601 [ Linux ] virtual/feature-policy-permissions/external/wpt/media ...@@ -158,6 +158,7 @@ crbug.com/856601 [ Linux ] virtual/feature-policy-permissions/external/wpt/media
crbug.com/856601 [ Linux ] virtual/feature-policy-permissions/external/wpt/mediacapture-streams/idlharness.https.window.html [ Pass Timeout ] crbug.com/856601 [ Linux ] virtual/feature-policy-permissions/external/wpt/mediacapture-streams/idlharness.https.window.html [ Pass Timeout ]
crbug.com/856601 [ Linux ] virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Timeout Pass ] crbug.com/856601 [ Linux ] virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Timeout Pass ]
crbug.com/856601 [ Linux ] virtual/service-worker-servicification/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Timeout Pass ] crbug.com/856601 [ Linux ] virtual/service-worker-servicification/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Timeout Pass ]
crbug.com/856601 [ Linux ] virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Pass Timeout ]
crbug.com/856601 [ Linux ] virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Pass Failure Timeout ] crbug.com/856601 [ Linux ] virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/interfaces-sw.https.html [ Pass Failure Timeout ]
crbug.com/856601 [ Linux ] external/wpt/fetch/api/idl.any.sharedworker.html [ Pass Timeout ] crbug.com/856601 [ Linux ] external/wpt/fetch/api/idl.any.sharedworker.html [ Pass Timeout ]
crbug.com/856601 [ Linux ] external/wpt/fetch/cors-rfc1918/idlharness.tentative.https.any.serviceworker.html [ Pass Timeout ] crbug.com/856601 [ Linux ] external/wpt/fetch/cors-rfc1918/idlharness.tentative.https.any.serviceworker.html [ Pass Timeout ]
......
...@@ -1920,6 +1920,9 @@ virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event ...@@ -1920,6 +1920,9 @@ virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event
virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event-is-reload-navigation-manual.https.html [ WontFix ] virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event-is-reload-navigation-manual.https.html [ WontFix ]
virtual/omt-worker-fetch/external/wpt/xhr/send-authentication-existing-session-manual.htm [ WontFix ] virtual/omt-worker-fetch/external/wpt/xhr/send-authentication-existing-session-manual.htm [ WontFix ]
virtual/omt-worker-fetch/external/wpt/xhr/send-authentication-prompt-2-manual.htm [ WontFix ] virtual/omt-worker-fetch/external/wpt/xhr/send-authentication-prompt-2-manual.htm [ WontFix ]
virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-event-is-history-backward-navigation-manual.https.html [ WontFix ]
virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-event-is-history-forward-navigation-manual.https.html [ WontFix ]
virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-event-is-reload-navigation-manual.https.html [ WontFix ]
virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-abort-manual.https.html [ WontFix ] virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-abort-manual.https.html [ WontFix ]
virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-onerror-manual.https.html [ WontFix ] virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-onerror-manual.https.html [ WontFix ]
virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-onresult-manual.https.html [ WontFix ] virtual/speech-with-unified-autoplay/external/wpt/speech-api/SpeechRecognition-onresult-manual.https.html [ WontFix ]
......
...@@ -2951,6 +2951,7 @@ crbug.com/828506 [ Win ] virtual/scroll_customization/fast/events/touch/scroll-w ...@@ -2951,6 +2951,7 @@ crbug.com/828506 [ Win ] virtual/scroll_customization/fast/events/touch/scroll-w
# Failure messages are unstable so we cannot create baselines. # Failure messages are unstable so we cannot create baselines.
crbug.com/832071 external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ] crbug.com/832071 external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ]
crbug.com/832071 virtual/navigation-mojo-response/external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ] crbug.com/832071 virtual/navigation-mojo-response/external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ]
crbug.com/832071 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ]
crbug.com/832071 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ] crbug.com/832071 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/worker-client-id.https.html [ Failure ]
# failures in external/wpt/css/css-animations/ and web-animations/ from Mozilla tests # failures in external/wpt/css/css-animations/ and web-animations/ from Mozilla tests
...@@ -3283,6 +3284,7 @@ crbug.com/699040 external/wpt/svg/text/reftests/text-xml-space-001.svg [ Failure ...@@ -3283,6 +3284,7 @@ crbug.com/699040 external/wpt/svg/text/reftests/text-xml-space-001.svg [ Failure
crbug.com/626703 external/wpt/service-workers/service-worker/ready.https.html [ Timeout ] crbug.com/626703 external/wpt/service-workers/service-worker/ready.https.html [ Timeout ]
crbug.com/626703 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/ready.https.html [ Timeout ] crbug.com/626703 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/ready.https.html [ Timeout ]
crbug.com/626703 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/ready.https.html [ Timeout ] crbug.com/626703 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/ready.https.html [ Timeout ]
crbug.com/626703 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/ready.https.html [ Timeout ]
crbug.com/626703 [ Linux ] external/wpt/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html [ Failure ] crbug.com/626703 [ Linux ] external/wpt/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html [ Failure ]
crbug.com/626703 [ Mac ] external/wpt/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html [ Failure ] crbug.com/626703 [ Mac ] external/wpt/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html [ Failure ]
crbug.com/626703 [ Win ] external/wpt/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html [ Failure ] crbug.com/626703 [ Win ] external/wpt/css/css-fonts/math-script-level-and-math-style/math-script-level-auto-and-math-style-002.tentative.html [ Failure ]
...@@ -4435,11 +4437,13 @@ crbug.com/927477 external/wpt/import-maps/acquire-import-maps-flag/worker-reques ...@@ -4435,11 +4437,13 @@ crbug.com/927477 external/wpt/import-maps/acquire-import-maps-flag/worker-reques
crbug.com/691944 external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ] crbug.com/691944 external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ]
crbug.com/691944 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ] crbug.com/691944 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ]
crbug.com/691944 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ] crbug.com/691944 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ]
crbug.com/691944 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/update-after-oneday.https.html [ Skip ]
# These tests (erroneously) see a platform-specific User-Agent header # These tests (erroneously) see a platform-specific User-Agent header
crbug.com/595993 external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ] crbug.com/595993 external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ]
crbug.com/595993 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ] crbug.com/595993 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ]
crbug.com/595993 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ] crbug.com/595993 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ]
crbug.com/595993 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-header-visibility.https.html [ Failure ]
crbug.com/619427 [ Mac ] fast/overflow/overflow-height-float-not-removed-crash3.html [ Pass Failure ] crbug.com/619427 [ Mac ] fast/overflow/overflow-height-float-not-removed-crash3.html [ Pass Failure ]
...@@ -4697,6 +4701,7 @@ crbug.com/745079 external/wpt/geolocation-API/PositionOptions.https.html [ Failu ...@@ -4697,6 +4701,7 @@ crbug.com/745079 external/wpt/geolocation-API/PositionOptions.https.html [ Failu
# Service worker updates need to handle redirect appropriately. # Service worker updates need to handle redirect appropriately.
crbug.com/889798 external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ] crbug.com/889798 external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ]
crbug.com/889798 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ]
crbug.com/889798 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ] crbug.com/889798 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ]
crbug.com/889798 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ] crbug.com/889798 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/import-scripts-redirect.https.html [ Skip ]
...@@ -5264,6 +5269,8 @@ crbug.com/869773 http/tests/misc/window-dot-stop.html [ Pass Failure ] ...@@ -5264,6 +5269,8 @@ crbug.com/869773 http/tests/misc/window-dot-stop.html [ Pass Failure ]
crbug.com/873873 external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html [ Timeout Pass ] crbug.com/873873 external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html [ Timeout Pass ]
crbug.com/873873 external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html [ Timeout Pass ] crbug.com/873873 external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html [ Timeout Pass ]
crbug.com/873873 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video.https.html [ Timeout Pass ]
crbug.com/873873 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html [ Timeout Pass ]
crbug.com/875884 [ Linux ] lifecycle/background-change-lifecycle-count.html [ Pass Failure ] crbug.com/875884 [ Linux ] lifecycle/background-change-lifecycle-count.html [ Pass Failure ]
crbug.com/875884 [ Win ] lifecycle/background-change-lifecycle-count.html [ Pass Failure ] crbug.com/875884 [ Win ] lifecycle/background-change-lifecycle-count.html [ Pass Failure ]
...@@ -5582,6 +5589,7 @@ crbug.com/931646 [ Win7 ] http/tests/preload/meta-viewport-link-headers-imagesrc ...@@ -5582,6 +5589,7 @@ crbug.com/931646 [ Win7 ] http/tests/preload/meta-viewport-link-headers-imagesrc
crbug.com/933880 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ] crbug.com/933880 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/933880 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ] crbug.com/933880 virtual/omt-service-worker-startup/external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/933880 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ] crbug.com/933880 virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/933880 virtual/cache-storage-sequence/external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ]
# This passes in content_shell but not in chrome with network service disabled, # This passes in content_shell but not in chrome with network service disabled,
......
...@@ -1089,6 +1089,11 @@ ...@@ -1089,6 +1089,11 @@
"base": "external/wpt/css/css-properties-values-api", "base": "external/wpt/css/css-properties-values-api",
"args": ["--enable-blink-features=CSSVariables2AtProperty"] "args": ["--enable-blink-features=CSSVariables2AtProperty"]
}, },
{
"prefix": "cache-storage-sequence",
"base": "external/wpt/service-workers",
"args": ["--disable-features=CacheStorageSequence"]
},
{ {
"prefix": "conditional-appcache-delay", "prefix": "conditional-appcache-delay",
"base": "http/tests/loading/appcache-delay", "base": "http/tests/loading/appcache-delay",
......
This suite runs the ServiceWorker and CacheStorage tests with the
CacheStorageSequence feature disabled. This makes CacheStorage operate on
the IO thread in the browser process.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment