Commit 3b6d3a80 authored by Jared Saul's avatar Jared Saul Committed by Commit Bot

[AF] Update histograms.xml for FidoAuthentication strike database

The FidoAuthenticationStrikeDatabase was added in
https://chromium-review.googlesource.com/c/chromium/src/+/1824362.
However, the "Autofill.StrikeDatabase.NthStrikeAdded" and
"Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired" histograms
are part of strike_database_integrator_base.cc, which all
project-specific Autofill strike databases inherit from.
As a result, CL 1824362 missed updating histograms.xml at the time,
since it was the superclass doing new automatic logging.

Change-Id: Ie791e52dfd51139986553e29230ad23960ee46f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437018
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811896}
parent 550421ea
...@@ -1514,25 +1514,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1514,25 +1514,15 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary> </summary>
</histogram> </histogram>
<histogram name="Autofill.StrikeDatabase.NthStrikeAdded.CreditCardSave" <histogram name="Autofill.StrikeDatabase.NthStrikeAdded" units="strikes"
units="strikes" expires_after="2021-01-31"> expires_after="2021-01-31">
<owner>jsaul@google.com</owner> <!-- Name completed by histogram_suffixes name="AutofillStrikeDatabaseProjectType" -->
<owner>annelim@google.com</owner>
<summary>
Records the number of &quot;strikes&quot; a given card has, when a user
dismisses a prompt to save a new credit card. The strike count is
incremented each time the user dismisses the prompt.
</summary>
</histogram>
<histogram name="Autofill.StrikeDatabase.NthStrikeAdded.LocalCardMigration"
units="strikes" expires_after="2021-01-31">
<owner>jsaul@google.com</owner> <owner>jsaul@google.com</owner>
<owner>annelim@google.com</owner> <owner>annelim@google.com</owner>
<summary> <summary>
Records the number of &quot;strikes&quot; a user has, when a prompt for Records the number of &quot;strikes&quot; a particular feature has when a
local card migration is dismissed. The strike count is incremented each time new strike is added for that feature.
the user dismisses the prompt.
</summary> </summary>
</histogram> </histogram>
...@@ -1579,6 +1569,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1579,6 +1569,8 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired" <histogram name="Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired"
units="strikes" expires_after="2021-01-31"> units="strikes" expires_after="2021-01-31">
<!-- Name completed by histogram_suffixes name="AutofillStrikeDatabaseProjectType" -->
<owner>jsaul@google.com</owner> <owner>jsaul@google.com</owner>
<owner>annelim@google.com</owner> <owner>annelim@google.com</owner>
<summary> <summary>
......
...@@ -1503,9 +1503,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -1503,9 +1503,12 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<affected-histogram name="Autofill.StoredServerCreditCardCount"/> <affected-histogram name="Autofill.StoredServerCreditCardCount"/>
</histogram_suffixes> </histogram_suffixes>
<histogram_suffixes name="AutofillStrikesExpiredProjectType" separator="."> <histogram_suffixes name="AutofillStrikeDatabaseProjectType" separator=".">
<suffix name="CreditCardSave" label="Credit card save"/> <suffix name="CreditCardSave" label="Credit card save"/>
<suffix name="FidoAuthentication"
label="Fido authentication (Better Auth Project)"/>
<suffix name="LocalCardMigration" label="Local card migration"/> <suffix name="LocalCardMigration" label="Local card migration"/>
<affected-histogram name="Autofill.StrikeDatabase.NthStrikeAdded"/>
<affected-histogram <affected-histogram
name="Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired"/> name="Autofill.StrikeDatabase.StrikesPresentWhenStrikeExpired"/>
</histogram_suffixes> </histogram_suffixes>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment