Record OpenInNewTab and OpenAction from bottom sheet

A server change caused us to fail to compute the index
of the card when the action originates from the bottom sheet.
This change lets us continue to record metrics even if we
don't identify the card index, using MAX_INT as a special
value.

While this fix isn't ideal, it's better than missing out
on these metrics. We can improve this later.

Bug: 1111101
Change-Id: I063835a44ad4abb92f05e997fd27c535dc4dcb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522574
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825987}

components/feed/core/v2/feed_stream.cc

@@ -710,16 +710,18 @@ void FeedStream::UnloadModel() {
 
 void FeedStream::ReportOpenAction(const std::string& slice_id) {
   int index = surface_updater_->GetSliceIndexFromSliceId(slice_id);
-  if (index >= 0)
-    metrics_reporter_->OpenAction(index);
+  if (index < 0)
+    index = MetricsReporter::kUnknownCardIndex;
+  metrics_reporter_->OpenAction(index);
 }
 void FeedStream::ReportOpenVisitComplete(base::TimeDelta visit_time) {
   metrics_reporter_->OpenVisitComplete(visit_time);
 }
 void FeedStream::ReportOpenInNewTabAction(const std::string& slice_id) {
   int index = surface_updater_->GetSliceIndexFromSliceId(slice_id);
-  if (index >= 0)
-    metrics_reporter_->OpenInNewTabAction(index);
+  if (index < 0)
+    index = MetricsReporter::kUnknownCardIndex;
+  metrics_reporter_->OpenInNewTabAction(index);
 }
 void FeedStream::ReportOpenInNewIncognitoTabAction() {
   metrics_reporter_->OpenInNewIncognitoTabAction();

components/feed/core/v2/metrics_reporter.h

@@ -5,6 +5,7 @@
 #ifndef COMPONENTS_FEED_CORE_V2_METRICS_REPORTER_H_
 #define COMPONENTS_FEED_CORE_V2_METRICS_REPORTER_H_
 
+#include <climits>
 #include <map>
 
 #include "base/memory/weak_ptr.h"
@@ -61,6 +62,11 @@ enum class FeedUserActionType {
 // Note this is inherited only for testing.
 class MetricsReporter {
  public:
+  // For 'index_in_stream' parameters, when the card index is unknown.
+  // This is most likely to happen when the action originates from the bottom
+  // sheet.
+  static const int kUnknownCardIndex = INT_MAX;
+
   explicit MetricsReporter(const base::TickClock* clock,
                            PrefService* profile_prefs);
   virtual ~MetricsReporter();