Commit 3bdd7fe1 authored by Bettina's avatar Bettina Committed by Commit Bot

Make chrome://reset-password always available.

Bug: 949584
Change-Id: I10b682f9f0f9a7b558c2a9bf31eaf122a38c62e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565388Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Reviewed-by: default avatarNathan Parker <nparker@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#650540}
parent 8971b614
...@@ -231,9 +231,7 @@ ...@@ -231,9 +231,7 @@
#endif #endif
#if defined(FULL_SAFE_BROWSING) #if defined(FULL_SAFE_BROWSING)
#include "chrome/browser/safe_browsing/chrome_password_protection_service.h"
#include "chrome/browser/ui/webui/reset_password/reset_password_ui.h" #include "chrome/browser/ui/webui/reset_password/reset_password_ui.h"
#include "components/safe_browsing/features.h"
#endif #endif
using content::WebUI; using content::WebUI;
...@@ -702,13 +700,7 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui, ...@@ -702,13 +700,7 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
} }
#if defined(FULL_SAFE_BROWSING) #if defined(FULL_SAFE_BROWSING)
bool enable_reset_password = if (url.host_piece() == chrome::kChromeUIResetPasswordHost) {
base::FeatureList::IsEnabled(
safe_browsing::kForceEnableResetPasswordWebUI) ||
safe_browsing::ChromePasswordProtectionService::
IsPasswordReuseProtectionConfigured(profile);
if (url.host_piece() == chrome::kChromeUIResetPasswordHost &&
enable_reset_password) {
return &NewWebUI<ResetPasswordUI>; return &NewWebUI<ResetPasswordUI>;
} }
#endif #endif
......
...@@ -35,9 +35,6 @@ const base::Feature kCheckByURLLoaderThrottle{ ...@@ -35,9 +35,6 @@ const base::Feature kCheckByURLLoaderThrottle{
const base::Feature kCommittedSBInterstitials{ const base::Feature kCommittedSBInterstitials{
"SafeBrowsingCommittedInterstitials", base::FEATURE_DISABLED_BY_DEFAULT}; "SafeBrowsingCommittedInterstitials", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kForceEnableResetPasswordWebUI{
"ForceEnableResetPasswordWebUI", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kPasswordProtectionForSignedInUsers{ const base::Feature kPasswordProtectionForSignedInUsers{
"SafeBrowsingPasswordProtectionForSignedInUsers", "SafeBrowsingPasswordProtectionForSignedInUsers",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
...@@ -79,7 +76,6 @@ constexpr struct { ...@@ -79,7 +76,6 @@ constexpr struct {
{&kAdSamplerTriggerFeature, false}, {&kAdSamplerTriggerFeature, false},
{&kCheckByURLLoaderThrottle, true}, {&kCheckByURLLoaderThrottle, true},
{&kCommittedSBInterstitials, true}, {&kCommittedSBInterstitials, true},
{&kForceEnableResetPasswordWebUI, true},
{&kPasswordProtectionForSignedInUsers, true}, {&kPasswordProtectionForSignedInUsers, true},
{&kSuspiciousSiteTriggerQuotaFeature, true}, {&kSuspiciousSiteTriggerQuotaFeature, true},
{&kTelemetryForApkDownloads, true}, {&kTelemetryForApkDownloads, true},
......
...@@ -27,10 +27,6 @@ extern const base::Feature kCheckByURLLoaderThrottle; ...@@ -27,10 +27,6 @@ extern const base::Feature kCheckByURLLoaderThrottle;
// navigations instead of overlays. // navigations instead of overlays.
extern const base::Feature kCommittedSBInterstitials; extern const base::Feature kCommittedSBInterstitials;
// Forces the chrome://reset-password page to be shown for review or testing
// purpose.
extern const base::Feature kForceEnableResetPasswordWebUI;
// Enable GAIA password protection for signed-in users. // Enable GAIA password protection for signed-in users.
extern const base::Feature kPasswordProtectionForSignedInUsers; extern const base::Feature kPasswordProtectionForSignedInUsers;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment