Direct Sockets: Support to resolve hostname.

Implements class DirectSocketsServiceImpl::ResolveHostAndOpenSocket to
finish the resolution of remote hostname.

This job is performed asynchronously.

Below documents are from Eric Willigers <ericwilligers@chromium.org>.
Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md

Design doc:
https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing

Bug: 905818
Change-Id: Ie040b0b1dc05025030df74b3e81663c94377c2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603775
Commit-Queue: Ke He <kehe@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839845}

content/browser/direct_sockets/direct_sockets_browsertest.cc

@@ -35,10 +35,8 @@ namespace content {
 
 namespace {
 
-enum class ProtocolType { kTcp, kUdp };
-
 struct RecordedCall {
-  ProtocolType protocol_type;
+  DirectSocketsServiceImpl::ProtocolType protocol_type;
 
   std::string remote_address;
   uint16_t remote_port;
@@ -65,8 +63,8 @@ class MockNetworkContext : public network::TestNetworkContext {
       mojo::PendingRemote<network::mojom::SocketObserver> observer,
       CreateTCPConnectedSocketCallback callback) override {
     history_.push_back(RecordedCall{
-        ProtocolType::kTcp, remote_addr_list[0].address().ToString(),
-        remote_addr_list[0].port(),
+        DirectSocketsServiceImpl::ProtocolType::kTcp,
+        remote_addr_list[0].address().ToString(), remote_addr_list[0].port(),
         tcp_connected_socket_options->send_buffer_size,
         tcp_connected_socket_options->receive_buffer_size,
         tcp_connected_socket_options->no_delay});
@@ -82,11 +80,8 @@ class MockNetworkContext : public network::TestNetworkContext {
 };
 
 net::Error UnconditionallyPermitConnection(
-    const blink::mojom::DirectSocketOptions& options,
-    net::IPAddress& remote_address) {
+    const blink::mojom::DirectSocketOptions& options) {
   DCHECK(options.remote_hostname.has_value());
-  DCHECK(remote_address.AssignFromIPLiteral(*options.remote_hostname));
-  EXPECT_EQ(remote_address.ToString(), *options.remote_hostname);
   return net::OK;
 }
 
@@ -162,15 +157,14 @@ IN_PROC_BROWSER_TEST_F(DirectSocketsBrowserTest, DISABLED_OpenTcp_Success) {
   EXPECT_EQ("openTcp succeeded", EvalJs(shell(), script));
 }
 
-IN_PROC_BROWSER_TEST_F(DirectSocketsBrowserTest, OpenTcp_NotAllowedError) {
+IN_PROC_BROWSER_TEST_F(DirectSocketsBrowserTest, OpenTcp_Success_Global) {
   EXPECT_TRUE(NavigateToURL(shell(), GetTestPageURL()));
 
   const uint16_t listening_port = StartTcpServer();
   const std::string script = base::StringPrintf(
       "openTcp({remoteAddress: '127.0.0.1', remotePort: %d})", listening_port);
 
-  EXPECT_EQ("openTcp failed: NotAllowedError: Permission denied",
-            EvalJs(shell(), script));
+  EXPECT_EQ("openTcp succeeded", EvalJs(shell(), script));
 }
 
 IN_PROC_BROWSER_TEST_F(DirectSocketsBrowserTest, OpenTcp_CannotEvadeCors) {
@@ -210,7 +204,7 @@ IN_PROC_BROWSER_TEST_F(DirectSocketsBrowserTest, DISABLED_OpenTcp_OptionsOne) {
 
   DCHECK_EQ(1U, mock_network_context.history().size());
   const RecordedCall& call = mock_network_context.history()[0];
-  EXPECT_EQ(ProtocolType::kTcp, call.protocol_type);
+  EXPECT_EQ(DirectSocketsServiceImpl::ProtocolType::kTcp, call.protocol_type);
   EXPECT_EQ("12.34.56.78", call.remote_address);
   EXPECT_EQ(9012, call.remote_port);
   EXPECT_EQ(3456, call.send_buffer_size);
@@ -243,7 +237,7 @@ IN_PROC_BROWSER_TEST_F(DirectSocketsBrowserTest, DISABLED_OpenTcp_OptionsTwo) {
 
   DCHECK_EQ(1U, mock_network_context.history().size());
   const RecordedCall& call = mock_network_context.history()[0];
-  EXPECT_EQ(ProtocolType::kTcp, call.protocol_type);
+  EXPECT_EQ(DirectSocketsServiceImpl::ProtocolType::kTcp, call.protocol_type);
   EXPECT_EQ("fedc:ba98:7654:3210:fedc:ba98:7654:3210", call.remote_address);
   EXPECT_EQ(789, call.remote_port);
   EXPECT_EQ(0, call.send_buffer_size);

content/browser/direct_sockets/direct_sockets_service_impl.h

@@ -29,8 +29,10 @@ class CONTENT_EXPORT DirectSocketsServiceImpl
     : public blink::mojom::DirectSocketsService,
       public WebContentsObserver {
  public:
-  using PermissionCallback = base::RepeatingCallback<
-      net::Error(const blink::mojom::DirectSocketOptions&, net::IPAddress&)>;
+  enum class ProtocolType { kTcp, kUdp };
+
+  using PermissionCallback = base::RepeatingCallback<net::Error(
+      const blink::mojom::DirectSocketOptions&)>;
 
   explicit DirectSocketsServiceImpl(RenderFrameHost& frame_host);
   ~DirectSocketsServiceImpl() override = default;
@@ -63,17 +65,17 @@ class CONTENT_EXPORT DirectSocketsServiceImpl
 
   static void SetNetworkContextForTesting(network::mojom::NetworkContext*);
 
+  static void PopulateLocalAddrForTesting(
+      const blink::mojom::DirectSocketOptions& options,
+      base::Optional<net::IPEndPoint>& local_addr);
+
  private:
   friend class DirectSocketsUnitTest;
 
-  // Returns net::OK and populates |remote_address| if the options are valid and
-  // the connection is permitted.
-  net::Error ValidateOptions(const blink::mojom::DirectSocketOptions& options,
-                             net::IPAddress& remote_address);
+  class ResolveHostAndOpenSocket;
 
-  // Populate |local_addr| from options.
-  void PopulateLocalAddr(const blink::mojom::DirectSocketOptions& options,
-                         base::Optional<net::IPEndPoint>& local_addr);
+  // Returns net::OK if the options are valid and the connection is permitted.
+  net::Error ValidateOptions(const blink::mojom::DirectSocketOptions& options);
 
   network::mojom::NetworkContext* GetNetworkContext();
 

content/browser/direct_sockets/direct_sockets_unittest.cc

@@ -32,13 +32,12 @@ class DirectSocketsUnitTest : public RenderViewHostTestHarness {
   }
 
   net::Error ValidateOptions(const blink::mojom::DirectSocketOptions& options) {
-    net::IPAddress remote_address;
-    return direct_sockets_service().ValidateOptions(options, remote_address);
+    return direct_sockets_service().ValidateOptions(options);
   }
 
   void PopulateLocalAddr(const blink::mojom::DirectSocketOptions& options,
                          base::Optional<net::IPEndPoint>& local_addr) {
-    return direct_sockets_service().PopulateLocalAddr(options, local_addr);
+    DirectSocketsServiceImpl::PopulateLocalAddrForTesting(options, local_addr);
   }
 
  private:

third_party/blink/renderer/modules/direct_sockets/tcp_readable_stream_wrapper.cc

@@ -86,6 +86,7 @@ TCPReadableStreamWrapper::TCPReadableStreamWrapper(
       WTF::BindRepeating(&TCPReadableStreamWrapper::OnPeerClosed,
                          WrapWeakPersistent(this)));
 
+  ScriptState::Scope scope(script_state_);
   // Set queuing strategy of default behavior with a high water mark of 1.
   readable_ = ReadableStream::CreateWithCountQueueingStrategy(
       script_state_,

third_party/blink/renderer/modules/direct_sockets/tcp_writable_stream_wrapper.cc

@@ -122,6 +122,7 @@ TCPWritableStreamWrapper::TCPWritableStreamWrapper(
       WTF::BindRepeating(&TCPWritableStreamWrapper::OnPeerClosed,
                          WrapWeakPersistent(this)));
 
+  ScriptState::Scope scope(script_state_);
   // Set the CountQueueingStrategy's high water mark as 1 to make the logic of
   // |WriteOrCacheData| much simpler
   writable_ = WritableStream::CreateWithCountQueueingStrategy(