Commit 3bf7948f authored by Yi Gu's avatar Yi Gu Committed by Commit Bot

Update VizHitTesting related TODOs with linked bugs

The TODOs are now assigned to the linked bugs.

Bug: None
Change-Id: I92ee6368f1d9b730c9cc31d204d716c0c2c30f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225291
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774639}
parent ffa06f45
...@@ -224,8 +224,8 @@ bool HitTestQuery::FindTargetInRegionForLocation( ...@@ -224,8 +224,8 @@ bool HitTestQuery::FindTargetInRegionForLocation(
// hit test data, e.g. overlapped by ShelfApp on ChromeOS. // hit test data, e.g. overlapped by ShelfApp on ChromeOS.
// The kHitTestAsk flag should be ignored in such a case because there is no // The kHitTestAsk flag should be ignored in such a case because there is no
// need to do async hit testing on the root merely because it was overlapped. // need to do async hit testing on the root merely because it was overlapped.
// TODO(yigu): Do not set the kHitTestAsk and kOverlappedRegion flags for // TODO(crbug.com/1001238): Do not set the kHitTestAsk and kOverlappedRegion
// root when building hit test data. // flags for root when building hit test data.
bool root_view_overlapped = bool root_view_overlapped =
hit_test_data_[region_index].frame_sink_id == root_view_frame_sink_id && hit_test_data_[region_index].frame_sink_id == root_view_frame_sink_id &&
hit_test_data_[region_index].async_hit_test_reasons == hit_test_data_[region_index].async_hit_test_reasons ==
......
...@@ -471,10 +471,9 @@ RenderWidgetTargetResult RenderWidgetHostInputEventRouter::FindMouseEventTarget( ...@@ -471,10 +471,9 @@ RenderWidgetTargetResult RenderWidgetHostInputEventRouter::FindMouseEventTarget(
// the OOPIF renderer. Instead of using the coordinate transformation in the // the OOPIF renderer. Instead of using the coordinate transformation in the
// browser process process, use the cached coordinates that were determined // browser process process, use the cached coordinates that were determined
// by the renderer process on the previous MouseDown. // by the renderer process on the previous MouseDown.
// TODO(yigu): Currently there is a mismatch between the coordinate // TODO(crbug.com/989109): Currently there is a mismatch between the
// transforms from browser process and renderer process. We need to fix it // coordinate transforms from browser process and renderer process. We need
// so that we don't need to cache the transform from MouseDown. // to fix it so that we don't need to cache the transform from MouseDown.
// https://crbug.com/934434.
if (event.GetType() == blink::WebInputEvent::Type::kMouseUp && if (event.GetType() == blink::WebInputEvent::Type::kMouseUp &&
target == last_mouse_down_target_ && target == last_mouse_down_target_ &&
mouse_down_pre_transformed_coordinate_ == event.PositionInWidget()) { mouse_down_pre_transformed_coordinate_ == event.PositionInWidget()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment