Commit 3bfec153 authored by Ted Meyer's avatar Ted Meyer Committed by Commit Bot

Remove NotifyError calls and just send a normal message instead

rewrote the TODO as well.

Bug: 1088055
Change-Id: If83ceeb3a786a1813e41bd3ac6c7309791e92400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223010
Auto-Submit: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773776}
parent c3d5c0d1
...@@ -165,13 +165,11 @@ void DecoderSelector<StreamType>::OnDecoderInitializeDone(Status status) { ...@@ -165,13 +165,11 @@ void DecoderSelector<StreamType>::OnDecoderInitializeDone(Status status) {
DCHECK(task_runner_->BelongsToCurrentThread()); DCHECK(task_runner_->BelongsToCurrentThread());
if (!status.is_ok()) { if (!status.is_ok()) {
// TODO(tmathmeyer) this might be noisy in media log. Consider batching // TODO(tmathmeyer) this was too noisy in media log. Batch all the logs
// all failures as causes to a single Status object and only surfacing it if // together and then send them as an informational notice instead of
// decoder selection fails entirely. // using NotifyError.
media_log_->NotifyError( MEDIA_LOG(INFO, media_log_)
Status(StatusCode::kDecoderFailedInitialization) << "Failed to initialize " << decoder_->GetDisplayName();
.WithData("Decoder name", decoder_->GetDisplayName())
.AddCause(std::move(status)));
// Try the next decoder on the list. // Try the next decoder on the list.
decoder_.reset(); decoder_.reset();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment