[CrOS Settings] Add recordSettingChange() metric in internet settings

This CL adds user action recordSettingChange() calls in instances in
OS settings related to the internet page settings that the user
can change.

Bug: 1049830
Change-Id: Id35a02c3c9fb58660061e243348f0633109fc873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063261Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743334}

chrome/browser/resources/settings/chromeos/internet_page/BUILD.gn

@@ -23,6 +23,7 @@ js_library("internet_page") {
   deps = [
     ":internet_config",
     ":internet_page_browser_proxy",
+    "..:metrics_recorder",
     "..:os_route",
     "../..:router",
     "../../settings_page:settings_animated_pages",
@@ -47,6 +48,7 @@ js_library("internet_page_browser_proxy") {
 
 js_library("internet_config") {
   deps = [
+    "..:metrics_recorder",
     "../..:router",
     "//ui/webui/resources/cr_components/chromeos/network:network_config",
     "//ui/webui/resources/cr_elements/cr_dialog:cr_dialog",
@@ -62,6 +64,7 @@ js_library("internet_detail_page") {
   deps = [
     ":internet_page_browser_proxy",
     ":tether_connection_dialog",
+    "..:metrics_recorder",
     "..:os_route",
     "../..:router",
     "//ui/webui/resources/cr_components/chromeos/network:network_listener_behavior",
@@ -78,6 +81,7 @@ js_library("internet_detail_page") {
 
 js_library("internet_known_networks_page") {
   deps = [
+    "..:metrics_recorder",
     "//ui/webui/resources/cr_components/chromeos/network:network_listener_behavior",
     "//ui/webui/resources/cr_elements/cr_action_menu:cr_action_menu",
     "//ui/webui/resources/cr_elements/policy:cr_policy_network_behavior_mojo",
@@ -90,6 +94,7 @@ js_library("internet_known_networks_page") {
 js_library("internet_subpage") {
   deps = [
     ":internet_page_browser_proxy",
+    "..:metrics_recorder",
     "..:os_route",
     "..:route_origin_behavior",
     "../..:router",

chrome/browser/resources/settings/chromeos/internet_page/internet_config.html

@@ -5,6 +5,7 @@
 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="internet_shared_css.html">
 
 <dom-module id="internet-config">

chrome/browser/resources/settings/chromeos/internet_page/internet_config.js

@@ -122,10 +122,12 @@ Polymer({
   /** @private */
   onSaveTap_() {
     this.$.networkConfig.save();
+    settings.recordSettingChange();
   },
 
   /** @private */
   onConnectTap_() {
     this.$.networkConfig.connect();
+    settings.recordSettingChange();
   },
 });

chrome/browser/resources/settings/chromeos/internet_page/internet_detail_page.html

@@ -27,6 +27,7 @@
 <link rel="import" href="../../prefs/prefs.html">
 <link rel="import" href="../os_route.html">
 <link rel="import" href="../../router.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="internet_page_browser_proxy.html">
 <link rel="import" href="internet_shared_css.html">
 <link rel="import" href="network_proxy_section.html">

chrome/browser/resources/settings/chromeos/internet_page/internet_detail_page.js

@@ -594,6 +594,7 @@ Polymer({
         this.getNetworkDetails_();
       }
     });
+    settings.recordSettingChange();
   },
 
   /**
@@ -1095,6 +1096,7 @@ Polymer({
     this.fire(
         'network-connect',
         {networkState: networkState, bypassConnectionDialog: bypassDialog});
+    settings.recordSettingChange();
   },
 
   /** @private */
@@ -1104,6 +1106,7 @@ Polymer({
         console.error('Disconnect failed for: ' + this.guid);
       }
     });
+    settings.recordSettingChange();
   },
 
   /** @private */
@@ -1172,6 +1175,7 @@ Polymer({
       // A forgotten network no longer has a valid GUID, close the subpage.
       this.close();
     });
+    settings.recordSettingChange();
   },
 
   /** @private */
@@ -1185,6 +1189,7 @@ Polymer({
         (this.isThirdPartyVpn_(this.managedProperties_) ||
          this.isArcVpn_(this.managedProperties_))) {
       this.browserProxy_.configureThirdPartyVpn(this.guid);
+      settings.recordSettingChange();
       return;
     }
 
@@ -1403,6 +1408,7 @@ Polymer({
     }
 
     this.preferNetwork_ = !this.preferNetwork_;
+    settings.recordSettingChange();
   },
 
   /**

chrome/browser/resources/settings/chromeos/internet_page/internet_known_networks_page.html

@@ -7,6 +7,7 @@
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_network_behavior_mojo.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 
 <dom-module id="settings-internet-known-networks-page">
   <template>

chrome/browser/resources/settings/chromeos/internet_page/internet_known_networks_page.js

@@ -186,6 +186,7 @@ Polymer({
                 JSON.stringify(config));
           }
         });
+    settings.recordSettingChange();
   },
 
   /** @private */
@@ -213,6 +214,7 @@ Polymer({
         console.error('Froget network failed for: ' + this.selectedGuid_);
       }
     });
+    settings.recordSettingChange();
     /** @type {!CrActionMenuElement} */ (this.$.dotsMenu).close();
   },
 

chrome/browser/resources/settings/chromeos/internet_page/internet_page.html

@@ -17,6 +17,7 @@
 <link rel="import" href="../../settings_page/settings_animated_pages.html">
 <link rel="import" href="../../settings_page/settings_subpage.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 <link rel="import" href="internet_config.html">
 <link rel="import" href="internet_detail_page.html">
 <link rel="import" href="internet_known_networks_page.html">

chrome/browser/resources/settings/chromeos/internet_page/internet_page.js

@@ -237,6 +237,7 @@ Polymer({
   onDeviceEnabledToggled_(event) {
     this.networkConfig_.setNetworkTypeEnabledState(
         event.detail.type, event.detail.enabled);
+    settings.recordSettingChange();
   },
 
   /**
@@ -419,6 +420,7 @@ Polymer({
   onAddThirdPartyVpnTap_(event) {
     const provider = event.model.item;
     this.browserProxy_.addThirdPartyVpn(provider.appId);
+    settings.recordSettingChange();
   },
 
   /**

chrome/browser/resources/settings/chromeos/internet_page/internet_subpage.html

@@ -19,6 +19,7 @@
 <link rel="import" href="../../router.html">
 <link rel="import" href="../route_origin_behavior.html">
 <link rel="import" href="../../settings_shared_css.html">
+<link rel="import" href="../metrics_recorder.html">
 
 <dom-module id="settings-internet-subpage">
   <template>

chrome/browser/resources/settings/chromeos/internet_page/internet_subpage.js

@@ -509,6 +509,7 @@ Polymer({
   onAddThirdPartyVpnTap_(event) {
     const provider = event.model.item;
     this.browserProxy_.addThirdPartyVpn(provider.appId);
+    settings.recordSettingChange();
   },
 
   /**
@@ -575,6 +576,7 @@ Polymer({
     e.target.blur();
     if (this.canAttemptConnection_(networkState)) {
       this.fire('network-connect', {networkState: networkState});
+      settings.recordSettingChange();
       return;
     }
     this.fire('show-detail', networkState);