Commit 3c13d749 authored by Olivier Li's avatar Olivier Li Committed by Commit Bot

Expose the feature flag for the HistoryServiceUsesTaskScheduler experiment to be used in tests.

This is done to be able to prepare tests before eventually submitting a CL that flips the
experiment to ENABLED_BY_DEFAULT.

Bug: 661143
Change-Id: I6b614bb4400478a7e90de78562a54083af1b3bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865596
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707378}
parent 114ef409
...@@ -62,15 +62,17 @@ ...@@ -62,15 +62,17 @@
using base::Time; using base::Time;
namespace history { namespace history {
namespace {
const base::Feature kHistoryServiceUsesTaskScheduler{ namespace {
"HistoryServiceUsesTaskScheduler", base::FEATURE_DISABLED_BY_DEFAULT};
static const char* kHistoryThreadName = "Chrome_HistoryThread"; const char* kHistoryThreadName = "Chrome_HistoryThread";
} // namespace } // namespace
// static
const base::Feature HistoryService::kHistoryServiceUsesTaskScheduler{
"HistoryServiceUsesTaskScheduler", base::FEATURE_DISABLED_BY_DEFAULT};
// Sends messages from the backend to us on the main thread. This must be a // Sends messages from the backend to us on the main thread. This must be a
// separate class from the history service so that it can hold a reference to // separate class from the history service so that it can hold a reference to
// the history service (otherwise we would have to manually AddRef and // the history service (otherwise we would have to manually AddRef and
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
#include "base/callback.h" #include "base/callback.h"
#include "base/callback_list.h" #include "base/callback_list.h"
#include "base/containers/flat_set.h" #include "base/containers/flat_set.h"
#include "base/feature_list.h"
#include "base/files/file_path.h" #include "base/files/file_path.h"
#include "base/location.h" #include "base/location.h"
#include "base/logging.h" #include "base/logging.h"
...@@ -87,6 +88,8 @@ class WebHistoryService; ...@@ -87,6 +88,8 @@ class WebHistoryService;
// as information about downloads. // as information about downloads.
class HistoryService : public KeyedService { class HistoryService : public KeyedService {
public: public:
static const base::Feature kHistoryServiceUsesTaskScheduler;
// Must call Init after construction. The empty constructor provided only for // Must call Init after construction. The empty constructor provided only for
// unit tests. When using the full constructor, |history_client| may only be // unit tests. When using the full constructor, |history_client| may only be
// null during testing, while |visit_delegate| may be null if the embedder use // null during testing, while |visit_delegate| may be null if the embedder use
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment