Commit 3c2bd024 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Fix use-after-move in //components/translate/content/browser/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I4036e35e8d8d8737a327d6133a193c810eb8e929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382595
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: default avataranthonyvd <anthonyvd@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813408}
parent 90dde94f
...@@ -168,7 +168,8 @@ void PerFrameContentTranslateDriver::TranslateFrame( ...@@ -168,7 +168,8 @@ void PerFrameContentTranslateDriver::TranslateFrame(
mojo::AssociatedRemote<mojom::TranslateAgent> frame_agent; mojo::AssociatedRemote<mojom::TranslateAgent> frame_agent;
render_frame_host->GetRemoteAssociatedInterfaces()->GetInterface( render_frame_host->GetRemoteAssociatedInterfaces()->GetInterface(
&frame_agent); &frame_agent);
frame_agent->TranslateFrame( mojom::TranslateAgent* frame_agent_ptr = frame_agent.get();
frame_agent_ptr->TranslateFrame(
translate_script, source_lang, target_lang, translate_script, source_lang, target_lang,
base::BindOnce(&PerFrameContentTranslateDriver::OnFrameTranslated, base::BindOnce(&PerFrameContentTranslateDriver::OnFrameTranslated,
weak_pointer_factory_.GetWeakPtr(), translate_seq_no, weak_pointer_factory_.GetWeakPtr(), translate_seq_no,
...@@ -336,7 +337,8 @@ void PerFrameContentTranslateDriver::StartLanguageDetection() { ...@@ -336,7 +337,8 @@ void PerFrameContentTranslateDriver::StartLanguageDetection() {
mojo::AssociatedRemote<mojom::TranslateAgent> frame_agent; mojo::AssociatedRemote<mojom::TranslateAgent> frame_agent;
web_contents()->GetMainFrame()->GetRemoteAssociatedInterfaces()->GetInterface( web_contents()->GetMainFrame()->GetRemoteAssociatedInterfaces()->GetInterface(
&frame_agent); &frame_agent);
frame_agent->GetWebLanguageDetectionDetails(base::BindOnce( mojom::TranslateAgent* frame_agent_ptr = frame_agent.get();
frame_agent_ptr->GetWebLanguageDetectionDetails(base::BindOnce(
&PerFrameContentTranslateDriver::OnWebLanguageDetectionDetails, &PerFrameContentTranslateDriver::OnWebLanguageDetectionDetails,
weak_pointer_factory_.GetWeakPtr(), std::move(frame_agent))); weak_pointer_factory_.GetWeakPtr(), std::move(frame_agent)));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment