Commit 3c4f58cc authored by Kramer Ge's avatar Kramer Ge Committed by Commit Bot

Tracing category 'gpu_decoder' does not reflect implementation naming

'gpu.decoder' is used in decoders and mismatches chrome://tracing UI.
Resulting in gpu.decoder always disabled.
Rename CL was:
https://chromium-review.googlesource.com/c/chromium/src/+/1334229

Expected behavior: when recording with gpu.decoder, gpu.device and
gpu.service, there should be slices with category
"disabled-by-default-gpu.decoder".

Change-Id: I074a938ce79e05da2b6f931dca35f8f6864fd0c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024070Reviewed-by: default avatarEric Seckler <eseckler@chromium.org>
Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737350}
parent cdf6599f
...@@ -182,7 +182,7 @@ ...@@ -182,7 +182,7 @@
X(TRACE_DISABLED_BY_DEFAULT("gpu_cmd_queue")) \ X(TRACE_DISABLED_BY_DEFAULT("gpu_cmd_queue")) \
X(TRACE_DISABLED_BY_DEFAULT("gpu.dawn")) \ X(TRACE_DISABLED_BY_DEFAULT("gpu.dawn")) \
X(TRACE_DISABLED_BY_DEFAULT("gpu.debug")) \ X(TRACE_DISABLED_BY_DEFAULT("gpu.debug")) \
X(TRACE_DISABLED_BY_DEFAULT("gpu_decoder")) \ X(TRACE_DISABLED_BY_DEFAULT("gpu.decoder")) \
X(TRACE_DISABLED_BY_DEFAULT("gpu.device")) \ X(TRACE_DISABLED_BY_DEFAULT("gpu.device")) \
X(TRACE_DISABLED_BY_DEFAULT("gpu.service")) \ X(TRACE_DISABLED_BY_DEFAULT("gpu.service")) \
X(TRACE_DISABLED_BY_DEFAULT("histogram_samples")) \ X(TRACE_DISABLED_BY_DEFAULT("histogram_samples")) \
......
...@@ -475,7 +475,7 @@ class YUVReadbackTest : public testing::Test { ...@@ -475,7 +475,7 @@ class YUVReadbackTest : public testing::Test {
TEST_F(YUVReadbackTest, YUVReadbackOptTest) { TEST_F(YUVReadbackTest, YUVReadbackOptTest) {
for (int use_mrt = 0; use_mrt <= 1; ++use_mrt) { for (int use_mrt = 0; use_mrt <= 1; ++use_mrt) {
// This test uses the gpu.service/gpu_decoder tracing events to detect how // This test uses the gpu.service/gpu.decoder tracing events to detect how
// many scaling passes are actually performed by the YUV readback pipeline. // many scaling passes are actually performed by the YUV readback pipeline.
StartTracing(TRACE_DISABLED_BY_DEFAULT( StartTracing(TRACE_DISABLED_BY_DEFAULT(
"gpu.service") "," TRACE_DISABLED_BY_DEFAULT("gpu.decoder")); "gpu.service") "," TRACE_DISABLED_BY_DEFAULT("gpu.decoder"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment