Move AppModelBuilder related unit tests to AppService folder.

Move below unit tests to AppService folder, because they use
AppServiceAppModelBuilder for test:
CrostiniAppModelBuilderTest
ExtensionAppModelBuilderTest
InternalAppModelBuilderTest

BUG=1016159

Change-Id: I2aef91d4bb3b847a8861dca6b692bd0d92f0c4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942897Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720731}

chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc

-// Copyright 2018 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/macros.h"
-#include "base/strings/string_util.h"
-#include "chrome/browser/apps/app_service/app_service_proxy.h"
-#include "chrome/browser/apps/app_service/app_service_proxy_factory.h"
-#include "chrome/browser/apps/app_service/app_service_test.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/app_list/app_list_test_util.h"
-#include "chrome/browser/ui/app_list/app_service/app_service_app_model_builder.h"
-#include "chrome/browser/ui/app_list/chrome_app_list_item.h"
-#include "chrome/browser/ui/app_list/internal_app/internal_app_metadata.h"
-#include "chrome/browser/ui/app_list/test/fake_app_list_model_updater.h"
-#include "chrome/browser/ui/app_list/test/test_app_list_controller_delegate.h"
-#include "chrome/test/base/testing_profile.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace {
-
-// Get a set of all apps in |model|.
-std::string GetModelContent(AppListModelUpdater* model_updater) {
-  std::vector<std::string> app_names;
-  for (size_t i = 0; i < model_updater->ItemCount(); ++i)
-    app_names.emplace_back(model_updater->ItemAtForTest(i)->name());
-  return base::JoinString(app_names, ",");
-}
-
-// For testing purposes, we want to pretend there are only BuiltIn apps on the
-// system. This method removes the others.
-void RemoveNonBuiltInApps(Profile* profile,
-                          FakeAppListModelUpdater* model_updater) {
-  apps::AppServiceProxy* proxy =
-      apps::AppServiceProxyFactory::GetForProfile(profile);
-  DCHECK(proxy);
-  proxy->FlushMojoCallsForTesting();
-  proxy->AppRegistryCache().ForEachApp(
-      [&model_updater](const apps::AppUpdate& update) {
-        if (update.AppType() != apps::mojom::AppType::kBuiltIn) {
-          model_updater->RemoveItem(update.AppId());
-        }
-      });
-}
-
-}  // namespace
-
-class InternalAppModelBuilderTest : public AppListTestBase {
- public:
-  InternalAppModelBuilderTest() {}
-  ~InternalAppModelBuilderTest() override {}
-
-  // AppListTestBase:
-  void SetUp() override {
-    AppListTestBase::SetUp();
-  }
-
-  void TearDown() override {
-    ResetBuilder();
-    AppListTestBase::TearDown();
-  }
-
- protected:
-  // Creates a new builder, destroying any existing one.
-  void CreateBuilder(bool guest_mode) {
-    ResetBuilder();  // Destroy any existing builder in the correct order.
-
-    app_service_test_.UninstallAllApps(profile());
-    testing_profile()->SetGuestSession(guest_mode);
-    app_service_test_.SetUp(testing_profile());
-    model_updater_ = std::make_unique<FakeAppListModelUpdater>();
-    controller_ = std::make_unique<test::TestAppListControllerDelegate>();
-    builder_ = std::make_unique<AppServiceAppModelBuilder>(controller_.get());
-    builder_->Initialize(nullptr, testing_profile(), model_updater_.get());
-    RemoveNonBuiltInApps(testing_profile(), model_updater_.get());
-  }
-
-  std::unique_ptr<FakeAppListModelUpdater> model_updater_;
-
- private:
-  void ResetBuilder() {
-    builder_.reset();
-    controller_.reset();
-    model_updater_.reset();
-  }
-
-  apps::AppServiceTest app_service_test_;
-  std::unique_ptr<test::TestAppListControllerDelegate> controller_;
-  std::unique_ptr<AppServiceAppModelBuilder> builder_;
-
-  DISALLOW_COPY_AND_ASSIGN(InternalAppModelBuilderTest);
-};
-
-TEST_F(InternalAppModelBuilderTest, Build) {
-  // The internal apps list is provided by GetInternalAppList() in
-  // internal_app_metadata.cc. Only count the apps can display in launcher.
-  std::string internal_apps_name;
-  CreateBuilder(false);
-  EXPECT_EQ(app_list::GetNumberOfInternalAppsShowInLauncherForTest(
-                &internal_apps_name, profile()),
-            model_updater_->ItemCount());
-  EXPECT_EQ(internal_apps_name, GetModelContent(model_updater_.get()));
-}
-
-TEST_F(InternalAppModelBuilderTest, BuildGuestMode) {
-  // The internal apps list is provided by GetInternalAppList() in
-  // internal_app_metadata.cc. Only count the apps can display in launcher.
-  std::string internal_apps_name;
-  CreateBuilder(true);
-  EXPECT_EQ(app_list::GetNumberOfInternalAppsShowInLauncherForTest(
-                &internal_apps_name, profile()),
-            model_updater_->ItemCount());
-  EXPECT_EQ(internal_apps_name, GetModelContent(model_updater_.get()));
-}

chrome/test/BUILD.gn

@@ -4156,6 +4156,7 @@ test("unit_tests") {
       "../browser/ui/app_list/app_list_syncable_service_unittest.cc",
       "../browser/ui/app_list/app_list_test_util.cc",
       "../browser/ui/app_list/app_list_test_util.h",
+      "../browser/ui/app_list/app_service/app_service_app_model_builder_unittest.cc",
       "../browser/ui/app_list/arc/arc_app_test.cc",
       "../browser/ui/app_list/arc/arc_app_test.h",
       "../browser/ui/app_list/arc/arc_app_unittest.cc",
@@ -4163,9 +4164,6 @@ test("unit_tests") {
       "../browser/ui/app_list/arc/arc_vpn_provider_unittest.cc",
       "../browser/ui/app_list/arc/mock_arc_app_list_prefs_observer.cc",
       "../browser/ui/app_list/arc/mock_arc_app_list_prefs_observer.h",
-      "../browser/ui/app_list/crostini/crostini_app_model_builder_unittest.cc",
-      "../browser/ui/app_list/extension_app_model_builder_unittest.cc",
-      "../browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc",
       "../browser/ui/app_list/md_icon_normalizer_unittest.cc",
       "../browser/ui/app_list/search/answer_card/answer_card_result_unittest.cc",
       "../browser/ui/app_list/search/answer_card/answer_card_search_provider_unittest.cc",