Commit 3c780d2f authored by David Munro's avatar David Munro Committed by Commit Bot

crostini: Add a note to SetupResult about updating plx

Bug: None
Test: None
Change-Id: If32ba431a5404b80cd5cf58f03b6b57906254f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379452
Commit-Queue: David Munro <davidmunro@google.com>
Commit-Queue: Fergus Dall <sidereal@google.com>
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: default avatarFergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#802489}
parent 91aae573
...@@ -29,7 +29,9 @@ class CrostiniInstaller : public KeyedService, ...@@ -29,7 +29,9 @@ class CrostiniInstaller : public KeyedService,
public: public:
// These values are persisted to logs. Entries should not be renumbered and // These values are persisted to logs. Entries should not be renumbered and
// numeric values should never be reused. // numeric values should never be reused.
// When you add entries to this enum don't forget to update enums.xml // When you add entries to this enum don't forget to update enums.xml and the
// plx scripts in
// https://plx.corp.google.com/home2/home/collections/c16e3c1474497b821
enum class SetupResult { enum class SetupResult {
kNotStarted = 0, kNotStarted = 0,
// kUserCancelled = 1, // kUserCancelled = 1,
...@@ -64,6 +66,8 @@ class CrostiniInstaller : public KeyedService, ...@@ -64,6 +66,8 @@ class CrostiniInstaller : public KeyedService,
kErrorUnknown = 26, kErrorUnknown = 26,
kMaxValue = kErrorUnknown, kMaxValue = kErrorUnknown,
// When adding a new value, check you've followed the steps in the comment
// at the top of this enum.
}; };
static CrostiniInstaller* GetForProfile(Profile* profile); static CrostiniInstaller* GetForProfile(Profile* profile);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment