Remove OverflowIconsForMediaControls feature.

There's a note in media_switches.cc indicating that this feature is okay
to be removed.

Bug: 1126640
Change-Id: Ie4c87b13fb573327038753ea30a59708df3bc691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427213Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#811460}

content/child/runtime_features.cc

@@ -238,8 +238,6 @@ void SetRuntimeFeaturesFromChromiumFeatures() {
      features::kLazyInitializeMediaControls},
     {wf::EnableMediaEngagementBypassAutoplayPolicies,
      media::kMediaEngagementBypassAutoplayPolicies},
-    {wf::EnableOverflowIconsForMediaControls,
-     media::kOverflowIconsForMediaControls},
     {wf::EnableAllowActivationDelegationAttr,
      features::kAllowActivationDelegationAttr},
     {wf::EnableLazyFrameLoading, features::kLazyFrameLoading},

media/base/media_switches.cc

@@ -685,11 +685,6 @@ std::string GetEffectiveAutoplayPolicy(const base::CommandLine& command_line) {
 #endif
 }
 
-// Adds icons to the overflow menu on the native media controls.
-// TODO(steimel): Remove this.
-const base::Feature kOverflowIconsForMediaControls{
-    "OverflowIconsForMediaControls", base::FEATURE_ENABLED_BY_DEFAULT};
-
 // Enables Media Engagement Index recording. This data will be used to determine
 // when to bypass autoplay policies. This is recorded on all platforms.
 const base::Feature kRecordMediaEngagementScores{

media/base/media_switches.h

@@ -159,7 +159,6 @@ MEDIA_EXPORT extern const base::Feature kMediaLearningSmoothnessExperiment;
 MEDIA_EXPORT extern const base::Feature kMediaOptimizer;
 MEDIA_EXPORT extern const base::Feature kMediaPowerExperiment;
 MEDIA_EXPORT extern const base::Feature kMemoryPressureBasedSourceBufferGC;
-MEDIA_EXPORT extern const base::Feature kOverflowIconsForMediaControls;
 MEDIA_EXPORT extern const base::Feature kOverlayFullscreenVideo;
 MEDIA_EXPORT extern const base::Feature kPictureInPicture;
 MEDIA_EXPORT extern const base::Feature kPreloadMediaEngagementData;

testing/variations/fieldtrial_testing_config.json

@@ -5088,26 +5088,6 @@
             ]
         }
     ],
-    "OverflowIconsForMediaControls": [
-        {
-            "platforms": [
-                "android",
-                "android_weblayer",
-                "chromeos",
-                "linux",
-                "mac",
-                "windows"
-            ],
-            "experiments": [
-                {
-                    "name": "Enabled",
-                    "enable_features": [
-                        "OverflowIconsForMediaControls"
-                    ]
-                }
-            ]
-        }
-    ],
     "PaintHoldingCrossOrigin": [
         {
             "platforms": [

third_party/blink/public/platform/web_runtime_features.h

@@ -131,7 +131,6 @@ class WebRuntimeFeatures {
   BLINK_PLATFORM_EXPORT static void EnableNotifications(bool);
   BLINK_PLATFORM_EXPORT static void EnableOnDeviceChange(bool);
   BLINK_PLATFORM_EXPORT static void EnableOrientationEvent(bool);
-  BLINK_PLATFORM_EXPORT static void EnableOverflowIconsForMediaControls(bool);
   BLINK_PLATFORM_EXPORT static void EnableOverlayScrollbars(bool);
   BLINK_PLATFORM_EXPORT static void EnableOverscrollCustomization(bool);
   BLINK_PLATFORM_EXPORT static void EnablePagePopup(bool);

third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc

@@ -206,11 +206,6 @@ void MediaControlInputElement::UpdateShownState() {
       parent->SetInlineStyleProperty(CSSPropertyID::kDisplay,
                                      CSSValueID::kNone);
     }
-
-    // Don't update the shown state of the element if we want to hide
-    // icons on the overflow menu.
-    if (!RuntimeEnabledFeatures::OverflowIconsForMediaControlsEnabled())
-      return;
   }
 
   MediaControlElementBase::UpdateShownState();

third_party/blink/renderer/platform/exported/web_runtime_features.cc

@@ -297,10 +297,6 @@ void WebRuntimeFeatures::EnableOrientationEvent(bool enable) {
   RuntimeEnabledFeatures::SetOrientationEventEnabled(enable);
 }
 
-void WebRuntimeFeatures::EnableOverflowIconsForMediaControls(bool enable) {
-  RuntimeEnabledFeatures::SetOverflowIconsForMediaControlsEnabled(enable);
-}
-
 void WebRuntimeFeatures::EnableOverscrollCustomization(bool enable) {
   RuntimeEnabledFeatures::SetOverscrollCustomizationEnabled(enable);
 }

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -1374,9 +1374,6 @@
     {
       name: "OverflowClip",
     },
-    {
-      name: "OverflowIconsForMediaControls",
-    },
     {
       name: "OverscrollCustomization",
       settable_from_internals: true,