Commit 3ca584af authored by Roger Tawa's avatar Roger Tawa Committed by Commit Bot

Revert "webrtc-internals: only highlight currently active connection"

This reverts commit 9eaaf8d9.

Reason for revert: Speculatively reverting to try and fix compile error:

https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133884

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FAndroid_Builder%2F133884%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original change's description:
> webrtc-internals: only highlight currently active connection
> 
> and remove the class from any past ones.
> 
> BUG=678292
> 
> Change-Id: I5a3bc354f45363573ed8604fbbc27ee2530faa66
> Reviewed-on: https://chromium-review.googlesource.com/615500
> Reviewed-by: Tommi <tommi@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543371}

TBR=tommi@chromium.org,hta@chromium.org,philipp.hancke@googlemail.com

Change-Id: Ibaa7ea4489e195b39180ad24efdb21796e285faf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 678292
Reviewed-on: https://chromium-review.googlesource.com/964394Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543376}
parent 0b2b1a92
...@@ -133,7 +133,6 @@ var StatsTable = (function(ssrcInfoManager) { ...@@ -133,7 +133,6 @@ var StatsTable = (function(ssrcInfoManager) {
updateStatsTableRow_: function(statsTable, rowName, value) { updateStatsTableRow_: function(statsTable, rowName, value) {
var trId = statsTable.id + '-' + rowName; var trId = statsTable.id + '-' + rowName;
var trElement = $(trId); var trElement = $(trId);
var activeConnectionClass = 'stats-table-active-connection';
if (!trElement) { if (!trElement) {
trElement = document.createElement('tr'); trElement = document.createElement('tr');
trElement.id = trId; trElement.id = trId;
...@@ -143,13 +142,8 @@ var StatsTable = (function(ssrcInfoManager) { ...@@ -143,13 +142,8 @@ var StatsTable = (function(ssrcInfoManager) {
trElement.cells[1].textContent = value; trElement.cells[1].textContent = value;
// Highlights the table for the active connection. // Highlights the table for the active connection.
if (rowName == 'googActiveConnection') { if (rowName == 'googActiveConnection' && value == true)
if (value === 'true') statsTable.parentElement.classList.add('stats-table-active-connection');
statsTable.parentElement.classList.add(activeConnectionClass);
} else {
statsTable.parentElement.classList.remove(activeConnectionClass);
}
}
} }
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment