Skip to content

GitLab

T
tangled
Commit 3cb095d1 authored by jfernandez@igalia.com's avatar jfernandez@igalia.com
Browse files
Options

[CSS Grid Layout] the "grid-template-areas" is not identified as computable property. 

The "grid-template-areas" property is a computable area, defined in the
CSSComputedStyleDeclaration class with an specific computed value. However,
it's not shown by the Web Inspector in the corresponding Computed tab.

It seems that the root cause of this issue is that the property is not
present in the CSSComputedStyleDeclaration::staticComputableProperties.


BUG=79180

Review URL: https://codereview.chromium.org/200263003

git-svn-id: svn://svn.chromium.org/blink/trunk@170318 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent aadff0b2
Hide whitespace changes
Inline Side-by-side
Showing with 53 additions and 0 deletions
third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout-expected.txt 0 → 100644
View file @ 3cb095d1
CSS Grid Layout Attributes that are exposed in the CSS computed style object:
grid-auto-columns: auto;
grid-auto-flow: none;
grid-auto-rows: auto;
grid-column-end: auto;
grid-column-start: auto;
grid-template-areas: none;
grid-template-columns: none;
grid-template-rows: none;
grid-row-end: auto;
grid-row-start: auto;
third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-grid-layout.html 0 → 100644
View file @ 3cb095d1
<!DOCTYPE html>
<html>
<script>
var propertiesToTest = {
"grid-auto-columns": true,
"grid-auto-flow": true,
"grid-auto-rows": true,
"grid-area": true,
"grid-column": true,
"grid-column-end": true,
"grid-column-start": true,
"grid-template-columns": true,
"grid-template-rows": true,
"grid-row": true,
"grid-row-end": true,
"grid-row-start": true,
"grid-template-areas": true,
};
function test()
{
if (window.testRunner)
testRunner.dumpAsText();
var style = document.defaultView.getComputedStyle(document.body, "");
var text = "";
for (var i = 0; i != style.length; ++i) {
var name = style.item(i);
if (!propertiesToTest[name])
continue;
text += name + ": " + style.getPropertyValue(name) + ";\n";
}
document.getElementById("exposed").textContent = text;
}
</script>
<body onload="test()">
<p>CSS Grid Layout Attributes that are exposed in the CSS computed style object:</p>
<p id="exposed" style="white-space: pre"></p>
</body>
</html>
third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
View file @ 3cb095d1
...@@ -268,6 +268,7 @@ static const CSSPropertyID staticComputableProperties[] = { ...@@ -268,6 +268,7 @@ static const CSSPropertyID staticComputableProperties[] = {
CSSPropertyGridAutoRows, CSSPropertyGridAutoRows,
CSSPropertyGridColumnEnd, CSSPropertyGridColumnEnd,
CSSPropertyGridColumnStart, CSSPropertyGridColumnStart,
CSSPropertyGridTemplateAreas,
CSSPropertyGridTemplateColumns, CSSPropertyGridTemplateColumns,
CSSPropertyGridTemplateRows, CSSPropertyGridTemplateRows,
CSSPropertyGridRowEnd, CSSPropertyGridRowEnd,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment